steve-jansen / job-dsl-plugin Goto Github PK

Hello,

Here job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/promotions/ConditionsContext.groovy
is mistake.
It is:
void parameterizedSelfPromotion(Boolean evenIfUnstable, String parameterName, String parameterValue) {
parameterizedSelfPromotion = true
if (evenIfUnstable) {
this.parameterizedSelfPromotion = evenIfUnstable
}

It should be:
void parameterizedSelfPromotion(Boolean evenIfUnstable, String parameterName, String parameterValue) {
isParameterizedSelfPromotion = true
if (evenIfUnstable) {
this.evenIfUnstableParameterized = evenIfUnstable
}

Could you please correct this?

The jenkins-dsl-plugin lacks the ability to queue newly created jobs for build. While the DSL provides the queue(job) and queue(jobName) methods, there is no way to easily discern/filter jobs that are newly created vs jobs that already exist.

This is a problem for jobs that have expensive build steps to run (e.g., kitchen test), or jobs that are not idempotent (e.g., version bumping). The chef CD pipeline has both expensive steps and non-idempotent steps in the early stage(s).

Looking at the source for job-dsl-plugin ExecuteDslScripts method lines 162-164 and lines 247-249, it seems this should be possible to implement using a couple new UI checkbox options (i.e., java Stapler templates) for build actions when adding or modifying jobs.

Believe we could fork the job-dsl-plugin repo and submit a PR for the javaposse.jobdsl.plugin.ExecuteDslScripts classthat does something along the lines of:

// Line 162
updateGeneratedJobs(build, listener, freshJobs);
// add the ability to trigger a build for newly created jobs
queueCreatedJobs(jm, build, listener, freshJobs);
...
// new method to implement
private void queueCreatedJobs(JenkinsJobManagement jm, final AbstractBuild<?, ?> build, BuildListener listener, Set<GeneratedJob> freshJobs) throws IOException {
        Set<GeneratedJob> generatedJobs = extractGeneratedJobs(build.getProject());
        Set<GeneratedJob> added = Sets.difference(freshJobs, generatedJobs);

        for (GeneratedJob addedJob : added) {
                if (createdJobAction == CreateJobAction.BUILD) {
                    try {
                        jm.queueJob(addedJob);
                    } catch /* ... */ {}
        }

Hi @steve-jansen,

I installed today your alpha release from here in order to use the promotion feature with Jenkins DSL and I found a bug when the generated job is saved in a folder (created using Cloudbees Folders Plugin).

It is a path issue from my checks because the promotion folder is saved in the folder root and not in the job root. I can add more details if you are interesed to fix this issue.