Today I stumbled upon a REST-API which defined PUT/POST requests with additional GET-params (for a login token).
It would be nice if we could find an elegant way to support this.
One idea would be to export ajar.req(method, url, gdata, pdata) for generic requests, but I'm not that happy with it.

Hello,

do you have any preferences according to the tests of your lib? Jasmine? Mocha? What did you used in other projects so far?

Hello,

since params is an object, it derives from the Object constructor function. That means, you're likely assigning things you don't want in your code.

Best practice:

for (key in params) {
    if (params.hasOwnProperty(key) {
        qstr.push(encodeURIComponent(key) + '=' + encodeURIComponent(params[key]))
    }
}

Since you wrote your code in CommonJS module syntax, I assume it's meant to run inside node.

Where do you load the XMLHttpRequest constructor function which is part of the window object inside browsers?

I found several libraries for node, which emulate it, but you wrote in your README, that you want to have a dependency-free lib …

Sadly, JSDoc isn't ready for ECMAScript 2015 (aka ES6), but you have some other choices.

This way, contributors can get an idea of how the code shall behave.

You may want to strip those comments in a minified build ;-)

During the course of writing tests for your lib I encountered qstr and key not being defined. You may want to opt in for strict mode and declare those variables on top of that function.

If possible, I wouldn't opt for naming a method delete since it can be confused with JavaScript's delete operator (and IE does so).

AngularJS has a remove method because of that.

Discovered while working on #5.

Right now, you're writting CommonJS code (like: a node module).

But AJAX is likely used in client side JavaScript, i.e. a browser, where CommonJS' blocking nature isn't that admirable. Consider wrapping your code in a way, so that it is loadable as AMD module as well.

Read Why AMD? or about ES6 modules.

That is, rewrite your export to

export default {
    get: (url, data) => request('GET', url, data, null)
    post: (url, data) => request('POST', url, null, data)
    put: (url, data) => request('PUT', url, null, data)
    delete: (url, data) => request('DELETE', url, data, null)
}

and you're done :-)

Hello,

since you're diving into ECMAScript 2015 (aka ES2015 aka ECMAScript 6) anyway, you could take advantage of template strings in your code. For example:

qstr.push(encodeURIComponent(key) + '=' + encodeURIComponent(params[key]))

could be written as

qstr.push(`${encodeURIComponent(key)}=${encodeURIComponent(params[key])})

Okay, it will make more sense if the string gets larger, but you get the idea :-)