sterlingwes / randomcolor Goto Github PK

probably just me but might help someone else.
So i imported the rcolor.js into my node project but when i call

var color = new RColor;
var c2 = color.get(true);

i get a fatal error that breaks my program

RColor is not defined

the rcolor.js is in the same directory as the function I'm calling, so its not a nesting issue it just doesn't reconize it.

Problem: using an HSV Value < 2 results in color literals with less than six hex digits (e.g. "#19177", because toString(16) doesn't pad left with zeros. These values are ignored by CSS,

I offer a method here that corrects this problem:

RColor.prototype.byteToHex = function(number) {
    var size = 2; // minimum string length, padded left with zeros
    var numStr = number.toString(16);
    while (numStr.length < size) numStr = "0" + numStr;
    return numStr;
};

Then, in RColor.prototype.get():

    if(hex)
        return = "#" + this.byteToHex(rgb[0])
                         + this.byteToHex(rgb[1])
                         + this.byteToHex(rgb[2]);

Thanks. This project is very useful and well-crafted.

This library often generates colours that are too close in proximity to others in a series. Should add some maths to account for this and ensure a certain amount of differentiation within a certain sample size.

For reference: http://www.brucelindbloom.com/index.html?Equations.html

Two things that were missing for me in this script. This states it's useful for charts and diagrams, but while you may want random distinct colors, you often want them to be the same random colors each time the page is loaded. So it would be nice to have an initial seed value, instead of a Random value based on system time. Perhaps something like this:

var RColor = function(seed) {
    this.hue            = seed || Math.random(),
    this.goldenRatio    = 0.618033988749895;
    this.hexwidth       = 2;
};

Secondly, I often have Id's set to particular sets of data. Group 1 gets one color, Group 2 another, etc. So it would be nice to allow it to get that same random color given an Id. Perhaps something like this, after setting this up in the initialization.

this.initialhue = this.hue;

RColor.prototype.getById = function(id,hex,saturation,value) {
    if (id % 1 !== 0) return this.get(hex,saturation,value);
    hueval = this.initialhue;
    hueval += this.goldenRatio * id;
    hueval %= 1;
    if(typeof saturation !== "number")  saturation = 0.5;
    if(typeof value !== "number")       value = 0.95;
    var rgb = this.hsvToRgb(this.hue,saturation,value);
    if(hex)
        return "#" +  this.padHex(rgb[0].toString(16))
                    + this.padHex(rgb[1].toString(16))
                    + this.padHex(rgb[2].toString(16));
    else
        return rgb;
};