The base-currency-converter from stephenjfox

base-currency-converter's People

Contributors

Watchers

base-currency-converter's Issues

Convert button click changes conversion target

In brief, the problem is this TextWatcher implementation: perhaps passing through the edit text is the wrong way to go, and it should be bound to the click.

To experience the undesired behavior:

Input any value in either field
Tap "convert"
Change the other corresponding spinner
Tap "convert"

Source:

  private class PassThroughListener implements TextWatcher {

    private final EditText invoker;

    PassThroughListener(final EditText invoker) {
      this.invoker = invoker;
    }

    @Override
    public void beforeTextChanged(final CharSequence s,
                                  final int start,
                                  final int count,
                                  final int after) {
      // omitted intentionally
    }

    @Override
    public void onTextChanged(final CharSequence s,
                              final int start,
                              final int before,
                              final int count) {
      // omitted intentionally
    }

    @Override
    public void afterTextChanged(final Editable s) {
      if (s.length() != 0) {
        mLastEdited = invoker;
      }
    }
  }

Recommend Projects