stefanodevuono / steghide Goto Github PK

View Code? Open in Web Editor NEW

561.0 561.0 83.0 651 KB

License: GNU General Public License v2.0

Shell 4.95% C 19.85% C++ 54.03% Perl 0.63% Makefile 12.96% Yacc 0.69% M4 6.85% sed 0.03%

steghide's People

Contributors

Stargazers

Watchers

Forkers

lopesboa pir8aye devnullteam clonmac otsector murthysagi arryboom aminuxer joncampbell123 355380o726602 marciopocebon w1ck3dth1ngs three-winters xianlimei idkwim cyberfallen bwm12 5l1v3r1 modulexcite inspectordidi snotsbubble vesor stephenharuna antonioanerao ssghost gprime31 qp53catoei2wwrhhsoco latkes asdcxsd dfw1n tcarters cnlog lizard-35 telometto achabahe danielchudc yogeshraturi luis-caldas struva mohamedsaad34 onkobu femiamah maddy-glitch phoenixrising1800 teddymwai matzefriedrich eurekax696 dreamarms xmonader uionto rk-yui hartl3y94 ir4qi optimisticninja philipprochazka hamza7719 liutz dmclark02 walexzzy nati0n kfdslsope lordgriffo vrdfola olog2n iq-thinker furkanakkurt1335 arnavmetrani btlorch saturday-morning ok-john app-creative guessthetool ikhode-kh dewebdes tliemngy sorokinvld leixh filthyshoe d00minati chgsyh eptrvsky sffej

steghide's Issues

Arbitrary file write

Steghide doesn't sanitize the output file, which allows arbitrary files to be written.
See https://firzen.de/git-rekt-2-steghide for details.

wav format is not supported

Hello, I have a problem when I want to embed .wav and actually also .au audio file format using steghide like this

Any solutions?

steghide algorithm

hi,Stefan Hetzl:
I had one question to ask, it's algorithm about steghide, is LSB(Least Significant Bit)?

thanks!

Steghide Makefile fails with critical error on Ubuntu 18.04

What I did

Ran ./configure on an Ubuntu 18.04 machine (within VirtualBox) with libmhash, libmcrypt, zlib and libjpeg installed
Ran make

What I expected to happen

Make completed successfully

What actually happened

Makefile failed with the below error. Running as root did not change the result.

stego@stego-VirtualBox:~/Documents/steghide$ make 
make  all-recursive
make[1]: Entering directory '/home/stego/Documents/steghide'
Making all in m4
make[2]: Entering directory '/home/stego/Documents/steghide/m4'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/home/stego/Documents/steghide/m4'
Making all in intl
make[2]: Entering directory '/home/stego/Documents/steghide/intl'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/home/stego/Documents/steghide/intl'
Making all in po
make[2]: Entering directory '/home/stego/Documents/steghide/po'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/home/stego/Documents/steghide/po'
Making all in doc
make[2]: Entering directory '/home/stego/Documents/steghide/doc'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/home/stego/Documents/steghide/doc'
Making all in src
make[2]: Entering directory '/home/stego/Documents/steghide/src'
if g++ -DHAVE_CONFIG_H -I. -I. -I..  -DLOCALEDIR=\"/usr/local/share/locale\"   -O2 -Wall -MT Arguments.o -MD -MP -MF ".deps/Arguments.Tpo" \
  -c -o Arguments.o `test -f 'Arguments.cc' || echo './'`Arguments.cc; \
then mv ".deps/Arguments.Tpo" ".deps/Arguments.Po"; \
else rm -f ".deps/Arguments.Tpo"; exit 1; \
fi
In file included from common.h:101:0,
                 from MCryptPP.h:21,
                 from Arguments.cc:25:
Arguments.h:103:22: error: ‘constexpr’ needed for in-class initialization of static data member ‘const float Arguments::Default_Goal’ of non-integral type [-fpermissive]
  static const float  Default_Goal = 100.0 ;
                      ^~~~~~~~~~~~
Makefile:395: recipe for target 'Arguments.o' failed
make[2]: *** [Arguments.o] Error 1
make[2]: Leaving directory '/home/stego/Documents/steghide/src'
Makefile:259: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/home/stego/Documents/steghide'
Makefile:190: recipe for target 'all' failed
make: *** [all] Error 2

mv: não foi possível obter estado de 't-es.gmo': Arquivo ou diretório inexistente

make[2]: Entering directory '/home/markov/hack/steghide/po'
cd ..
&& CONFIG_FILES=po/Makefile.in CONFIG_HEADERS=
/bin/sh ./config.status
config.status: creating po/Makefile.in
config.status: WARNING: 'po/Makefile.in.in' seems to ignore the --datarootdir setting
config.status: executing depfiles commands
config.status: executing default-1 commands
config.status: creating po/POTFILES
config.status: creating po/Makefile
rm -f es.gmo && : -c --statistics -o es.gmo es.po
mv: não foi possível obter estado de 't-es.gmo': Arquivo ou diretório inexistente
Makefile:207: recipe for target 'es.gmo' failed
make[2]: *** [es.gmo] Error 1
make[2]: Leaving directory '/home/markov/hack/steghide/po'
Makefile:259: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/home/markov/hack/steghide'
Makefile:190: recipe for target 'all' failed
make: *** [all] Error 2

does not compile - syntax error ru.po

When compiling with ./configure && make it generates this error.

Making all in po
make[2]: Entering directory '/home/paul/repositories/steghide/po'
cd .. \
  && CONFIG_FILES=po/Makefile.in CONFIG_HEADERS= \
       /bin/sh ./config.status
config.status: creating po/Makefile.in
config.status: WARNING:  'po/Makefile.in.in' seems to ignore the --datarootdir setting
config.status: executing depfiles commands
config.status: executing default-1 commands
config.status: creating po/POTFILES
config.status: creating po/Makefile
rm -f de.gmo && /usr/bin/msgfmt -c --statistics -o de.gmo de.po
rm -f fr.gmo && /usr/bin/msgfmt -c --statistics -o fr.gmo fr.po
rm -f ro.gmo && /usr/bin/msgfmt -c --statistics -o ro.gmo ro.po
rm -f es.gmo && /usr/bin/msgfmt -c --statistics -o es.gmo es.po
de.po:7: warning: header field 'Language' missing in header
185 translated messages.
ro.po:6: warning: header field 'Language' missing in header
185 translated messages.
es.po:6: warning: fr.po:8: warning: header field 'Language' missing in header
header field 'Language' missing in header
185 translated messages.
185 translated messages.
rm -f ru.gmo && /usr/bin/msgfmt -c --statistics -o ru.gmo ru.po
ru.po:1219:10: syntax error
/usr/bin/msgfmt: found 1 fatal error
make[2]: *** [Makefile:207: ru.gmo] Error 1
make[2]: Leaving directory '/home/paul/repositories/steghide/po'
make[1]: *** [Makefile:259: all-recursive] Error 1
make[1]: Leaving directory '/home/paul/repositories/steghide'
make: *** [Makefile:190: all] Error 2

I don't need russian text, so i removed ru.po and all related files from the makefile in po.
I get the following output.

[...]
In file included from common.h:101,
                 from MCryptPP.h:21,
                 from Arguments.cc:25:
Arguments.h:103:22: error: ‘constexpr’ needed for in-class initialization of static data member ‘const float Arguments::Default_Goal’ of non-integral type [-fpermissive]
  103 |  static const float  Default_Goal = 100.0 ;
      |                      ^~~~~~~~~~~~
[...]
In file included from AuFile.cc:26:
AuData.h:29:13: error: specializing member ‘AudioDataImpl<AuMuLaw, unsigned char>::readValue’ requires ‘template<>’ syntax
   29 | inline BYTE AuMuLawAudioData::readValue (BinaryIO* io) const { return (io->read8()) ; }
      |             ^~~~~~~~~~~~~~~~
AuData.h:30:13: error: specializing member ‘AudioDataImpl<AuMuLaw, unsigned char>::writeValue’ requires ‘template<>’ syntax
   30 | inline void AuMuLawAudioData::writeValue (BinaryIO* io, BYTE v) const { io->write8(v) ; }
      |             ^~~~~~~~~~~~~~~~
AuData.h:34:14: error: specializing member ‘AudioDataImpl<AuPCM8, signed char>::readValue’ requires ‘template<>’ syntax
   34 | inline SBYTE AuPCM8AudioData::readValue (BinaryIO* io) const { return ((SBYTE) io->read8()) ; }
      |              ^~~~~~~~~~~~~~~
AuData.h:35:13: error: specializing member ‘AudioDataImpl<AuPCM8, signed char>::writeValue’ requires ‘template<>’ syntax
   35 | inline void AuPCM8AudioData::writeValue (BinaryIO* io, SBYTE v) const { io->write8((BYTE) v) ; }
      |             ^~~~~~~~~~~~~~~
AuData.h:39:16: error: specializing member ‘AudioDataImpl<AuPCM16, short int>::readValue’ requires ‘template<>’ syntax
   39 | inline SWORD16 AuPCM16AudioData::readValue (BinaryIO* io) const { return ((SWORD16) io->read16_be()) ; }
      |                ^~~~~~~~~~~~~~~~
AuData.h:40:13: error: specializing member ‘AudioDataImpl<AuPCM16, short int>::writeValue’ requires ‘template<>’ syntax
   40 | inline void AuPCM16AudioData::writeValue (BinaryIO* io, SWORD16 v) const { io->write16_be((UWORD16) v) ; }
      |             ^~~~~~~~~~~~~~~~
AuData.h:44:16: error: specializing member ‘AudioDataImpl<AuPCM32, int>::readValue’ requires ‘template<>’ syntax
   44 | inline SWORD32 AuPCM32AudioData::readValue (BinaryIO* io) const { return ((SWORD32) io->read32_be()) ; }
      |                ^~~~~~~~~~~~~~~~
AuData.h:45:13: error: specializing member ‘AudioDataImpl<AuPCM32, int>::writeValue’ requires ‘template<>’ syntax
   45 | inline void AuPCM32AudioData::writeValue (BinaryIO* io, SWORD32 v) const { io->write32_be((UWORD32) v) ; }
      |             ^~~~~~~~~~~~~~~~

Segmentation fault

After trying to put a picture with .txt file in it, in another picture i got same error on every usage.
Here's example:

steghide embed -ef file2.tar.gz -cf file1.wav Enter passphrase: Re-Enter passphrase: [1] 11418 segmentation fault steghide embed -ef file2.tar.gz -cf file1.wav

Reinstallation doesn't help.

Stack Based Buffer Overflow | Embedder.cc L160

if we use the files of name lengh greater than 100, (default string + 100 input file + 100 output file > 200 ), during executing
the program is crashed

The Poc:

CVE-2021-27211 (CVE about relying on a certain 32-bit seed value, which makes it easier for attackers to detect hidden data)

I do not know if you are aware of CVE issue in your project, so I am attaching a link: https://nvd.nist.gov/vuln/detail/CVE-2021-27211.

If this could be fixed, it would be great, but I am not able to fix it myself due to low knowledge of C/C++.

Steghide -e algorithm documentation

Can you add the supported encryption algorithm alias, I mean I try to use the exact same name from libmcrypt manual for the -e flag but can't be work