stefanfabian / ros_babel_fish_benchmarks Goto Github PK

Hi,

I don't want to become pedantic, but...

Looking at this line of code 151,

     parser.applyNameTransform( datatype, flat_container, &renamed_value);

I realized that it could be misleading to include it in the benchmark, because it does something that the line 174 is not meant to do.

   ros_babel_fish::Message::Ptr translated = fish.translateMessage( bf_msg );

The purpose of the applyNameTransform is to build human readable keys, i.e. concatenated strings from the name of the fields in flat_container.

Note that both:

• RosIntrospection::FlatMessage flat_container
• ros_babel_fish::Message::Ptr translated

contains already all the information, even if stored in different ways (hierarchical for RBF, branches of the hierarchy tree for RTI).

If you want to keep it, at least change the following line to avoid extra work that RBF is not doing anyway.

  parser.applyNameTransform( datatype, flat_container, &renamed_value, true );