steadyfish / ogdindiar Goto Github PK

I can't run vignette/basic-usage-vignette.Rmd

I tried

library(knitr)
knit("basic-usage-vignette.Rmd")

and

library(rmarkdown)
render("basic-usage-vignette.Rmd")

Check that the vignette can be converted into md file (or another format). I would recommend adding the resulting md file (and the associated figures directory that will be generated) into the vignette folder. In that case it can be easily viewed like in here: https://github.com/rOpenGov/eurostat/blob/master/vignettes/eurostat_tutorial.md

Perhaps provide an option to store the API key as an environment variable.

http://stackoverflow.com/questions/12533113/setting-environment-variables-programmatically

Due to some SSL certificate error, had to include a cainfo parameter in getURL call. Not sure if this is the right way.

error:
RCurl SSL certificate problem: unable to get local issuer certificate

corrected call:
doc = RCurl::getURL(url = JSON_URL, cainfo = system.file("CurlSSL", "cacert.pem", package = "RCurl"))

Hi,

I tried to download these data from the website https://data.gov.in/catalog/indian-railways-train-time-table-0

and got this error
fetch_data("b46200c1-ca9a-4bbe-92f8-b5039cc25a12")

Error in function (type, msg, asError = TRUE) :
Unknown SSL protocol error in connection to data.gov.in:443

Do you get the same error for this dataset?

When you try to fetch data via fetch_data(res_id = ""),
data does not get downloaded and metadata gets downloaded at its place.I seems JSON structure is changed in thereceived data and we are not looking at the right element of the list for the data.
Thanks
Santosh

Many of the datasets, although not available as API's, are available in JSON/JSONP format. See if this in anyway can be exploited for programmatic data extract.

Current version of functions uses JSON API. In future also make available XML API option.

Also, check of any advantage one method offers over the other.

Hi,

I've just installed your R package and I'm very happy you've written it, thanks a lot!

I see that there is not much activity on the repo, so I wonder whether you're still developping this package? I hope you are because it can be very useful.

My other question is whether you think it would be possible to add a search function, i.e. for finding datasets IDs based on e.g. keywords?

Anyway, thanks again for making this package available! :-)

Currently, all the columns in the downloaded data are of type"char". Columns should be converted to either int, time, char based on metadata.

• checking Rd \usage sections ... WARNING
  Undocumented arguments in documentation object 'to_data_frame'
  ‘lst_elmnt’
  Documented arguments not in \usage in documentation object 'to_data_frame':
  ‘x’

-> need to update the roxygen documentation here.

According to CRAN policies:

The Title field should be in title case, current version then in title case:
‘API access to datasets on Open Government Data - India Portal’
‘API Access to Datasets on Open Government Data - India Portal’

Basically requires some text/string manipulation.

Filter example from data.gov.in

https://data.gov.in/api/datastore/resource.json?resource_id=b472d012-ef3b-43bf-a45d-5ca2b2869680&api-key=YOURKEY&filters[field1]=field1_value&fields=field1,field2,field3&sort[field1]=asc

Hi,
Could you just make the package available for R version 3.1.1. Since, I don't have the 3.2.0 version of R for my system yet (Mac OSX 10.7.5).

Thanks,

Subinoy

This is not an issue per se, but the files in inst/extras aren't required isn't it? Good to remove them.

• checking R code for possible problems ... NOTE
  ogdindia_api_key: no visible binding for global variable ‘pat’

One way to handle this is to add as the first line within the function:
pat <- NULL

This has worked well for me, perhaps there are better ways.

The ./inst/extras/build.cran.sh (from my recent pull request) says:

• checking DESCRIPTION meta-information ... NOTE
  License components which are templates and need '+ file LICENSE':
  MIT

To declare license (MIT is fine) you need to follow the convention that you can check for instance here:
https://github.com/ropengov/eurostat/blob/master/DESCRIPTION

So modify your DESCRIPTION file License field in the same as there, and also add the file named LICENSE to the same root directory where you have the DESCRIPTION file
https://github.com/ropengov/eurostat/blob/master/LICENSE