stavrospanakakis / is_ready Goto Github PK

Description

There might be cases that the user might not need to output any status messages.

The --quiet or -q flag can be used for this purpose.

Before

$ is_ready \
    --timeout 10 \
    --addr github.com:80 \
    --addr google.com:80 \
    -- echo "The addresses are available"

Connected to google.com:80 successfully
Connected to github.com:80 successfully
The addresses are available

After

$ is_ready \
    --quiet \
    --timeout 10 \
    --addr github.com:80 \
    --addr google.com:80 \
    -- echo "The addresses are available"

The addresses are available

Description

The following feature exists:

• Wait for addresses that are not valid (e.g. invalidaddress:2412)
• Return error message since the address is not ready after the timeout

This could be a good testing case that will check:

• It will wait for the invalid addresses and since it is not ready, it will show a failure message after the timeout ends

Description

The following feature exists:

• Use the --timeout flag to specify the seconds of the timeout

This could be a good testing case that will check:

• Specify an invalid address (e.g. invalidaddr:1234)
• Use the --timeout flag
• Check that is_ready waits for this amount of seconds before failing

Description

The following feature exists:

• Use the --quiet flag in case the user might not need to output any status messages

This could be a good testing case that will check:

• Use the --quiet flag
• Check that no output message is printed

To Reproduce
Steps to reproduce the behavior:

1. Run is_ready with a command that does not exist. For example:

is_ready --addr google.com:80 -- command_that_does_not_exist

2. It will panic:

Connected to google.com:80 successfully
thread 'main' panicked at is_ready/src/lib.rs:73:10:
Failed to run the command.: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Expected behavior
In this case, it should handle the error and return something more user friendly such as Command not found

Description

The following feature exists:

• Wait for 2 addresses that are valid (e.g. google.com:80, github.com:80)
• Run a command after they are ready

This could be a good testing case that will check:

• It will wait for 2 valid addresses that are ready
• The command that was defined ran successfully