Code Monkey home page Code Monkey logo

snips's People

Contributors

abdelstark avatar arielelp avatar boyuanx avatar delaaxe avatar ericnordelo avatar evyataro avatar gaetbout avatar glrn avatar jag-lotus avatar lambda-0x avatar maorveitsman avatar martriay avatar nnsw3 avatar orland0x avatar stoobie avatar tserg avatar tudorpintea999 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

snips's Issues

Prefer felt over uint256

Usage of uint256 for backward compatibility with EVM specifications introduces a lot of baggage; increasing storage costs, adding code complexity, and complicating contract interfaces. Given the number of applications that actually need uint256, it seems the costs outweigh the benefits.

Going forward, most assets in the starknet ecosystem will be starknet native assets, so maintaining backward compatibility with evm types provides only downside. I suggest the base implementation of ERC ports should prefer felt over uint256. Implementations could chose to maintain a compat variant which uses uint256.

See previous discussion here: OpenZeppelin/cairo-contracts#336

dev: add codespell linter workflow for CI

Codespell linter tool is very important for code and system quality, especially for enhancing docs readability.

So I want to add codespell linter workflow for CI.

Thank you very much.

feat: RSS feeds of the SNIP process

Feature Request

Write an rss feed tracker which updates subscribers about status changes of any SNIPs.
If you're feeling spontaneous, write a twitter bot that does the same.

ERC721 Standard Should use felt* instead of felt for tokenURI

Raising this discussion again as it's been discussed a few times but OpenZeppelin has decided to use felt instead of felt* for tokenURI. Their reasoning is discussed here. This is problematic for the community as it means that no reasonable NFT with metadata can be used as the tokenURI limit of 31 characters is too small for even an IPFS URI

Other entities such as Aspect have also diverged from the OpenZeppelin Standard. Having discussed with the team at LootRealms, they will also face this issue.

Immutable X, out of necessity, has also diverged and created an ERC721 standard inspired by OpenZeppelin with a key divergence being the tokenURI. Immutable X provides this as a preset to the community: https://github.com/immutable/imx-starknet/blob/main/immutablex/starknet/token/erc721/presets/ERC721_Full.cairo

Having discussed with Martín Triay from OZ, his view was that they would rather wait for StarkNet to release Strings. This unknown date of string support causes issues for organizations wishing to move close to productionizing their apps.

Immutable X will be supporting the long-form Token URI represented using felt* as used in their preset. Immutable X also presents encoding and decoding implementation for the tokenURI:

We believe the community should align on enabling organizations to be successful as these organizations will drive users to StarkNet. For NFTs on StarkNet, this means enabling metadata through an extended tokenURI.

If this gets more than 10 Rocket reacts, I'll make a SIMP for it.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.