stargate01 / amongus-mumble Goto Github PK

Description
Leaving a game often also does not trigger a "Game joined or ended"

Steps To Reproduce
Leave a game? How exactly?

Expected behavior
The console prints "Game joined or ended"

Game version
Please specify in comments

On 2020.11.4s, MeetingEnded is fired before the game even starts. We should look into this, and verify the hooks and (changed?) program flow of the game.

Is your feature request related to a problem? Please describe.
Player should be able to make loadspeaker announcements when in some special room

Describe the solution you'd like
Use mumble shout via 1.4 RPC or find another way

In our group of 9 one player with identical settings to all the rest of us was not muted when comms were called, but regular proximity and directional worked

We have all the paths set to the right thing and connected to mumble.
When we launch our game it says Among Us linked and then a few seconds later among us lost link.

It would be nice if there was a config option we could enable/disable to prevent everyone being muted when Communications is sabotaged. Since not everyone might want this option.

This affects some of the other custom game modes, like when people do things like Hide and Seek where Comms is supposed to be sabotaged.

I think having it enabled is a good default though.

Basically we could use Roslyn to analyze the c# prototypes of Il2CppInspector and guess classes using known members/nested classes/methods.

It looks feasible.

Is your feature request related to a problem? Please describe.
Impostors should be able to covertly speak to each other

Describe the solution you'd like
Impostors can press a button to radio call their partners.

Describe alternatives you've considered
Discuss: has this to be nerfed?

Additional context
Implementation can be done like the ghost purgatory.

Add option to choose between

• Isolated ghost channel using different mumble context, ghosts can talk to each other regardless of position, ghosts can only listen in meetings
• One channel for all, ghosts always muted, ghosts can listen to players they are nearby and to meetings

Description
Lobby host + some players getting banned from lobby

Steps To Reproduce
Steps to reproduce the behavior:
After playing a game with the mod, the lobby host and some of the players get banned, everytime.

Game version
1.0.0.9 | 202011171

Inject IMGUI and use it as settings editor or console

Create a wiki and move the installtion instruction to one page, and the command line and config file difference to another. Then link to it in the README.

Modify all non-generated code to conform to the coding style guide. Refer to https://github.com/StarGate01/AmongUs-Mumble/wiki/Development#coding-style-guide .

Description
Game fails to launch on Windows 7 due to missing Xinput1_4.dll

Start the RPC calls in a new thread to avoid lag

This would require hooking the games network layer.

At first, whenever I dragged in the winhttp file it would not let me open among us at all. I then made a new certificate wizard and imported the file. Once that was done I opened up among us and it finally opened, but the line of codes tab that is supposed to open up along with among us doesn't open. I also noticed my friends have proximityconfig and proximitylog files in their local among us files, but I don't seem to have those. Mumble does not work when I have everything set up correctly, even when it's supposed to automatically undeafen me, it does not. I don't know anyone else who has had this problem. Any fix?

We can use
\HKEY_LOCAL_MACHINE\SOFTWARE\Classes\mumble\DefaultIcon

kinda hacky though, I wouldn't rely on it existing/having a proper path set

Evaluate usage of custom network packets, to be independent of chat problems.

Feature Explanation
Similar to the request for disabling comms disabling voice chat, reduce the range of positional audio when lights go off.

Implementation Ideas

• Scale all positions to a larger space twice the size, for example, of the scale of the normal positional space (Multiply the position of players by two in this example).
• Mumble RPC to set distance thresholds.

Additional context
While not realistic (turning off lights don't turn down sound) audio is often associated with visibility range to users.

Description
Hello,
After Among Us and Mumble are linked, a few seconds later they lose connection between the two.

Steps To Reproduce

1. Launch Mumble.
2. Launch Among Us.
3. Wait for the connection and disconnection of the link in the Mumble log.

Expected behavior
The link does not disconnect.

Game version
v2020.11.17s
dll: 1.0.0.8

Additional context
ProximityLog: https://pastebin.com/CX4xgCDU
Mumble Log: https://i.imgur.com/Ytuk1Fl.png

In order to not break other software that loads this DLL by mistake.

Windows DLL loading is a mess.

Is your feature request related to a problem? Please describe.
Users can't link Mumble when the game is already running, as the initialization is only performed once at game start.

Describe the solution you'd like
If Mumble is not linked, periodically check if it can be linked.

Additional context
We can use a mechanism similar to the heartbeat loop.

Is your feature request related to a problem? Please describe.
When your in haunt mode, you can't talk to other ghosts.

Describe the solution you'd like
Allow you to talk to ghosts when your in haunt mode.

Describe alternatives you've considered

Additional context
Add any other context or screenshots about the feature request here.

Doesn't work with version 2020.12.3s

Until the new RPC API lands, we could look how we can change user settings using the windows registry.

Description
Since the update to v2020.11.17s it does not work

Steps To Reproduce
Steps to reproduce the behavior:

1. Updated AmongUs to v2020.11.17s
2. Download the latest release of the plugin V1.0.0.8
3. Started a game, but the gui is not loaded and the position is not being transferred to Mumble

Expected behavior
That the plugin is being loaded into AmongUs and work

Game version
v2020.11.17s

Additional context

When joining a lobby, it may cause problems as you won't be able to talk to your friends who aren't also in that lobby.
Leaving a game often also does not trigger a "Game joined or ended" and this can also cause similar issues.

As per the wiki, the context should not be updated every frame -- will have to fix the issue with detecting game state changes.

Overridable by CLI arguments

I was a little confused to make the mod work, I managed to do everything right except the part I couldn't
put the winhttp.dll file in the game folder, because when it opened it gave an error, please make a video explaining how to download the mod and make it work, if you do I will thank you very much.

Would require patching mumble itself to enable more RPC commands

• Windows GUI using C# & WPF/WinForms
• Install mod
• Uninstall mod
• Update mod directly from GitHub / display versions
• Update self directly from GitHub (?)
• Find game and mumble automatically
• Preconfigure mumble path

It would be nice to be able to have regular voice chat in a lobby, where proximity chat does not achieve much. It's great for testing in a lobby, but once everyone acknowledges it works, having it in the lobby does not do much. Thank you!

Use Application_get_version to get the current version of the game and compare the the dll supported one.

Maybe also do a api call to github to check the latest supported version and prompt the user to update.

Find a proximity capable mumble android client.

• https://github.com/mumble-voip/libmumble
• https://github.com/citizenfx/fivem/tree/master/code/components/voip-mumble
• https://github.com/slomkowski/mumlib

Requires a bit of additional deobfuscation and testing.

Add keepalive signal to show the user position capture is working

Add a config option to enable or disable the directionality of the voice chat.

Proximity will be unaffected.