standardml / cmlib Goto Github PK

It is unclear to me whether Stream.fromTextInstream (and the Bin variant) should close the stream when the end is reached. In the current implementation it doesn't, which is slightly troublesome when the function is used to read files: one has to keep the stream around and manually close it when the file ends; this is quite cumbersome since the stream is lazy and it's nontrivial to determine the point at which the stream should be closed. Is this done on purpose (and if so, what is the use-case the authors have in mind), or is this an oversight?

This issue consists of two separate, small bugs.

Firstly, the way Coord.nextLine is implemented, we get
Coord.eq (c, Coord.nextLine c) = true
which probably shouldn't be the case. This is because Coord.nextLine does not increment the abs counter of Coord.coord, and equality check only compares the absolute counts. This also makes the actual absolute position diverge more and more, which is annoying (if easy to work around) if trying to, say, interface with emacs.

The second issue is a really small thing about CoordinatedStream. Right now, the character in the returned stream is coordinated with the "new" value, coord' — in particular, end-of-line characters are associated with the next line, and the column positions are off by one, since the first column is taken up by the eols.

I will probably submit a patch later today.