stamler / tybalt Goto Github PK

Create an auto-complete module so that creating / editing a TimeEntry provides typeahead when entering project from the database.

Planned Implementation:

1. Create an onWrite() firestore trigger on Projects collection
   functions.firestore.document('Projects/{projectId}').onWrite(updateSearchString);
2. Write the updateSearchString() function which takes string value from specific properties and tokenizes them then adds the tokens to a searchStrings array property.
3. Create the Typeahead field which tokenizes the input the same way that the backend does then provides each token to a where() query:
   .where('searchStrings', 'array-contains', token1). NB that firestore does not support chained array-contains queries so a separate query needs to be performed for each search term(!) and then ANDed together with the others to find the intersect. This can be done on the client side or in a cloud function. a stackoverflow answer explanation

Alternative Simple implementation (search project number only)

After updating ProfileList for mobile, it's no longer possible to ModClaims on the app.

README is very outdated. Update it to document installation and deployment procedures as well as technical information about the frontend, backend, and code layout.

User should be able to click the bundle button and all TimeEntries from a given week will be validated and bundled into a TimeSheet document which contains TimeEntries and extra metadata. This will be ready for submission.

With many mutations it can become difficult to identify the important ones. Sort the mutations by statusUpdated timestamp in descending order so that the most recently changed mutations appear at the top of the list.

Further, UserMutations with a status of complete should appear at the bottom while all others statuses should appear above. Thus it's a double sorting, grouping first by status of either complete or not complete then sorting by statusUpdated within each group.

Switching to mobile-friendly individual List components creates a lot of duplicate code. Most of this can be implemented in a new MobileList.vue component with a slot template.

Make the nav bar fixed and scroll content under it. Make the search input begin under the nav bar and pull down to search.

There is currently no testing for firestore rules. These need to be validated prior to deployment

Currently Profiles exports data from firebase Auth and is not the source of Authority. Examine the possibility of using Profiles as the source of role authority then writing custom claims from profiles as tokens are minted.

One bug 1786 is fixed, refactor the sinon stubs to use the firebase/testing SDK

Ensure that the UI reflects the rights that a user actually has in firestore rules and functions.

Often rejected promises write to the console. This needs to be updated to the UI

Editing for Projects, Divisions, and TimeTypes doesn't work properly on mobile. Model them after the Editor for TimeEntries.

The getMileageRate() function in ExpensesEdit.vue returns 0 if the mileageClaimed property is undefined on the Profile document. The getMileageRate() function should instead assume that this is the first tier and return the corresponding first-tier value.