pyalign script bugs about popcorn-compiler HOT 2 CLOSED

Indeed the tool is not supposed to be run with python 3. I guess the problem is when the default invocation of python is calling version 3. I can add the shebang, but remember that pyalign is called by the Makefile template in its 'binary form' through this script. Thus, I modified that script to force the use of python 2 (9773569).

I'm assuming that people do not use ./__main__.py (this file is not even executable) so no shebang to interpret. You can invoke python directly and in that case you should be aware of the version you use, anyway the shebang will not be used.

I cleaned up the tab/spaces mix. I don't see any good reason for now to convert the script to python 3.

from popcorn-compiler.

@olivierpierre I'm not advocating to convert the script to Python 3 (at least not at this moment) -- and it was a configuration error on my part that even brought the whitespace bugs to light (I had set the default Python version to 3.6 using pyenv for my own development purposes).

Long-term, it might make sense to convert to Python 3 if we ever find ourselves using a distro that doesn't include Python 2 (several seem to be moving in that direction, since it's supposedly deprecated), but that's waaaaay far down on the list of priorities :)

Closing issue as resolved by @olivierpierre 's commit.

from popcorn-compiler.