ssnui / stock-portfolio-manager Goto Github PK

Currencies are never converted..

The overview could perform a currency conversion with today's rate and display 
the current total market value using a default currency.

Rework the whole project to use Injection, so that Unit Test can be added where 
needed...

As a first step:

review each "Strategy" for Symbol analysis:

http://code.google.com/p/stock-portfolio-manager/source/browse/?repo=bp#hg%2Fsrc
%2Fcom%2Fproserus%2Fstocks%2Fbp%2Fstrategies%2Fsymbols

Currently, yahoo finance is used to fetch prices and data.
Define an additional source of data, in order to correctly put in place the 
mechanism to let the user use its preferred source of data.

Perhaps the default color should be in a property file ? and injected ?

Currently every screen access the ColorSettings view (which is a singleton)..

CommissionCY.java
CostCY.java
CurrencyStrategy.java
DividendStrategyCY.java
EndOfPeriodCY.java
QuantityCY.java
QuantitySoldCY.java
StartOfPeriodCY.java
SumSellingCY.java

A menu option should be added to redirect the user to the "mailing list" web 
page.

Add an option to sell "all remaining shares" available to the user when 
entering a sell transaction.

Allow the user to specify the sector for each symbol

Add additional set of Symbol/Currency analysis, allowing the user to select its 
preference.

All Date comparison should be encapsulted in DateHelper/DateUtils..

Let the user keep track of his current Cash Flow

add CAPITAL GAINS/LOSSES result

Use Commons librairies where possible: 
- StringUtils
- CollectionsUtils
- ListsUtils
- DateUtils
- Validate

MarketValueCY.java
CapitalGainCY.java
AbstractStrategyCumulative.java

Purpose of code changes on this branch:


When reviewing my code changes, please focus on:


After the review, I'll merge this branch into:
/trunk

The user may require to go through a Proxy to fetch the data from the web.
There should be an option to configure it..

Make the SWING code thread safe

http://www.jguru.com/faq/view.jsp?EID=131370
javax.swing.SwingUtilities.invokeLater(Runnable ...);
http://download.oracle.com/javase/tutorial/uiswing/concurrency/dispatch.html
http://www.iam.ubc.ca/guides/javatut99/uiswing/overview/threads.html

I entered a transaction with
Price: 0.00001
Quanity: 10

Because the real price stock is a lot higher (say 20$), the calculated profit 
exceeds the capacity (assumption) + the database produce an error ehen saving 
the transaction.

A menu option should be added to redirect the user to the "report issues" web 
page.

Allow the user to filter by transaction type.

Pie chart tab on selected tags

Currently the feature to remove a transaction and/or symbol is kind of hidden: 
the option is available by right clicking on a row.

The option should be presented to the user through the toolbar and/or menu.

Bad design - legacy code.. already...

review every places where SharedFilterBp and FilterBp are used.. do we really 
need 2 objects ? SharedFilterBp inherits from FilterBp..

Should we add a feature to allow synching with Google Finance ?

Somehow, the wrong DateTime object was used (from JFree). All date used should 
be from standard Java API (Date, Calendar...).

JodaTime could be nice, but it is harder to combine it with Hibernate. Or then 
use JodaTime everywhere...

What steps will reproduce the problem?
1. extract the software
2. double-click on StockPortfolioLauncher.jar
3. Get an error dialog:

"The file '/home/olivier/soft/StockPortfolio/StockPortfolioLauncher.jar' is not 
marked as executable.  If this was downloaded or copied from an untrusted 
source, it may be dangerous to run.  For more details, read about the 
executable bit."

What is the expected output? What do you see instead?

It would run the program.

What version of the product are you using? On what operating system?

0.15beta, ubuntu linux

Please provide any additional information below.

Marking the .jar as executable in the zip file would most likely fix it. 
Otherwise providing a simple launch.sh could do it and might even be simpler 
for the end user (and cross-platform with the Mac). That said, the Launcher 
name makes it pretty clear it's the jar you need to run.

Let me know if you want to go the launch.sh way, I can quickly code one for you.

Allow the user to Import and Export transaction using the excel format

Create test cases for basic: Symbol analysis
CommissionSYM.java
CostBasisSYM.java
DividendSYM.java
EndOfPeriodSYM.java
QuantityBoughtSYM.java
QuantityRemainingSYM.java
QuantitySoldSYM.java
StartOfPeriodSYM.java
SumSellingPricesSYM.java

Test cases for more advanced symbol analysis:

AverageCostPerShareSYM.java
MarketValueSYM.java
CapitalGainSYM.java
AnnualizedReturn.java
DividendYield.java
MarketGrowth.java
NumberOfYears.java
OverallReturn.java

What steps will reproduce the problem?
1. Click on "Add Transaction"
2. Click on Symbol drop-down

What is the expected output? What do you see instead?
The symbol drop-down should be populated with the entered symbols.

What version of the product are you using? On what operating system?
Version 0.10 Beta Build 2011-07-12_20h33m10s

Please provide any additional information below.

All String should be moved to a resource file supporting multiple languages.

Need to remove the Singleton from the SWING model...

Should we use Injection ? Does that work well with Visual components ?

How should SWING be better designed.

Design icons for toolbar

Allow the user to specify the sector for each symbol

A master build.xml should be added to automatically package the runtime jar and 
the source jar.

The user should be allowed to defined its own preferred format for tickers. 
This feature should include the mapping between the format used by the 
application and the user preferred format.

This could be done via regular expressions..

When entering a dividend transaction, provide the option to reinvest it (and 
allow to specify the price and quantity for the reinvestment.

A menu option should be added to redirect the user to the "comments" web page.

Display the remaining number of shares when entering a "sell" transaction.

Let the user see during runtime, how the analysis were calculated..

Add an automatic creation/update script and manahe the dbschema there instead 
of hibernate.
Change the hibernate property 'update' to the keyword that ensure that 
hibernate does not create/alter the db.

Add documentation on how to setup Eclipse to contribute to the project.

Sometime the user lost track of its transactions and just want to rebalance its 
portfolio to its current value.

Another type of transaction could let the user enter its current number of 
share and/or average price and/or total price..

The application would then create the necessary buy/sell transaction for the 
user.

great start!
my bias:  I think most investors are looking for a SIMPLE program to track 
investments especially for CAPITAL GAINS/LOSSES purposes (tax).

Therefore some suggestions to improve:  (while keeping it simple)

1.  TRANSACTIONS TAB - enable multiple stock "portfolios" (folders) to place 
transactions into

2.  TRANSACTIONS TAB - display CAPITAL GAIN/LOSS AT DISPOSITION (column) when 
SOLD

3.  TRANSACTIONS TAB - display ADJUSTED COST BASE (per #shares) AT DISPOSITION 
(column) when SOLD

4.  TRANSACTIONS TAB - display COMMISSION/EXPENSES INCURRED ON SHARES (column) 
when SOLD

5.  OVERVIEW TAB - choose display "total portfolio" versus "each portfolio"

6.  PERFORMANCE TAB - the "capital gain" is tricky because it's actually a loss 
if sold at less than the purchase price.  You need to rethink this...

all for now
G

As a first step:

review each "Strategy" for Currency analysis:

http://code.google.com/p/stock-portfolio-manager/source/browse/?repo=bp#hg%2Fsrc
%2Fcom%2Fproserus%2Fstocks%2Fbp%2Fstrategies%2Fcurrencies

Document how JPA modification and improvement can be added to the code with 
minimal impact to the user.

What steps will reproduce the problem?
1. Add a new symbol and click "Add"

What is the expected output? What do you see instead?
The focus should be set to the Symbol textbox rather than keeping focus on the 
Add button

What version of the product are you using? On what operating system?
Version 0.10 Beta Build 2011-07-12_20h33m10s

Please provide any additional information below.

What steps will reproduce the problem?
1. try to launch the software by double clicking on it
2. fail

What is the expected output? What do you see instead?

"The Java JAR file “StockPortfolioLauncher.jar” could not be launched."

What version of the product are you using? On what operating system?

0.15beta, Mac OS X 10.5.8

Please provide any additional information below.

The root of the problem is that on 10.5 the Java on the PATH is java 5. java 6 
is installed on OSX since 10.5.2 but not linked to the /usr/bin/java. I think 
that 10.6 has java 6 by default.

A launcher script could deal with that for 10.5. If you want to support 10.4 
then I'm afraid you'll have to rely only on Java 5 as Java 6 is mac intel only.

Again I can help with the launcher, just let me know.

Importing a CSV file fails. This was raised ny Steve through the mailing list, 
more details are required