Because of this it is very difficult to create patch files, because modern ides like phpstorm remove all unneccesary whitespaces on saving a file, which should be standard nowadays.

If your ide respects .editorconfig files, this setting should do the trick:
trim_trailing_whitespace = true

When I create a special query for the recipient list, the overview only indicates that 100 entries are in the list.

This is because there's a limit 100 added at the end of the special query.

Will the newsletter be sent to all found entries, or will it stop after 100?

In the backend of TYPO3 v12, when i edit a tt_content, i have the message :

An error occurred trying to process items for field "Category:" (There is no entry in the $TCA array for the table "sys_language". This means that the function enableFields() is called with an invalid table name as argument.).

It is related to /Configuration/TCA/Overrides/tt_content.php and "itemsProcFunc".
We have some calls to sys_language in "DirectMailTeam\DirectMail\SelectCategories"

Thanks

vendor/typo3/cms-cli/typo3 directmail:mailingqueue

An exception occurred while executing 'SELECT COUNT(*) FROM cache_md5params WHERE md5hash = ?' with params [""]:

Table 'cache_md5params' doesn't exist.

• https://docs.typo3.org/c/typo3/cms-core/10.4/en-us/Changelog/9.0/Breaking-82572-RDCTFunctionalityRemoved.html

disable => 'Redirect links longer than 76 characters' ('use_rdct')

• https://github.com/FriendsOfTYPO3/rdct/blob/master/ext_tables.sql

• unset

TYPO3 12 PHP 8.2

On clicking page in Step1 i became this error:

Core: Exception handler (WEB): Uncaught TYPO3 Exception: TYPO3\CMS\Core\Http\RequestFactory::request(): Argument #3 ($options) must be of type array, null given, called in /var/www/vhosts/beta.de/typo3conf/ext/direct_mail/Classes/Utility/FetchUtility.php on line 44 | TypeError thrown in file /var/www/vhosts/beta.de/typo3_src-12.4.7/typo3/sysext/core/Classes/Http/RequestFactory.php in line 54. Requested URL: https://www.beta.de/typo3/module/directmail/directmail?token=--AnonymizedToken--&id=87&createMailFrom_UID=88&fetchAtOnce=1&cmd=info

The $GLOBALS['LANG'] was replaced by a new getLanguageService method with this commit:
063e596

Unfortunatelly this method is not marked as statically but used this way all over in the class.

[EDIT] It's in the 11-x branch, offcourse

Add this code to emt_emconf.php for non composer users.
Otherwise this 503 error appears.

 
'autoload' => [
        'psr-4' => [
            'DirectMailTeam\\DirectMail\\' => 'Classes/',
            'Fetch\\' => 'Resources/Private/Php/Fetch/src/Fetch/'
        ]
    ],

hello,

why is it set only for development? it seems not working for live site??

if ($applicationContext->isDevelopment()) {
            $context = ['verify' => Typo3ConfVarsUtility::getDMConfigSSLVerify()];
       }

martin

Since there is no direct call of the MainRepository class methods it should be abstract.

Hi,

First thanks for your work maintining direct_mail :-)
Then, i actuallty test the tree "12.x" and find this exception :

PHP Runtime Deprecation Notice: Function strftime() is deprecated in "/vendor/directmailteam/direct-mail/Classes/Module/DmailController.php line 1511".

Im on last TYPO3 12.

• https://docs.typo3.org/m/typo3/reference-coreapi/9.5/en-us/ExtensionArchitecture/DeclarationFile/Index.html#deprecated-configuration

lockType

etc

• https://docs.typo3.org/m/typo3/reference-coreapi/11.5/en-us/ExtensionArchitecture/DeclarationFile/Index.html

The method "update_SpecialQuery" is called in file "Classes/Module/DmailController.php" but it doesnt exist.

TempRepository::makeCategories and TempRepository::getRecordOverlay marked as static, but makeCategories using $this->getRecordOverlay inside.

Additional the class method is called as an object method.

e.g. inside DmailController line 1894:

GeneralUtility::makeInstance(TempRepository::class)->makeCategories('tt_content', $row, $this->sys_language_uid)

Both methods should not marked as static.

We installed and tested the 11.x-dev branch in a TYPO3 11.5.8 environment (php 7.4).

Works pretty well for creating and sending newsletters.

We used jumpurl for an internal link and a test recipient clicked on it in the received newsletter.

When afterwards trying to open the statistics for that newsletter we get following exception:

(1/1) Error

Call to undefined method DirectMailTeam\DirectMail\Module\StatisticsController::getUrlStr()
in /xx/xx/public/typo3conf/ext/direct_mail/Classes/Module/StatisticsController.php line 638

            $id     = abs(intval($id));
            $url    = $htmlLinks[$id]['url'] ? $htmlLinks[$id]['url'] : $urlArr[$origId];
            // a link to this host?
            $uParts = @parse_url($url);
            $urlstr = $this->getUrlStr($uParts);
            
            $label = $this->getLinkLabel($url, $urlstr, false, $htmlLinks[$id]['label']);

In fact there is no method "getUrlStr()" neither in StatisticsController.php nor in MainController.php.

When there was no click on a jumpurl everything works fine.

Class SelectCategories contain a call to the static method getRecordOverlay of DirectMailUtility which doesn't exists.

Maybe it would be a good idea to move the makeCategories and getRecordOverlay of TempRepository to DirectMailUtility and make them static?

If you agree, the $this->getRecordOverlay call inside makeCategories should be replaced with self::getRecordOverlay ...

Other calls should be replace by DirectMailUtility::makeCategories and DirectMailUtility::getRecordOverlay()

Eg. change this in DmailController:
$this->categories = GeneralUtility::makeInstance(TempRepository::class)->makeCategories('tt_content', $row, $this->sys_language_uid);

with this:
$this->categories = DirectMailUtility::makeCategories('tt_content', $row, $this->sys_language_uid);
(to not forget the use statement ...)

Other places are inside:
Module/RecipientListController.php (line 795)
Module/StatisticsController.php (line 316)

(1/1) #1476107295 TYPO3\CMS\Core\Error\Exception
PHP Warning: Undefined variable $_EXTKEY in /direct_mail/ext_localconf.php line 77

• https://docs.typo3.org/typo3cms/exceptions/master/en-us/Exceptions/1365429656.html

$TYPO3_CONF_VARS['EXTCONF']['direct_mail']['UseImplicitPortToFetch'] = $extConf['UseImplicitPortToFetch'];

• https://packagist.org/packages/tedivm/fetch

v0.7.1

/Resources/Private/Php/Fetch

add to require in composer.json

The following improvements should be made:

1. Use TYPO3 panels for expanding sections
2. Use full width for tables and information boxes
3. Fix html markup in place of delete icon in mailer engine module (see below)

We tried to use the bounce management with the v11 branch. We had test newsletters send to a not existing email. It could read the bounce mails in the mail account but does not update the statistics for returned mails without any log or error message.

• https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/Events/Index.html

// Register hook for simulating a user group
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['determineId-PreProcessing']['direct_mail'] = 'DirectMailTeam\\DirectMail\\Hooks\TypoScriptFrontendController->simulateUsergroup';

• https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/Events/Events/Frontend/BeforePageIsResolvedEvent.html

BeforePageIsResolvedEvent

New in version 12.0: This PSR-14 event replaces the $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['determineId-PreProcessing'] hook.

is this fork already working proper in latest TYPO3?
martin

When trying to send a testmail to a list of recipients in step 4 of the process, you get the error 'Call to undefined method DirectMailTeam\DirectMail\Module\DmailController::sendTestMailToTable()'

Copying this function from Classes/Module/Dmail.php fixes it.

Hey, after clicking the step 3 don´t work:
(1/1) TypeError
strip_tags() expects parameter 1 to be string, null given

typo3conf/ext/direct_mail/Classes/Module/DmailController.php line 1766
$row['header'] . '<br />' . GeneralUtility::fixed_lgd_cs(strip_tags($row['bodytext']), 200) . '<br /></td>';

TYPO3 11.5
PHP 7.4

Using the option 'Click here to import CSV' results in the error 'Call to a member function retrieveFileOrFolderObject() on null' in typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php line 626.

This happens when using either the paste csv data option or the file upload option, after clicking 'Next' on the 'Import settings' page.

• https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/11.3/Deprecation-94309-DeprecatedGeneralUtilitystdAuthCode.html

When i schedule a newsletter, in the step 5, in the "Distribution time" section , the calendar is not working.

Deprecation: #92080 - QueryGenerator and QueryView

• https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/11.0/Deprecation-92080-DeprecatedQueryGeneratorAndQueryView.html

In the repositories, there is a lot of "array|bool" return types, but union types are only allowed since PHP 8.0.
Only this repositories are affected by this.

The rest works fine for me 👍

sys_language table doesn't exists

• https://api.typo3.org/12.4/class_t_y_p_o3_1_1_c_m_s_1_1_core_1_1_domain_1_1_repository_1_1_page_repository.html#a2211f1d93989ee971adc8e810d1b1300

Fatal error: Type of DirectMailTeam\DirectMail\Plugin\DirectMail::$cObj must be ?TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer (as in class TYPO3\CMS\Frontend\Plugin\AbstractPlugin) in /Classes/Plugin/DirectMail.php on line 0

• https://api.typo3.org/main/_abstract_plugin_8php_source.html

The TCA field 'sys_language_uid' of table 'sys_dmail' is defined as the 'languageField' and should therefore use the TCA type 'language' instead of TCA type 'select' with 'foreign_table=sys_language' or 'special=languages'.

The TCA field 'sys_language_uid' of table 'sys_dmail_category' is defined as the 'languageField' and should therefore use the TCA type 'language' instead of TCA type 'select' with 'foreign_table=sys_language' or 'special=languages'.

in /typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php line 1684

• https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/11.2/Feature-57082-NewTCATypeLanguage.html

• https://github.com/FriendsOfTYPO3/tt_address

(1/1) Error
Class "TYPO3\CMS\Backend\Template\DocumentTemplate" not found

• https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/10.3/Deprecation-90421-DocumentTemplate.html?highlight=documenttemplate

• https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ApiOverview/BackendModules/TemplateClass/BackendTemplateViewWithoutExtbase.html

• https://api.typo3.org/master/class_t_y_p_o3_1_1_c_m_s_1_1_backend_1_1_template_1_1_module_template.html

Hi,

On the non-composer version "dashboard" was not a requirement.
Since the composer version, it is installed by default.

Could it be a "suggest" instead of a requirement? Because, a lot of people dont use dashboard.
Whats you opinion on this?

Thanks

On activation of direct_mail in TYPO3 12 I get error, that the Class AnalyzeBounceMailCommand is not found. It is not a composer installation.
I checked the namespace of the class and the 'autoload' in ext_emconf. Don't know, why autoload fails.