Describe the solution you'd like
For example when retrieving a review from the database a steward should get all the review comments and votes but a standard user should just see the voting result. A user might also make an appeal on a review and still see the comment he made but not the ones from the stewards.

This check should be implemented in the Data Access Layer and not in the Web (like the base authorization check) because it might require access to the data to determine wheter a user has access to it or not.

It should be expected to return on of these for possible results:

1. Full data set
2. Data set with information excluded
3. Empty data set
4. "Error" result showing a missing permission to access the data at all.

To Reproduce
Delete single row on results page. Refresh page.
Results are not recalculated

Is your feature request related to a problem? Please describe.
After initially creating the user the user details and password cannot be changed by the user anymore.

Describe the solution you'd like
Options to change User profile and password.

Add new Tables and functions needed for team management:

• TeamEntity (new table)
• Add ForeignKey on MemberEntity

Describe the solution you'd like
Endpoints that provide Write actions should be only available to certain roles

Describe the bug
In a heat race with accumulated results the SeasonStartIrating is caculated anew even if the driver had already participated in this season. This can lead to wrong results in the amateur scoring.

Is your feature request related to a problem? Please describe.
Currently, the user has to click "Calculate" everytime he wants to have changes calculated on the results.

Describe the solution you'd like
Implement a check on the server that marks the result as "need to be recalculated".
When the result is loaded and is marked, the calculation is performed beforehand.

Related Issues
SSchulze1989/iRLeagueManager#85

The driver field in Vote will always return to zero.
The review status displays a random Member at fault - probably takin the next one from the other review.

Describe the bug
After recalculation of results all entries in ScoredResultRows are doubled

To Reproduce
Steps to reproduce the behavior:

1. Make sure Results will be recalculated on next request
2. Get ScoredTeamResult
3. Check doulbe entries in ScoredTeamResultRow->ScoredResultRows

Expected behavior
ScoredResultRows should be distinct.

Tasks

• Implement Endpoint for league rights (check if current user Endpoint can be uses)
• Add check for required league role to all Model and Action Endpoints

Related

• SSchulze1989/iRLeagueManager#37

Settings page is broken and does not save changes anymore
(fix will be delayed because of pending rework of the scoring system)

Describe the bug
When calculating a standing for a session that is not part of the scoring only the first session of the current standing is counted.

To Reproduce
Calculate Standings for a session that is not in the current scoring but has a date later than the latest session of the scoring.

Expected behavior
All sessions before the date of the selected session should be counted.

Description

Older Versions of the might work on Incompatible or Incomplete DTOs.
Mapping these to the DB can lead to invalidation of the Data and in worst case completely preventing another client from working with the data.

Multiple measures need to be taken to prevent this:

• Make sure no changes are submitted/accepted with non-matching versions
• Validating data before saving changes on db.

Work

After the first Major release the API must handle older versions in a non breaking way, but for now i think it is enough to just block all post and put request if the client version is older.

Describe the bug
Priority of drop-weeks for races with equal points does not match the drop-weeks set by DanLisa

**Is your feature request related to a problem?
Current Endpoint is using single route and multiple parameters for league, model type and id. This works well for the app but makes it hard to use for other people.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Describe the bug
Some items produce errors whewn deleted.
This is due to previous changes in the database

Tasks

• Score Team Standings as sum of Team Results (incl. Dropweeks)
• Score Team Standings as sum of Top x Team Driver Results (incl. Dropweeks per Driver)

related:
SSchulze1989/iRLeagueManager#35

Move the funtionality of current MultiScoring to separate Scoring and ScoringTables. MultiScoring will ne deprecated.

Improve the loading speed of user amd league database by using common improvement methods for Entity Framework.

Is your feature request related to a problem? Please describe.
The user should be able to set filters as a scoring option to filter out certain result rows from calculation.
This should give him the possibility to run some kind of Pro Am championship or any other Subset of this kind.

This feature is especially aimed to enable the "Heisse Eisen" scoring fromt he DE-AT-CH club league

Is your feature request related to a problem? Please describe.
As of now, every new league will be stored in its own database. This is great for isolation and access control but has major downsides on managing the databases and making improvements using Views and stored procedures.,

Describe the solution you'd like
Rework the database structure so all data will be stored in the same database. This will require a major rework in how the database is accessed and additional checks to prevent users of a league accidentally (or on purpose ;)) access data that belongs to another league they do not have the rights to.

Tasks

• Add new Endpoint
• Check available Databases
• Return Bad Request if League name does not exist.
• Return Ok if League name does exist

Related

• SSchulze1989/iRLeagueManager#37

Is your feature request related to a problem? Please describe.
The new json file gives a lot more event information than the csv, pretty much the same as is available from the web endpoints. The database and datatransfer layer should be enhanced to store as much of the relevant information as possible, even when they wont be used at this time.

Describe the solution you'd like
Check information available in file and add columns to store all this information in database.