srinisubra / google-singleton-detector Goto Github PK

We use Hudson and Ant for continuous builds. We also use the Plot plugin to 
visualize progress.

The attached patch adds a GsdAntTask class, which allows GSD to be run as an 
ant task. It also adds an optional Plot data output.

Summary of changes: 
-- In the Stats class, I made members private, and increment methods 
PackagePrivate.
-- In the SingletonDetector class, and added a getStats method, to return the 
Stats class.
-- Added the GsdAntTask class.

There seem to be a problem with asm library used in GSD. I get
ArrayIndexOutOfBoundsException When I try to used it to analyse one of my jars.

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 59806
        at org.objectweb.asm.ClassReader.getSuperName(Unknown Source)
        at com.google.singletondetector.SingletonDetector.validcr(Unknown
Source)
        at
com.google.singletondetector.SingletonDetector.buildCrlist(Unknown Source)
        at
com.google.singletondetector.SingletonDetector.buildCrlist(Unknown Source)
        at
com.google.singletondetector.SingletonDetector.buildCrlist(Unknown Source)
        at
com.google.singletondetector.SingletonDetector.buildCrlist(Unknown Source)
        at
com.google.singletondetector.SingletonDetector.buildCrlist(Unknown Source)
        at
com.google.singletondetector.SingletonDetector.buildCrlist(Unknown Source)
        at
com.google.singletondetector.SingletonDetector.getClassReaders(Unknown Source)
        at com.google.singletondetector.SingletonDetector.<init>(Unknown
Source)
        at com.google.singletondetector.Main.<init>(Unknown Source)
        at com.google.singletondetector.Main.main(Unknown Source)

The generated graphml output does not contain any elements such as:
<y:Geometry height="30.0" width="30.0" x="177.0" y="10.0"/>

So all nodes on the graph are positioned on the same spot, thus making the
graph non usable.

I used gsd-0.7.3.zip

thanks

What steps will reproduce the problem?
1. execute the following command
2. java -jar gsd.jar -S path/somejar.jar export.graphml
3.

What is the expected output? What do you see instead?
the graph generated, the following stacktrace
Exception in thread "main" java.lang.RuntimeException: 
java.util.zip.ZipException: error in opening zip file
    at com.google.singletondetector.classpath.JarClasspathRoot.jarFileForUrl(Unknown Source)
    at com.google.singletondetector.classpath.JarClasspathRoot.preloadNamesFromJar(Unknown Source)
    at com.google.singletondetector.classpath.JarClasspathRoot.<init>(Unknown Source)
    at com.google.singletondetector.SingletonDetector.buildCrlist(Unknown Source)
    at com.google.singletondetector.SingletonDetector.buildCrlist(Unknown Source)
    at com.google.singletondetector.SingletonDetector.buildCrlist(Unknown Source)
    at com.google.singletondetector.SingletonDetector.getClassReaders(Unknown Source)
    at com.google.singletondetector.SingletonDetector.<init>(Unknown Source)
    at com.google.singletondetector.Main.<init>(Unknown Source)
    at com.google.singletondetector.Main.main(Unknown Source)
Caused by: java.util.zip.ZipException: error in opening zip file
    at java.util.zip.ZipFile.open(Native Method)
    at java.util.zip.ZipFile.<init>(ZipFile.java:127)
    at java.util.jar.JarFile.<init>(JarFile.java:135)
    at java.util.jar.JarFile.<init>(JarFile.java:72)


What version of the product are you using? On what operating system?
gsd-0.7.3

Please provide any additional information below.

GSD currently misses singletons in which the instance field is private.

What steps will reproduce the problem?
1. <same as instructed on the Google code site>

What is the expected output? What do you see instead?
Expected Output - Should give me the expected result of GSD.

Here is the output i am getting -
C:\gsd-0.7.3>java -jar gsd.jar -shS -t 2 test_gsd.jar goo.graphml com.test.gsd
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 735
        at org.objectweb.asm.ClassReader.<init>(Unknown Source)
        at org.objectweb.asm.ClassReader.<init>(Unknown Source)
        at org.objectweb.asm.ClassReader.<init>(Unknown Source)
        at
com.google.singletondetector.SingletonDetector.getClassReader(Unknown
 Source)
        at
com.google.singletondetector.SingletonDetector.buildCrlist(Unknown So
urce)
        at
com.google.singletondetector.SingletonDetector.getClassReaders(Unknow
n Source)
        at com.google.singletondetector.SingletonDetector.<init>(Unknown
Source)

        at com.google.singletondetector.Main.<init>(Unknown Source)
        at com.google.singletondetector.Main.main(Unknown Source)

What version of the product are you using? On what operating system?
0.7.3 - Win XP

Please provide any additional information below.

GSD currently misses singletons in which the instance field is inside of a
private inner-class.

You haven't specified the minimum java version required to use the 
precompiled jar file. Running it with java 1.4.2 I get:

rich@lisa:~/tmp> java -jar gsd.jar
Exception in thread "main" java.lang.UnsupportedClassVersionError: 
com/google/singletondetector/Main (Unsupported major.minor version 49.0)

If you're going to compile it to require a particular jvm release, please 
let us know which one!

If a directory is passed to GSD at a parameter, all jars in that directory
are not analyzed.