Code Monkey home page Code Monkey logo

Comments (9)

mtklr avatar mtklr commented on May 25, 2024 2

In Terminal.app, there's a gear icon in the color picker to select color profile. The built-in Terminal "themes" are set to "Device RGB", Srcery colors are set to "Generic RGB". Maybe changing the profile here will make the colors consistent?

srcerycolors

from srcery-terminal.

roosta avatar roosta commented on May 25, 2024

Is there anything I can do with either Alacritty or Terminal.app conf? This seems to be an OS issue if what you describe is happening. Seems none of the colors when using Apple Digital Colour Meter are correct. If I check the Alacritty conf the color hexes are correct according to the srcery palette. I don't know exactly whats going on with the terminal.app config, it was generated using terminal.sexy using the same palette, but if you confirmed the hex values are correct it seems to be an issue with color correction

from srcery-terminal.

xfbs avatar xfbs commented on May 25, 2024

They are both correct, in a way: #EF2F27 = rgb(239, 47, 39), and they both show 239, 47, 39 as color values. But one of them is interpreting that as a gRGB, and the other as a native RGB. I guess this is a bug with Alacritty (or Terminal.app?).

from srcery-terminal.

MindTooth avatar MindTooth commented on May 25, 2024

Can this be of relevance alacritty/alacritty#1485?

from srcery-terminal.

xfbs avatar xfbs commented on May 25, 2024

Oh wow.. I didn't even notice that thing. That seems like a good remedy!

from srcery-terminal.

roosta avatar roosta commented on May 25, 2024

Since this seems to be resolved, I'm closing this issue.

from srcery-terminal.

Sangeppato avatar Sangeppato commented on May 25, 2024

I think this issue is not really solved.
Since the Terminal.app profile uses the 'Generic RGB' colorspace, the colors will be off when moving to sRGB/Device RGB.
The only solution is to generate a profile that uses the sRGB colorspace, but unfortunately it's overly complicated because of how Apple stores the profile configuration in a file.

I think that adding a note in REAMDE mentioning this would be useful.

I have a "patched" Terminal.app profile here: https://github.com/Sangeppato/srcery-terminal-app

from srcery-terminal.

MindTooth avatar MindTooth commented on May 25, 2024

Is your solution generic enough that we might upstream it? How will it effect others?

from srcery-terminal.

lulor avatar lulor commented on May 25, 2024

@MindTooth If you're referring to this repo, unfortunately the profile is manually generated following the palette.
I didn't find any resource about creating a profile for Terminal.app using sRGB colours.

from srcery-terminal.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.