Code Monkey home page Code Monkey logo

gmusicbrowser's People

Contributors

abuyop avatar alessio avatar beatlink avatar bucaneer avatar demanuel avatar dmhursh avatar fredurb1 avatar genebustam avatar gijstimmers avatar hiunnhue avatar kbsky avatar majorgrubert avatar ochosi avatar psimacek avatar salepetronije avatar sbte avatar smarquespt avatar spike29 avatar squentin avatar tacvbo avatar th3pr0ph3t avatar trasdahl avatar voizzzz avatar wwwdesign avatar yoshi818 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

gmusicbrowser's Issues

high CPU usage

I'm using debian 1.1.9 version, although music is not playing the CPU load is quite high, appox 60%.

  • same issue for github version
  • when I delete ~/.config/gmusicbrowser/gmbrc (clean start) gmusicbrowser is permanently taking about 60% of CPU, which is too much for not doing anything

perl version: 5.14.2
Ubuntu, Linux kernel 3.5.0-25-generic

Improve handling of lrc lyrics

I have got several suggestions regarding lrc lyrics.

Mostly, it should be integrated with the current lyrics plugin, meaning you could also add sources for lrc files and users would get the option to modify the precedence of sources or entirely disable lrc sources (this also fits in with my other request of checking next source if previous one fails).

The lyrics line from the karaoke plugin could have more setting (bg/fg color, alignment, position, number of lines shown, etc).

Because of the nature of lrc files, stuff to think of are:

  • Blacklisting an specific lrc file/source for that one song, if it's completely wrong, and the search would move on to other sources (this would also be useful for the normal lyrics plugin after the source predence thing is done)
  • Being able to correct the timing, somewhat like when you handle external movie subtitles, except the corrections would be permanent, or at least could be made permanent. In my opinion, there's no reason not to apply changes immediately to the file, but that's, of course, your decision in the end.

Arabic tags in some files are messed up

Hello!

I'm trying to make the player display my files' tags correctly with no luck. Some of them are working fine, the rest just weird characters. I tried changing the encoding without success. I also use Audacious with the fallback to 'Windows-1256' encoding and everything is working fine there!

problem with hidden visuals

I have a hidden Visuals in the layout:

Can't call method "XID" on an undefined value at /usr/bin/../share/gmusicbrowser/gmusicbrowser_gstreamer-0.10.pm line 320.

and

Can't call method "XID" on an undefined value at /home/andreas/src/gmusicbrowser/gmusicbrowser_gstreamer-0.10.pm line 261.

No error with this, but the visuals opens in a new Window:
http://pastebin.com/BfxMJSa8

last played displayed time/date acts odd

I'm running 1.1.6, and noticed that when songs are played or added, the displayed date and time acts oddly. The best I can explain it is that if I played some music at 9:00pm, then looked at the same file in the browser at 3:00am (6 hours later), gmusicbrowser displays the last played date as "today" rather than "yesterday".

I'm guessing that the determination to display "today", "Sunday", etc is made based on something like the current timestamp subtracted the file play epoch. This probably needs to be tweaked.

wishlist: add cdg support to karaoke plugin

Currently, the karaoke plugin uses lrc files for lyrics. An improvement would be to add support for mp3+cdg -- possibly on the audio tab using pykaraoke as an alternative/in addition to the gstreamer/mpg123/mplayer.

New playing track won't get focused

The window focus isn't jumping to the newly playing track anymore, it stays on the selected track. I don't see a setting for this or a button to jump to the current track either.

Not building

Hi,
looks like the new layout_doc in markdown format (SHA: efe6d67) did not make it's way into the makefile. It's still referencing the old html file.

can't update ID3 tags in KDE

I'm using latest version from github

(gmusicbrowser.pl:12136): libnotify-CRITICAL **: notify_notification_update: assertion `summary != NULL && *summary != '\0'' failed
Use of uninitialized value in subroutine entry at ./gmusicbrowser.pl line 534, <$OUTPUTfh> line 6299.

Writing tags freezes and the dialog as well

gmb crashes

  1. I start gmb with a layout without visualization.
  2. I switch to a layout with visualization.
  3. I start playing.
  4. Visualization is ok
  5. I switch to the previous layout without visualization.
  6. I switch to the previous layout with visualization.
  7. It opens another small window for visualization.
  8. gmb crashes
  9. I start gmb and switch to the layout with visualization.
  10. I start playing.
  11. The visualization is displayed only in its own window.
  12. The visualization is displayed again on the layout when I remove the line Window: hidden: ... in the gmbrc

Rating stars bug

_Stars(xalign=.5)
The sensitive area is not in the middle, but left in the parent container.

playlist reseted while playing

When I create a playlist based on rating and while song is playing I change rating of the song(so it doesn't match the filter), it's automatically filtered, but gmusicbrowser goes to the first song in the playlist (I would expect song after the one that has been rated).

transparency

I skinned the volume button with a transparent skin. However, some containers will be hidden (Prev, Next, Play, Button).

Auto-size columns

Please add a way to have the columns on the library browsers size themselves. Whenever I maximize gmusicbrowser, columns are too small. When I unmaximize it, they are too big.

commit 33673ba only works on mouse over

I have two skinned Play buttons. With the first button I start playback. The second button will retain its look. Only when I take the mouse over the second button, the image is changed.

visuals freeze

I play a song and when the next song starts, then freezes the visualization.

Slash bar in artist name

If an slash bar is present in the artist name like in AC/DC, two artists are shown (AC and DC) but not the correct artist name (no AC/DC for us)
AC
DC

duplicate symbol play

When you add two same songs to playlist, the symbol "play" is displayed next to both of them. But only one is actually playing, when you delete this one it stops playing, when you delete the other one, nothing happens (expected).

Bug in skin for Scale

In the example paper.layout everything works except the skin for Scale. In my layout it is the same, the skin is not shown for Scale.

crossfade support?

Would it be possible/easy to implement crossfading for the gstreamer backend? I think musikcube does it right - the default timings are very sensible (different ones for prev/next and pause/play and select track) and it's easy to change them + disable/enable crossfading.

default hidden and toggle

If an element of the layout is hidden by default (Default = Window(hidden=...)), it is not with the command ShowHideWidget shown on the first call of the command. Until the second execution of the command, it behaves as expected.

crash

(gmusicbrowser:16961): GStreamer-CRITICAL **:
Trying to dispose element playbin2inputselector0, but it is in PLAYING instead of the NULL state.
You need to explicitly set elements to the NULL state before
dropping the final reference, to allow them to clean up.
This problem may also be caused by a refcounting bug in the
application or some element.

Support multiple values for artist tag

Hi,

According to the id3 specification, it is possible to add more than one value to specific tags; for example, have a look at "Multiple values in v2.4 tags" of the following page:
http://en.wikipedia.org/wiki/Id3v2

This is particular interesting for the artist field, because by using the ability to define multiple values, the featured artist can be added as an independent value instead of appending him with the feat. keyword to the other artist name. (As gmusicbrowser already has an option to extract the featured artist from the title, this might be an interesting enhancement.)

I have various songs that have been tagged with exfalso/quodlibet, where the featured artist is defined as a separate value in the artist tag and gmusicbrowser seems to simply ignore it. Could you make gmusicbrowser take it into account, for example by showing all values of the artist tag separated by comma in the artist field.

Thanks in advance for taking this into account.

Cheers,

Francesco

gmb crashes, the 2nd

Can't locate object method "UpdateToggleState" via package "Gtk2::CheckMenuItem" at /usr/bin/../share/gmusicbrowser/gmusicbrowser_layout.pm line 3521.

The problem occurs with the menu items, e.g.
"->" - "Middle area" -> "Genre and Year"
"->" - "Middle area" -> "Album and artist"
an in their submenus.

The layout: http://pastebin.com/73Yy7kJK

Dynamic tab names

I'm wondering if it's possible to implement % variables in tab names, so, for instance, ochosi's Artist Info tab could become "%a info" or something like that.

gmb crashes

Remove all columns in a songtree:

Modification of non-creatable array value attempted, subscript -1 at /usr/bin/../share/gmusicbrowser/gmusicbrowser_list.pm line 5503.
Gdk-WARNING **: losing last reference to undestroyed window

Freeze after commit ffffd405e15b7b830670bf0b259edb7348a24c5c gstreamer: make it listen to changes in pulseaudio's volume (only with perl-glib>=1.251) when "remember playing position..." is checked

This bug only triggers if I check, "remember playing postion between songs" and scroll on the current song timeline with the mouse wheel (ff, rewind), then gmb instantly freezes. Also if I exit when playing or in pause state, on restart gmb freezes and the only way to quit is kill -9

If instead of using the mouse wheel I left click on the song timeline gmb doesn't freeze

If I press stop before exiting, I can restart without freezes.

using perl-Glib-1.280-1.fc18.x86_64 and gstreamer1-1.0.6-1.fc18.x86_64

gmb should not crash through a broken layout

Use of uninitialized value $s in string eq at /usr/bin/../share/gmusicbrowser/gmusicbrowser_layout.pm line 4199.
Use of uninitialized value in concatenation (.) or string at /usr/bin/../share/gmusicbrowser/gmusicbrowser_list.pm line 825.
layout error: (VBmain MBlist) have no parent -> can't find toplevel box
Can't call method "parent" on an undefined value at /usr/bin/../share/gmusicbrowser/gmusicbrowser_list.pm line 1089.

Problem, gmb crashes.

Use of uninitialized value $hidden in join or string at /usr/bin/../share/gmusicbrowser/gmusicbrowser_layout.pm line 1697.

size on an undefined value

Can't call method "set_size_request" on an undefined value at /home/andreas/src/gmusicbrowser/gmusicbrowser_layout.pm line 959

show a song in gmusicbrowser

When some song is playing from a playlist would it be possible to add to context menu "show in gmusicbrowser" which would show song in library (currently is there only "open containing folder")

unhandled exception in callback

*** unhandled exception in callback:
*** variable not allowed to be undef where GtkTreeIter is wanted at /home/andreas/src/gmusicbrowser/gmusicbrowser_list.pm line 2427.
*** ignoring at /home/andreas/src/gmusicbrowser/gmusicbrowser_layout.pm line 1646.
*** unhandled exception in callback:
*** variable not allowed to be undef where GtkTreeIter is wanted at /home/andreas/src/gmusicbrowser/gmusicbrowser_list.pm line 2427.
*** ignoring at ./gmusicbrowser.pl line 1246.

Filter, Sort and Queue buttons use 'wrong' mouse buttons

These buttons, mostly located near the playlist, have assigned a clear action to the right mouse button, while left and middle mouse buttons pop up their menu.

Very often I click with the right button on one of them, to use the menu, accidently clearing the queue or discarding my custom unsaved filter.

The menu should pop up with the right mouse button and the clear action should be assigned to the middle button like most modern graphical applications do this.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.