Comments (4)
dfed
commented on June 2, 2024
1
Hey Logan! Good to hear from you, and thanks for letting us know about this issue.
The wrinkle with fixing this issue will be that the LocalAuthentication framework doesn't exist on tvOS:
Valet/Sources/Valet/SinglePromptSecureEnclaveValet.swift
Lines 17 to 18 in 56952ae
Given these warnings, and given that LocalAuthentication is missing from tvOS: it sounds like we should remove SecureEnclaveValet from the tvOS target entirely, taking a similar approach as we did in #284. I don't have the bandwidth to put a PR together for this at the moment, and would welcome one from you.
I think we'll treat this issue as a bugfix bump since from the warning it looks like SecureEnclaveValet never actually worked on tvOS (it works on simulator / tests but apparently the simulator can get this kind of thing wrong), and given that no one ever told us that this wasn't working it seems like no one was using the feature.
Let me know your thoughts. cc @NickEntin
from valet.
AttilaTheFun
commented on June 2, 2024
1
Sure that makes sense! I can try to put a PR together for that next week.
from valet.
NickEntin
commented on June 2, 2024
That approach sounds good to me 👍
from valet.
Related Issues (20)
- Module compiled with Swift 5.2.2 cannot be imported by the Swift 5.3 compiler HOT 3
- Feature Request, Unlock with Apple Watch HOT 6
- Add convenience access methods for `Codable` types HOT 6
- .whenUnlocked vs .afterFirstUnlock HOT 3
- Create new KeyChain Option HOT 5
- SecKeychainAddCallback(_:_:_:) along with Valet HOT 4
- Enable customization of biometrics prompt with application-specific fallback HOT 26
- Unit tests fail on tvOS 14 HOT 4
- Tips on building and running the sample app? HOT 1
- Keychain Sharing between iOS App and Apple Watch Extension HOT 6
- Documentation for `afterFirstUnlockThisDeviceOnly` wrong? HOT 1
- iOS 15 crash on `specialized static SecItem.copy<A>(matching:)` HOT 18
- [Feature Request] Unlock with Apple Watch with no passcode fallback HOT 7
- iOS 16 build error HOT 6
- tvOS target doesn't compile with Xcode 14.0 beta HOT 8
- (Some folks) await async support HOT 5
- error: non-void function does not return a value [-Werror,-Wreturn-type] HOT 2
- No way to invalidate() HOT 1
- Support for cryptographic key item (kSecClassKey) HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from valet.