Comments (8)
This is fixed on master
in #284. After consulting with @NickEntin, I'm releasing this fix as a bug fix release with 4.1.3
. Our reasoning is we believe that SinglePromptSecureEnclaveValet
never actually worked on tvOS
, which means we expect no consumer of Valet
is using it.
If we are wrong and you did use this Valet type on a tvOS
target, please let us know. I will never this change, push a bugfix version with the revert, and then un-revert this change and push a major version bump
Thank you @diogot for both identifying and solving this issue!
from valet.
I'll close this once I post a new release. Soon!
from valet.
Thanks for letting us know! And solid call-out that this issue is likely related to #270. Fixing this will likely require removing any LAContext
-interacting code from the tvOS target. Technically this is a source-breaking change, but given that this source likely never worked to begin with given the availability markings on LAContext
we can likely fix this without a major version bump.
from valet.
Awesome, thanks!
Let me know if you need any help.
from valet.
If folk want a fast turnaround on this issue then I would encourage folk to put up a PR. I will not personally be addressing this issue this month.
from valet.
It was an easy fix, I opened a PR #284 to fix this.
Let me know what do you think.
from valet.
It might be related to #270
from valet.
Should we close this issue now or wait until the fix goes in the next release?
from valet.
Related Issues (20)
- Add convenience access methods for `Codable` types HOT 6
- .whenUnlocked vs .afterFirstUnlock HOT 3
- Create new KeyChain Option HOT 5
- SecKeychainAddCallback(_:_:_:) along with Valet HOT 4
- Enable customization of biometrics prompt with application-specific fallback HOT 26
- Unit tests fail on tvOS 14 HOT 4
- Tips on building and running the sample app? HOT 1
- Keychain Sharing between iOS App and Apple Watch Extension HOT 6
- Documentation for `afterFirstUnlockThisDeviceOnly` wrong? HOT 1
- iOS 15 crash on `specialized static SecItem.copy<A>(matching:)` HOT 18
- [Feature Request] Unlock with Apple Watch with no passcode fallback HOT 7
- iOS 16 build error HOT 6
- Deprecation warnings when targeting iOS 14+ HOT 4
- (Some folks) await async support HOT 5
- error: non-void function does not return a value [-Werror,-Wreturn-type] HOT 2
- No way to invalidate() HOT 1
- Support for cryptographic key item (kSecClassKey) HOT 2
- Could not find module 'Valet' for target 'x86_64-apple-ios-simulator' HOT 7
- Migration from Valet 3 format HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from valet.