Code Monkey home page Code Monkey logo

Comments (8)

dfed avatar dfed commented on June 2, 2024 3

This is fixed on master in #284. After consulting with @NickEntin, I'm releasing this fix as a bug fix release with 4.1.3. Our reasoning is we believe that SinglePromptSecureEnclaveValet never actually worked on tvOS, which means we expect no consumer of Valet is using it.

If we are wrong and you did use this Valet type on a tvOS target, please let us know. I will never this change, push a bugfix version with the revert, and then un-revert this change and push a major version bump

Thank you @diogot for both identifying and solving this issue!

from valet.

dfed avatar dfed commented on June 2, 2024 2

I'll close this once I post a new release. Soon!

from valet.

dfed avatar dfed commented on June 2, 2024 1

Thanks for letting us know! And solid call-out that this issue is likely related to #270. Fixing this will likely require removing any LAContext-interacting code from the tvOS target. Technically this is a source-breaking change, but given that this source likely never worked to begin with given the availability markings on LAContext we can likely fix this without a major version bump.

from valet.

diogot avatar diogot commented on June 2, 2024 1

Awesome, thanks!
Let me know if you need any help.

from valet.

dfed avatar dfed commented on June 2, 2024 1

If folk want a fast turnaround on this issue then I would encourage folk to put up a PR. I will not personally be addressing this issue this month.

from valet.

diogot avatar diogot commented on June 2, 2024 1

It was an easy fix, I opened a PR #284 to fix this.
Let me know what do you think.

from valet.

diogot avatar diogot commented on June 2, 2024

It might be related to #270

from valet.

diogot avatar diogot commented on June 2, 2024

Should we close this issue now or wait until the fix goes in the next release?

from valet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.