It's occasionally useful to be able to populate the Phrase parameter set without having access to Resources, and actually load the template and bind the parameters late. The current API does not support this well.

Please, add in readme info that keys must be lowercase

How do you handle "1 Beer" vs "3 Beers" with this library? Is there any special code for that or is something like that planned?

Hi,

would like to adopt the library but things like the camel-case bug #32 or missing plurals support #2 are kind of blockers to me.
Some PRs are open for quite a while now.
Can we expect updates in the near future?

We should at least call out in the docs that Phrase.put(String, int) uses the value of the int as a string, rather than grabbing a string from resources. Many Android views have interchangeable methods like setText(String) and setText(int) that could mislead a user of this library.

I don't have great suggestions of a more concrete fix. Maybe rename to putInt(String, int) but that seems ugly.

Looks like this it's caused by only checking for letters and underscores in

private KeyToken key(Token prev){

....

    while ((curChar >= 'a' && curChar <= 'z') || curChar == '_') {
      sb.append(curChar);
      consume();
    }

...
}

Seeing as Jetpack Compose is the new hotness, it would be great to have support for building AnnotatedStrings. Options:

0. Yolo, add the Compose dependency and people can manually remove it if they care.
1. Fork
2. Do the okio/etc thing and change the artifact id to phrase2 and include Compose in that artifact. If somehow there are bugs that need to get fixed, in theory we can do a release of both artifacts
3. Separate phrase-compose artifact, make keys/keysToValues public, and add a method in the new artifact that reads them and builds an AnnotatedString

Hey! This looks pretty great, and I wanted to propose adding an interceptor API of sorts to allow for dynamic configuration of strings as they come through. This would allow for experimentation with copy pretty easily, as well as anything else people might come up with a need for.

Something like this?

<string name="xx"><color="@color/color_id">{a}</color> is {b}<color="#aabbcc">awesome?</color></string>

keyCamelCase -> fails
key_camel_case -> accepted

CharSequence formatted = Phrase.from("Hi {first_name}, you are {orderBy} years old.")
.put("first_name", firstName)
.put("orderBy", age)
.format();

when the string contains 'orderBy' it Throw IllegalArgumentException: Missing closing brace: }

Hi,

I'm getting a crash when using Phrase.from("This is an {EXAMPLE}");
Throwing a 'Unexpected character 'E'; expected key.'

Could you add support for uppercase keys? It would help me since i'm not controlling the strings I receive.

Thank you !

Now it's only support "{" and "}", hope to custom prefix and suffix

Hi there,

The following string and the invocation of Phrase got me this exception every time. Could someone take a look and tell me what went wrong? Thanks! :
<string name="example_string">{aaa} (Now {bbb})</string>

Phrase.from(this, R.string.example_string)
                    .put("aaa", getAaa())
                    .put("bbb", getBbb())
                    .format()

This is the exception:

Exploded trying to parse content: java.lang.IllegalArgumentException: Missing closing brace: }
    at com.squareup.phrase.Phrase.key(Phrase.java:245)
    at com.squareup.phrase.Phrase.token(Phrase.java:221)
    at com.squareup.phrase.Phrase.<init>(Phrase.java:204)
    at com.squareup.phrase.Phrase.from(Phrase.java:112)
    at com.squareup.phrase.Phrase.from(Phrase.java:103)
    at com.squareup.phrase.Phrase.from(Phrase.java:94)

ListPhrase listFormatter = ListPhrase.from(" and ", ", ", and ");

String[] texts=new String[]{"Joe", "Jane", "John"};
ArrayList<CharSequence> bolds=new new ArrayList<>();

for(String t : texts){
     Spannable b = new SpannableString(t);
     boldString.setSpan(new StyleSpan(BOLD), 0, t.length(), Spannable.SPAN_INCLUSIVE_INCLUSIVE);
     bolds.add(b)
}
return listFormatter.join(bolds)

That doesn't show style while Phrase support for Spannable