Thanks for sharing your scripts.
Did pick up something funny where the check for the FailoverCluster module. Line

On a Windows Server 2016, once the "Install-WindowsFeature -Name Failover-Clustering -IncludeManagementTools" is executed. The module is named FailoverClusters not FailoverCluster

Hello! First off, thank you for this and all other incredibly useful functions you've written.

I've found an issue with this spot of error handling at the end of this function (starting at line 2016):

Function Get-TheModule { Get-Module FailoverCluster } if(-Not(Get-TheModule)){ Write-Warning "Sorry you dont have the failover cluster module installed so wont be abel to get the cluster log" Write-Warning "You will need to run Install-WindowsFeature -Name Failover-Clustering -IncludeManagementTools"

Correct me if I'm wrong, but "FailoverCluster" should be replaced with "FailoverClusters." I ran these commands to confirm:

C:> Get-Command -Module FailoverClusters | Measure | Select Count

Count : 120

Please let me know if I'm mistaken with anything here.

I have installed the Failover-Clustering as requested. But still fails the check on the Get-module to see if the Failover Clustering exists. Output below from the PS window.

PS C:\Program Files\WindowsPowerShell\Modules\dbatools\functions> Install-WindowsFeature -Name Failover-Clustering -IncludeManagementTools

Success Restart Needed Exit Code Feature Result

True No NoChangeNeeded {}

PS C:\Program Files\WindowsPowerShell\Modules\dbatools\functions> $InstallationFolder = 'C:\Program Files\WindowsPowerShell\Modules\FailoverDetection'
$DownloadFolder = 'C:\Program Files\WindowsPowerShell\Modules\FailoverDetection'
$DataFolder = 'C:\Program Files\WindowsPowerShell\Modules\FailoverDetection\Data'
$SQLInstance = 'USPPDW-SQLN01'

$invokeSqlFailOverDetectionSplat = @{
    DownloadFolder = $DownloadFolder
    SQLInstance = $SQLInstance
    DataFolder = $DataFolder
    InstallationFolder = $InstallationFolder
    AlreadyDownloaded = $false
    Analyze = $true
    Show = $true
}
Invoke-SqlFailOverDetection @invokeSqlFailOverDetectionSplat -WhatIf

WARNING: Sorry you dont have the failover cluster module installed so wont be abel to get the cluster log
WARNING: You will need to run Install-WindowsFeature -Name Failover-Clustering -IncludeManagementTools

PS C:\Program Files\WindowsPowerShell\Modules\dbatools\functions>

Thanks for sharing your scripts.
Did pick up something funny where the check for the FailoverCluster module. Line

On a Windows Server 2016, once the "Install-WindowsFeature -Name Failover-Clustering -IncludeManagementTools" is executed. The module is named FailoverClusters not FailoverCluster

Hey, SQLDBAWithABeard! Can you help me?

Write-RsRestCatalogItem : System.Exception: Failed to create catalog item: The remote server returned an error: (422) Unprocessable Entity. --->
System.Net.WebException: The remote server returned an error: (422) Unprocessable Entity.
at Microsoft.PowerShell.Commands.WebRequestPSCmdlet.GetResponse(WebRequest request)
at Microsoft.PowerShell.Commands.WebRequestPSCmdlet.ProcessRecord()
--- End of inner exception stack trace ---
At C:\Users\loren\Downloads\deploy_pbix_reports.ps1:162 char:13

•         Write-RsRestCatalogItem -WebSession $session -Path $PBIXF ...
  

•         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  

  • CategoryInfo : NotSpecified: (:) [Write-Error], WriteErrorException
  • FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,Write-RsRestCatalogItem

Hi

First of all, thanks for sharing the code.

Some suggestions to the script:

• Get-CIMInstance predicts the use of sessions, so to reduce authentication overhead you could use Get-CIMSession and use that
• Get-Service status can be joined with equivalent Win32_Service call and then Pester the resulting properties separately
• Both services can be queried at the same time
• Get-CIMSession can be added in the server connectivity to check for server connectivity
• Invoke-Command should also be tested at this level for WinRM staus (I think there are other ways to check through CIM)
• You forgot named instances :P

I know this is just a community sample and as such you might have this implemented in your own scripts, but as "The" SQL Server guy to go on PowerShell :) it would be great that the first 5 could reach the community.

Cheers