spywhere / vscode-guides Goto Github PK

Hi There,

first of all 👍 for this extension.

If i start vscode v1.0.1-insider the indent guides aren't visible anymore.
Here is the corresponding callstack:

This is because this.configurations.get here and here returns undefined so the forEach loop fails.

I havent set any of the Guide settings in my custom user settings. I testwise added undefinded checks for this.configurations.get and the extension starts working again. Maybe there was an api change for this.configurations.get from the vscode folks.

Thanks again

Both the "guides.indent.backgrounds" and guides.rulers" aren't being defaulted, so not adding them to the user settings results in exceptions as depicted below.

I prepared some screenshots, which shows where the guide is (green dashed line) and where I expected it (red line):

✅ OK:

🚫 Wrong:

🚫 Wrong (where is the guide?!)

🚫 Wrong:

🚫 Wrong:

For example how should it work (in my opinion), please check how work BracketHighlighter for Sublime Text.
I've tested it on VS Ccode 1.16.0 & Mac OS.

is there has any method to resolve this question？

hi, is there any way to get column guide at 80 or 100 char?

Hello, after updating Visual Studio Code to version 1.13.0, guides stopped showing.

Let me know if you need more info 🙂

VS CODE version: 1.13.0
Guides extension has detected that you are using "editor.renderIndentGuides" settings. Guides will now disable all indentation guides by override the style to "none".

• Issue Type: Performance
• Extension Name: guides
• Extension Version: 0.9.3
• OS Version: Linux x64 5.11.0-40-generic
• VS Code version: 1.62.3

⚠️ Make sure to attach this file from your home-directory:
⚠️/tmp/spywhere.guides-unresponsive.cpuprofile.txt

Find more details here: https://github.com/microsoft/vscode/wiki/Explain-extension-causes-high-cpu-load

Guides have recently stopped working for me... Following is the warning that I've started seeing:

Warn Guides extension has detected that you are using "editor.renderIndentGuides" settings. Guides will now disable all indentation guides by override the style to "none".

• I have search open issues for duplicate issues
• I have search close issues for potential fixes
• Guides Version: 0.9.3
• VSCode Version: 1.44.0
• OS Version: macOS Catalina v10.15.3

Steps to Reproduce:

1. add an element to guides.indent.backgrounds in a different format than:

rgba(RRR, GGG, BBB, float:A)`

like any hex-value. eg. #RGBA or #RRGGBBAA

Actual Behaviour:

The settings-editor and -JSON will display an error:

String does not match the pattern of "rgba\s*(\s*\d+\s*,\s*\d+\s*,\s*\d+\s*,\s*(\d(.\d+)?|.\d+)\s*)".

vs-code will display it correctly, tho.

Expected Behaviour:

that the extention should not report an error for using standard vs-code colour notation

• I have search open issues for duplicate issues
• I have search close issues for potential fixes
• Guides Version: 0.9.3
• VSCode Version: 1.63.2
• OS Version: Darwin arm64 21.2.0

Steps to Reproduce:

1. Open a new file that has ~1000 lines
2. Scroll down (or up) to line 500-ish
3. Observe the rendering issue

The only way to trigger re-render lines is to click somewhere in the file

Actual Behaviour:

Expected Behaviour:

After updating vscode today, I got this message.
Guides is not working even I disable the editor.rederIndentGuides setting.

Hi,
in new VC 1.5.3 after open editor lines show up in js file. Any action in the editor makes it disappear and never show up.

Paul.

spywhere.guides-unresponsive.cpuprofile.txt

• Issue Type: Bug
• Extension Name: guides
• Extension Version: 0.9.3
• OS Version: Windows_NT x64 10.0.19042
• VSCode version: 1.53.2

⚠️ We have written the needed data into your clipboard. Please paste! ⚠️

This is a feature request which I think would fit this extension. Although it might go beyond the scope of it.
The idea comes from Visual Studio's Structure Visualizer Extension.

The extension for Visual Studio colors the indent guides differently based on the type of the block.
For instance, loops result in a red colored indent guide, while ifs do have a green one:

So, while I don't think there is currently no way to reliably determine whether a given block is a loop or a conditional, a filetype based regex could probably suffice. What do you think?

Great plugin.

I'd like normal, stack, and active guides to accept arrays as you've done with backgrounds. Then you could do something like:

"guides.stack.color.dark": [
  "rgba(252, 30, 112, .30)",
  "rgba(166, 226, 46, .30)",
  "rgba(96, 211, 232, .30)",
  "rgba(253, 151, 31, .30)"
],

"guides.active.color.dark": [
  "rgba(252, 30, 112, .90)",
  "rgba(166, 226, 46, .90)",
  "rgba(96, 211, 232, .90)",
  "rgba(253, 151, 31, .90)"
],

...for an effect like:

Thank you for using this extension and your time reading this message.

Since my active code editor is no longer a VSCode, I haven't got enough time to maintain my own extensions (as I'm always used my own extensions). So to make it clear and set the expectation, this extension will be less active over time.

However, I might made some changes here and there for low hanging fruits and would be happy to help anyone who want to submit a PR.

For bugs, only a major bug that cause a crash or unavoidable performance issue would be considered. Minor bugs or bugs that have a workaround would not get much attention.

if i don't like guides in some language type (like js), currently i can't configure that i don't like to see guides in the same.

• I have search open issues for duplicate issues
• I have search close issues for potential fixes
• Guides Version: 0.9.1
• VSCode Version: 1.24.1
• OS Version: macOS High Sierra 10.13.5

Steps to Reproduce:

1. open VSCode
2. zoom in

Actual Behaviour:
closing and opening gutter brackets appear blurry

Expected Behaviour:
pixel sharp vector indicators

Hi,

I'm investigating a performance issue that's quite similar to #6 input lag for typing. When I open the dev tools I'm seeing lots of these errors:

I have no issue with sending usage stats, but will turn this off until it's corrected.

Thanks,
Eugene

• Issue Type: Performance
• Extension Name: guides
• Extension Version: 0.9.3
• OS Version: Darwin x64 17.7.0
• VSCode version: 1.35.1

⚠️ Make sure to attach this file from your home-directory:
⚠️/Users/sagarbarot/spywhere.guides-unresponsive.cpuprofile.txt

Find more details here: https://github.com/Microsoft/vscode/wiki/Explain:-extension-causes-high-cpu-load

• Issue Type: Performance
• Extension Name: guides
• Extension Version: 0.9.3
• OS Version: Darwin x64 18.7.0
• VSCode version: 1.39.0-insider

⚠️ Make sure to attach this file from your home-directory:
⚠️/Users/ehsan/spywhere.guides-unresponsive.cpuprofile.txt

Find more details here: https://github.com/microsoft/vscode/wiki/Explain-extension-causes-high-cpu-load

Hello

I know about previous ticket ( #1 ) but it was quite a long time ago, so I would like to ask if something has changed?

Is it now possible to fix it and show indent on empty lines?

• Issue Type: Performance
• Extension Name: guides
• Extension Version: 0.9.3
• OS Version: Windows_NT x64 10.0.18932
• VSCode version: 1.38.0-insider

⚠️ Make sure to attach this file from your home-directory:
⚠️C:\Users\hp\spywhere.guides-unresponsive.cpuprofile.txt [spywhere.guides-unresponsive.cpuprofile.txt](https://github.com/spywhere/vscode-guides/files/3514632/spywhere.guides-unresponsive.cpuprofile.txt)

Find more details here: https://github.com/Microsoft/vscode/wiki/Explain:-extension-causes-high-cpu-load

Hi,
when I clicked a node (the nav in the image beneath) the line of its parent is highlighted,
should't be the line highlighted of the clicked div ?

This may not be something you want to do but I'd like to suggest it.

I like to have guidelines at character columns 79 and 120 to help me organise the line-lengths of my code.

Is this something that Guides could add? Or is it already covered by another VSCode plug-in?

For example, in Visual Studio I use “Editor Guidelines” [https://visualstudiogallery.msdn.microsoft.com/da227a0b-0e31-4a11-8f6b-3a149cf2e459].

Some of guide lines are not straight. It may be active of non-active line, as you can see on screenshots below.

There is a question in this closed issue about other extensions installed by user when trouble appears. I test the behavior of Guides with all other extensions disabled but non-correct line rendering appears in this case too.

• Guides Version:0.9.2
• VSCode Version:1.29.1

For some people, displaying all the vertical lines is ugly, but displaying only the active line is really helpful.

Instead of having to implement a new feature (and maintain code later, bugs, vscode changes, and so on...), this feature can be achieved with the current settings easily.

If you feel that it could be useful for people, adding the settings example in the readme (or a gif file) should be enough. If not interesting, just close the issue, no problem, I'll document it in personal storage because to me it is really nice.

settings.json in vscode:

{
  "guides.active.color.dark": "rgba(100, 100, 100, 0.5)",
  "guides.normal.enabled": false,
  "guides.stack.enabled": false,
}

Example:

As far as I've been able to checkout, I haven't seen an option for this. It would be a great clear, subtle way to comprehend the code geography of a particular line of code. There is rainbow indent, but it's too distracting during times when you aren't concerned about code geography.

It would be nice if the position of the currently active line (or all lines for that matter, but I don't use the other ones) could be customized. Currently, the line is always drawn on the left side of the spaces / tab. I'd really like to have it displayed on the right side instead, as seen in the middle of this image:

Maybe this is more common dev knowledge than I have or something but I'm not entirely clear on the differences between active, stacked, and normal. Also, I don't seem to be seeing any real changes to my guides no matter what I do to my settings.

The extension always highlights the containing block of the line you're on.

But when the caret is right after the opening or right before the closing of an instruction block (brackets, parenthesis, etc.), I think it should consider being "inside" of the instruction block, thus highlighting the next indentation level instead.

This could also apply to multiline function calls, array declarations, etc. to easily find the boundaries of these.

The current behavior:

The guide that should be highlighted instead:

Does this sound logical, and is it feasible ?

If i have a code bracket with blank lines in it for code separation and readability the guides lines have holes in them. I did not see an option to span across blank lines. Can you please add that. Also explain what rulers are.

besides that. Great Extension

Unindented comment lines break code scope recognition. It is actual for different languages, e.g. Python or Java.

• I have search open issues for duplicate issues
• I have search close issues for potential fixes
• Guides Version: 0.9.1
• VSCode Version: 1.20.1
• OS Version: Windows 7 and 10

Steps to Reproduce:

1. Add comment line without any indentation to the middle of some scope, so that this comment split scope's code on two parts.
2. Set cursor to the first (before comment) or second (after comment) part of the scope's code.

Actual Behaviour:

Expected Behaviour:

• [x ] I have search open issues for duplicate issues
• [x ] I have search close issues for potential fixes
• Guides Version: 0.9.1
• VSCode Version: 1.2.1
• OS Version: Windows 10

Here's a peek at what my editor looks like:

Is it possible to have the little expanding boxes rendered next to the indent they're at instead at the edge of the screen?

I also don't see the active guide styling mentioned in the settings. It is turned on though. That should mean whatever bracket I'm in get's styled a certain way right?

Here is a slice of a Chromium timeline of me typing around 15 characters in https://github.com/sourcelair/xterm.js/blob/master/src/xterm.js

Might not be worth fixing this is vscode's getting native guides though.

• Issue Type: Bug
• Extension Name: guides
• Extension Version: 0.9.3
• OS Version: Darwin x64 18.2.0
• VSCode version: 1.33.1

⚠️ We have written the needed data into your clipboard. Please paste! ⚠️

• Issue Type: Performance
• Extension Name: guides
• Extension Version: 0.9.3
• OS Version: Windows_NT x64 10.0.17134
• VSCode version: 1.31.1

⚠️ Make sure to attach this file from your home-directory: C:\Users\Asya\spywhere.guides-unresponsive.cpuprofile.txt ⚠️

Find more details here: https://github.com/Microsoft/vscode/wiki/Explain:-extension-causes-high-cpu-load

• I have search open issues for duplicate issues
• I have search close issues for potential fixes
• Guides Version: 0.9.1
• VSCode Version: 1.22.1
• OS Version: OSX 10.12.6

Steps to Reproduce:
I only want to see active lines, i.e. the lines on the block where my cursor is. I set these options in my user settings.

"guides.active.enabled": true,
"guides.normal.enabled": false,
"guides.overrideDefault": true,

Actual Behaviour:
I still get all of the lines.

Expected Behaviour:
I only expected to see the active lines when I was on a block. IOW, in this screen shot, I expected only the red "active" line to show. That is the behavior I am looking for. Are the above settings not how to accomplish it?

From our error telemetry:

TypeError: Cannot read property 'document' of undefined
at Guides.updateEditor (/home/a123/.vscode-insiders/extensions/spywhere.guides-0.0.3/out/src/extension.js:71:41)
at GuidesController.updateEditor (/home/a123/.vscode-insiders/extensions/spywhere.guides-0.0.3/out/src/extension.js:23:21)
at e.invoke (/usr/share/code-insiders/resources/app/out/vs/workbench/node/pluginHostProcess.js:7:14035)
at e.fire (/usr/share/code-insiders/resources/app/out/vs/workbench/node/pluginHostProcess.js:7:15488)
at e._acceptActiveEditorAndVisibleEditors (/usr/share/code-insiders/resources/app/out/vs/workbench/node/pluginHostProcess.js:19:7974)
at e._acceptTextEditorRemove (/usr/share/code-insiders/resources/app/out/vs/workbench/node/pluginHostProcess.js:19:8379)
at t.e.handle (/usr/share/code-insiders/resources/app/out/vs/workbench/node/pluginHostProcess.js:15:12687)
at c (/usr/share/code-insiders/resources/app/out/vs/workbench/node/pluginHostProcess.js:11:16222)
at h (/usr/share/co

• Issue Type: Bug
• Extension Name: guides
• Extension Version: 0.9.3
• OS Version: Windows_NT x64 10.0.19042
• VS Code version: 1.56.2

⚠️ We have written the needed data into your clipboard. Please paste! ⚠️

Hi,

I'm somehow a sucker for leaving white space on my code, mainly blank lines in my code to make it easier to read and follow. The thing is that those new lines are not highlighted. Something like this:

function myFunc(){

|  // some code here then a blank line

|  var a = 0:
|  var b = 1;

|  return a+b;

}

Happens in all file extensions I've checked so far, but the normal behaviour from vs code actually renders those blank lines correctly. Like this:

function myFunc(){
|
|  // some code here then a blank line
|
|  var a = 0:
|  var b = 1;
|
|  return a+b;
|
}

• I have search open issues for duplicate issues
• I have search close issues for potential fixes
• Guides Version:
• VSCode Version:
• OS Version:

Steps to Reproduce:

1. Install extension
2. Get warning message

Actual Behaviour:
"Guides extension has detected that you are using "editor.renderIndentGuides" settings. Guides will now disable all indentation guides by override the style to "none"."

Expected Behaviour:
Work properly after you install extension

• Guides Version: 0.8.3
• VSCode Version: 1.13.1
• OS Version: Mac OS 10.12.5

As you can see below the active gutter icon that points left is cut off. Can you please fix this? Thanks!

• Issue Type: Bug
• Extension Name: guides
• Extension Version: 0.9.3
• OS Version: Windows_NT x64 10.0.18363
• VSCode version: 1.41.1

⚠️ We have written the needed data into your clipboard. Please paste! ⚠️

It's much easier to notice the brackets area, while there is a projection on gutter. Here some exaples how it might look like.

or