GoogleConnectionFactory#extractProviderUserId returns null about spring-social-google HOT 5 CLOSED

The above code has been integrated into the project.
Thanks @Gorbas

from spring-social-google.

I don't think this is correct. User id is not the same as username. The username can change whereas the user id cannot. This will be a problem if you are planning to store the data keyed by the user id.

The above code also causes the Connection.getKey().getProviderUserId() to return different values depending on what scopes you have requested. If you don't have the https://www.googleapis.com/auth/userinfo.email scope getUsername() will return null and the default initialization sequence will take place instead (see below).

The code should work without implementing extractProviderUserId() since the user id will by default be initialized in AbstractConnection.initKey()

from spring-social-google.

@boberj's comment is correct - Connecton.getKey().getProviderUserId() does indeed return different values depending on the requested scope. That makes it very difficult to use the API out of the box and expect consistent results. Is there a way around this behavior?

from spring-social-google.

Ping? This is a pretty big issue for us and our use of this library. I'd hope getProviderUserId() could return the numerical user id as described by @azpublic in #41 ?

from spring-social-google.

I worked around this as follows:

Google google = (Google)connection.getApi();
String uid = google.userOperations().getUserInfo().getId();

from spring-social-google.