Code Monkey home page Code Monkey logo

Comments (12)

amontenegro avatar amontenegro commented on June 21, 2024 2

@amontenegro I have the same concern. A cursory look through the code leads me to believe that the sign-on functionality is not handled via OAuth or plus.me api/scopes, but rather OAuth2: GoogleOAuth2Template. For what its worth, I just disabled the Google+ API in our projects Google API dashboard and sign-on is still working.

Having said that, I'm not certain that sign-on will be unaffected by the Google+ API shutdown. It would be nice to get a confirmation from someone on the dev team.

Hi @n1zea144, you are right, sign in was handled by oauth2, however, profile info was fetched from google+ endpoints, so, at the end, I extended the GoogleTemplate so I fetch the user info (name + email) from https://www.googleapis.com/oauth2/v2/userinfo using OAuth2Operations.getUserinfo();

You can take a look at this PR:

https://github.com/ORCID/ORCID-Source/pull/5187/files#diff-23ff651cfe8bb56c3f5d74e4baf86f41R7

from spring-social-google.

amontenegro avatar amontenegro commented on June 21, 2024

I have the same question, at least for google signin, is the google+ sunset going to affect google sign in?

from spring-social-google.

msinansahin avatar msinansahin commented on June 21, 2024

It is mentioned in this link https://developers.google.com/+/api-shutdown that REST API will be closed.
https://developers.google.com/+/web/api/rest/ link contains links used in org.springframework.social.google.api.plus.impl.PlusTemplate class.

As far as I see, consequently It has to be updated.

from spring-social-google.

mlaccetti avatar mlaccetti commented on June 21, 2024

I suspect it'd have to be changed to use the GSuite style auth.

from spring-social-google.

PawelJagus avatar PawelJagus commented on June 21, 2024

The same question here. Will there be any update to support migration from Google Plus SignIn to Google SignIn?

from spring-social-google.

felix-zaslavskiy avatar felix-zaslavskiy commented on June 21, 2024

The People API seems to return Work history etc.., Seems like a valuable update to get that code released.

from spring-social-google.

n1zea144 avatar n1zea144 commented on June 21, 2024

@amontenegro I have the same concern. A cursory look through the code leads me to believe that the sign-on functionality is not handled via OAuth or plus.me api/scopes, but rather OAuth2: GoogleOAuth2Template. For what its worth, I just disabled the Google+ API in our projects Google API dashboard and sign-on is still working.

Having said that, I'm not certain that sign-on will be unaffected by the Google+ API shutdown. It would be nice to get a confirmation from someone on the dev team.

from spring-social-google.

n1zea144 avatar n1zea144 commented on June 21, 2024

Thanks @amontenegro for the patch! I noticed there has not been any activity in the primary spring-social-google repos in over a year. Do you have any plans to make a PR back to it? Of course we can and will grab your changes directly from the ORCID repos.

from spring-social-google.

PawelJagus avatar PawelJagus commented on June 21, 2024

For what its worth, I just disabled the Google+ API in our projects Google API dashboard and sign-on is still working.

Yeah... I did the same and it was working for... one day more. Better to check your app on a daily basis because they announced they would switch it off step by step up to March the 7th.

from spring-social-google.

felix-zaslavskiy avatar felix-zaslavskiy commented on June 21, 2024

I created pull request to update the People API so same data can be retrieved that was previously done via Google + API. Hope some maintainer notices.

from spring-social-google.

mjacksonlgh avatar mjacksonlgh commented on June 21, 2024

just fyi - I disabled Google+ for our spring-social-google 1.0.0 app and the OAuth did indeed fail.

from spring-social-google.

oyvindhorneland avatar oyvindhorneland commented on June 21, 2024

With 1.0.0 I verified that signin failed after I removed the Google Plus API. A simple upgrade to the already released version 1.1.3 (https://mvnrepository.com/artifact/com.github.spring-social/spring-social-google/1.1.3) fixed the signin part.

(Not sure how we missed the 1.1.3 upgrade previously, perhaps due to the group change described in the project README file. Anyway 1.1.3 can sign in without Google Plus API.)

from spring-social-google.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.