Comments (12)
@amontenegro I have the same concern. A cursory look through the code leads me to believe that the sign-on functionality is not handled via OAuth or plus.me api/scopes, but rather OAuth2: GoogleOAuth2Template. For what its worth, I just disabled the Google+ API in our projects Google API dashboard and sign-on is still working.
Having said that, I'm not certain that sign-on will be unaffected by the Google+ API shutdown. It would be nice to get a confirmation from someone on the dev team.
Hi @n1zea144, you are right, sign in was handled by oauth2, however, profile info was fetched from google+ endpoints, so, at the end, I extended the GoogleTemplate
so I fetch the user info (name + email) from https://www.googleapis.com/oauth2/v2/userinfo
using OAuth2Operations.getUserinfo();
You can take a look at this PR:
https://github.com/ORCID/ORCID-Source/pull/5187/files#diff-23ff651cfe8bb56c3f5d74e4baf86f41R7
from spring-social-google.
I have the same question, at least for google signin, is the google+ sunset going to affect google sign in?
from spring-social-google.
It is mentioned in this link https://developers.google.com/+/api-shutdown that REST API will be closed.
https://developers.google.com/+/web/api/rest/ link contains links used in org.springframework.social.google.api.plus.impl.PlusTemplate
class.
As far as I see, consequently It has to be updated.
from spring-social-google.
I suspect it'd have to be changed to use the GSuite style auth.
from spring-social-google.
The same question here. Will there be any update to support migration from Google Plus SignIn to Google SignIn?
from spring-social-google.
The People API seems to return Work history etc.., Seems like a valuable update to get that code released.
from spring-social-google.
@amontenegro I have the same concern. A cursory look through the code leads me to believe that the sign-on functionality is not handled via OAuth or plus.me api/scopes, but rather OAuth2: GoogleOAuth2Template. For what its worth, I just disabled the Google+ API in our projects Google API dashboard and sign-on is still working.
Having said that, I'm not certain that sign-on will be unaffected by the Google+ API shutdown. It would be nice to get a confirmation from someone on the dev team.
from spring-social-google.
Thanks @amontenegro for the patch! I noticed there has not been any activity in the primary spring-social-google repos in over a year. Do you have any plans to make a PR back to it? Of course we can and will grab your changes directly from the ORCID repos.
from spring-social-google.
For what its worth, I just disabled the Google+ API in our projects Google API dashboard and sign-on is still working.
Yeah... I did the same and it was working for... one day more. Better to check your app on a daily basis because they announced they would switch it off step by step up to March the 7th.
from spring-social-google.
I created pull request to update the People API so same data can be retrieved that was previously done via Google + API. Hope some maintainer notices.
from spring-social-google.
just fyi - I disabled Google+ for our spring-social-google 1.0.0 app and the OAuth did indeed fail.
from spring-social-google.
With 1.0.0 I verified that signin failed after I removed the Google Plus API. A simple upgrade to the already released version 1.1.3 (https://mvnrepository.com/artifact/com.github.spring-social/spring-social-google/1.1.3) fixed the signin part.
(Not sure how we missed the 1.1.3 upgrade previously, perhaps due to the group change described in the project README file. Anyway 1.1.3 can sign in without Google Plus API.)
from spring-social-google.
Related Issues (20)
- Get a release out the door! HOT 12
- Is it possible to return drive files in sorted order?
- 1.2.x Release Tracking
- add support for google people api HOT 1
- New release for Maven repository? HOT 1
- Can we have the latest release 1.1.3 deployed to maven central as 1.1.3.RELEASE HOT 1
- Account email null after fetchUserProfile()
- Google Plus Api 'Person' Class Bug HOT 3
- I/O Error Attempted read from closed stream.
- Google OAuth2 Authorization error
- build fails HOT 3
- Add support for download exported files from google docs
- Tag and release from Maven Central HOT 9
- Add field circledByCount on Person.java class
- Photo quality is extremely low
- Asking for refresh_token and dealing with fetching new access_token when it expired HOT 1
- google.plusOperations().getGoogleProfile() throws a 403 exception after successful OAuth2 login HOT 1
- Update Jackson to 2.6+ to be compatible with Spring 4.3.5
- Missing UrlType enum constant WEBSITE
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spring-social-google.