When you are using tax included in price setting, the ShippingTotalManager will subtract tax difference between methods twice, causing wrong calculation in the checkout shipping step.
The problematic line is
var newOrderTotal = orderTotal + this.totalShipmentAmount(newShipmentTotal, oldShipmentTotal) + (newTaxTotal - oldTaxTotal)
If the last part is removed, it works correctly when Store prices are set to include tax (as is usual in EU).

I've had an issue creating some custom validation on my checkout process, because the update service does not update the instance of the class it is acting on. Near this line of code, can see that the flash notice is updated with errors, but the instance @address is still the instance of the address before the service is called.
https://github.com/spree/spree_legacy_frontend/blob/bf44b73278e0efe18806fd3d8d4b343b6efadcd4/app/controllers/spree/addresses_controller.rb#L26

I admit this could be intentional to support a clean state for the @address, but in my case I want the @address with errors, so I've had to make the call and update the reference manually for some reason.

call = update_service.call(address: @address, address_params: address_params)
@address = call.value
if call.success?

This fix 960003e
Should be put in a stable version. 4.4.0 ("stable" release) is broken due to this.

Context

Hello,
The user dropdown menu doesn't show when click on user icon, it only shows empty box (screenshot),
I am running,
Spree 4.4
Spree_backend 4.4.0

Anyone has idea how to fix it? Thank you.

When not logged in, the following steps result in an infinite loop of calls to /registration and /address -

• add any product to the cart
• proceed to the checkout

On the browser, you get the message "This page isn’t workinglocalhost redirected you too many times."

When trying to access /account, application throws error saying it can't find the UsersController. This seems to be an issue with the user controller not being extracted properly from the main app when the legacy frontend was split from the rest of the code during 4.4 release.

in app/helpers/spree/frontend_helper.rb line 11-31

    def logo(image_path = nil, options = {})
      logo_attachment = if defined?(Spree::StoreLogo) && current_store.logo.is_a?(Spree::StoreLogo)
                          current_store.logo.attachment # Spree v5
                        else
                          current_store.logo # Spree 4.x
                        end

      image_path ||= if logo_attachment&.attached? && logo_attachment&.variable?
                       main_app.cdn_image_url(logo_attachment.variant(resize_to_limit: [244, 104]))
                     elsif logo_attachment&.attached? && logo_attachment&.image?
                       main_app.cdn_image_url(logo_attachment)
                     else
                       asset_path('logo/spree_50.png')
                     end

      path = spree.respond_to?(:root_path) ? spree.root_path : main_app.root_path

      link_to path, 'aria-label': current_store.name, method: options[:method] do
        image_tag image_path, alt: current_store.name, title: current_store.name
      end
    end

Change blow this line code:

'''
main_app.cdn_image_url(logo_attachment.variant(resize_to_limit: [244, 104])
'''

Rails 7.1.3 it's works.

If you put your own assets/images/noimage/plp.svg in your project, it will not override the one from this gem, on PRODUCTION (assets:precompile). It works on development.
Sprockets pick up both assets but they put the one from the gem in the asset manifest instead of the one from the app, which should normally have priority.

@wjwitek I'm not sure if all your work is already included in 4.5 versions of gems, but I was testing around with spree_starter and v4.5 legacy frontend (so '4.5' in Gemfile for all the spree gems), and I found this situation:

• choose default language (the one that doesn't have a prefix in the URL)
• go to login page
• now click the globe icon and change the language to a non-default one
• in my case it will redirect to /de-DE/login but that route does not exist

Note that if you switch language somewhere else and then click on the login link, that works fine (/login?locale=de-DE). Same thing also happens with the signup link.
In spree/spree_auth_devise#570 you link to my PR spree/spree_auth_devise#570 - does that mean you have not found another solution to this problem? As my PR itself seems mostly obsolete apart from this issue.

Context

I was trying to simply setup spree frontend with the new headless spree and expected it to be a frictionless process.

Expected Behavior

After copying spree-starter-main and introducing this gem I expected to have a non-buggy shop.

Actual Behavior

It has the bug mentioned in the title.

Possible Fix

So, according to my research, this should only be a matter of a missing preference. I tried following all suggestions mentioned on this SF post but none of them seemed to work.

So, after some extra looking into the source code, my proposed change is to add the preference as a default value on app/models/spree/frontend_configuration.rb. I opened a PR with the proposed change.

Steps to Reproduce

1. Download spree_starter-main.zip from https://github.com/spree/spree_starter/archive/main.zip
2. Cd into the directory and add gem 'spree_frontend' to Gemfile
3. Run rails g spree:frontend:install
4. Run bin/setup

Ideally for me this should provide a non breaking access to localhost:4000.

Your Environment

• Version used: ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [x86_64-linux]
• Gemfile and Gemfile.lock as text in a Gist:
  • Gemfile -> https://gist.github.com/pCosta99/948f43b618840b0c40bff468e32cde7e
  • Gemfile.lock -> https://gist.github.com/pCosta99/7babf978a776bd8b8b1e3ab963b57335
• Any relevant stack traces ("Full trace" preferred):
  https://gist.github.com/pCosta99/595f3549947bcadaa2d86b5740579816 (full)

I've installed this gem in using rails 7; ruby 3. Partial section of my Gemfile:

gem 'spree_frontend'
gem 'jsbundling-rails'

gem 'spree' # core and API
gem 'spree_backend' # Rails admin panel (optional)
gem 'spree_emails' # transactional emails (optional)
gem 'spree_sample' # dummy data like products, taxons, etc
gem 'spree_auth_devise', '~> 4.3' # Devise integration (optional)
gem 'spree_gateway', '~> 3.9' # payment gateways eg. Stripe, Braintree (optional)
gem 'spree_i18n', '~> 5.0' # translation files (optional) 
 
# only needed for MacOS and Ruby 3.0
gem 'sassc', github: 'sass/sassc-ruby', branch: 'master'

After everything was installed, I started the app with bin/dev. When to localhost:3000 and got the error:

Multiple files with the same output path cannot be linked ("flags/4x3/ad.svg")
In "/Users/dev/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/spree_frontend-4.5.0/app/assets/config/spree_frontend_manifest.js" these files were linked:

• /Users/dev/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/spree_frontend-4.5.0/app/assets/images/flags/4x3/ad.svg
• /Users/dev/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/flag-icons-rails-3.4.6.1/app/assets/images/flags/4x3/ad.svg

On investigation spree_frontend has the image ad.svg and there is a gem, flag-icons-rails, is also using the same image name. How to rename?

The version 4.4.0 of this gem is incompatible with Spree Backend 4.4.1 due to javascript issues.

Context

After following all the steps to upgrade Spree to 4.4.0 following the upgrade guide, during the smoke test phase I realized that the javascript from Spree Legacy Frontend had stopped working.

I think this issue is caused because both Spree Legacy Frontend and Spree Backend define Spree.ready in their respective spree.js files in a conflictive way:

• Spree Legacy Frontend: https://github.com/spree/spree_legacy_frontend/blob/v4.4.0/app/assets/javascripts/spree.js#L5
• Spree Backend: https://github.com/spree/spree_backend/blob/v4.4.1/app/assets/javascripts/spree.js#L5

Spree Legacy Frontend v4.4.0 defines Spree.ready adding listeners to page:load and turbolinks:load events (turbo:load in main branch), while Spree Backend defines Spree.ready adding a listeners to spree:load event. Since both functions have the same name and Spree Backend is loaded after Spree Legacy Frontend, Spree.ready gets overwritten in a way that just listens to spree:load, but Spree Legacy Frontend does not know how to handle that.

Expected Behavior

Spree 4.4.x, Spree Legacy Frontend 4.4.x and Spree Backend 4.4.x are compatible.

Possible Fix

Two possible solutions come to my mind:

• I have started exploring renaming the Spree object in Spree Legacy Frontend javascript files as SpreeFrontend. But so far it raises a NameError at lib/spree/frontend/configuration.rb:3:in telling <module:Frontend>: uninitialized constant Spree::Preferences.
• Reworking Spree Legacy Frontend javascript files so that Spree.ready listener also listens to spree:load, although that would imply maintaining a dependency between Spree Legacy Frontend and Spree Backend, which probably makes this less desirable long term.