spreaker / gulp-aws Goto Github PK

Line 30 in index.js throws the error:

            self.push(file);
            ^
ReferenceError: self is not defined

Full context:

        // Check for empty file
        if (file.isNull()) {
            self.push(file);
            return done();
        }

I believe self.push(file) should be this.push(file)

gulp-aws currently claims it only supports streams (index.js, lines 34-38):

        // Only streams supported
        if (file.isBuffer()) {
            this.emit('error', new PluginError(PLUGIN_NAME, new Error('Only streams supported'), { showStack: true }));
            return done();
        }

However none of the functionality seems to be particular to streams. In fact, after commenting out the above lines, the plugin works fine with buffered streams. I suggest removing the above check.

It seems that currently file paths are ignored by gulp-aws, i.e. a file named in assets/app.css will be uploaded to <bucket>/<prefix>/app.css instead of <bucket>/<prefix>/assets/app.css. Whether to include the file path or not when uploading could be made configurable via an option.

When running npm install gulp-aws I can see that it installs [email protected], but I am hitting this old issue: #3. It would be nice to have this package up to date in the npm directory as well please.