spouliot / gendarme Goto Github PK

sealed class Test
{
        class TestEventArgs : EventArgs
        {
                public TestEventArgs (int x)
                {
                        this.X = x;
                }

                public int X { get; private set; }
        }

        event EventHandler<TestEventArgs> TestEvent;

        public Test ()
        {
                TestEvent += (o,e) => Console.WriteLine ("Test: {0}", e.X); // <-------- Gendarme complains about this line

                if (TestEvent != null)
                        TestEvent (this, new TestEventArgs (42));
        }

        static void Main ()
        {
                new Test ();
        }
}

3. DeclareEventsExplicitlyRule

Problem: An event handler was declared without the 'event' keyword
* Severity: High, Confidence: High
* Target:   Test
* Location: System.EventHandler`1<Test/TestEventArgs> Test::<>f__am$cache0

Solution: Add the missing 'event' keyword to your event handler declaration
More info available at: https://github.com/spouliot/gendarme/wiki/Gendarme.Rules.Correctness.DeclareEventsExplicitlyRule(2.10)

public bool MethodAccessException() 
{
    if (aError) {
        Debug (this.GetType().Name, "Some Message");
        return false;
    }

    ....

    if (bError) {
        Debug (this.GetType().Name, "A other Message");
        return false;
    }

    ....
}

    public class GenericClassWithDisposableField<T> : IDisposable
    {
        private IDisposable dataTable;
        public void Dispose()
        {
            dataTable.Dispose();
        }
    }

    [Test]
    public void GenericClass_Disposal()
    {
        AssertRuleSuccess<GenericClassWithDisposableField<Object>>();
    }

int x;
int X {
    get { return x; }
    set { x = value; }
}

using System;

class Test
{
    event EventHandler<EventArgs> TestEvent; // <----- Gendarme complains that add_ and remove_ are never used

    int _i;

    int TestProp {  // <----- Gendarme complains that get_ and set_ are never used
        get { return _i; }
        set { _i = value; }
    }

    int TestProp2 { get; set; } // <----- Gendarme recognizes these as automatically generated

    static void Main ()
    {
        new Test ();
    }
}

2. AvoidUncalledPrivateCodeRule

Problem: This private or internal (assembly-level) member does not have callers in the assembly, is not invoked by the common language runtime, and is not invoked by a delegate.
* Severity: High, Confidence: Normal
* Target:   System.Void Test::add_TestEvent(System.EventHandler`1<System.EventArgs>)
* Details:  The private method code is not used in its declaring type.

Solution: Remove the unused code or add code to call it.
More info available at: https://github.com/spouliot/gendarme/wiki/Gendarme.Rules.Performance.AvoidUncalledPrivateCodeRule(2.10)


3. AvoidUncalledPrivateCodeRule

Problem: This private or internal (assembly-level) member does not have callers in the assembly, is not invoked by the common language runtime, and is not invoked by a delegate. 
* Severity: High, Confidence: Normal
* Target:   System.Void Test::remove_TestEvent(System.EventHandler`1<System.EventArgs>)
* Details:  The private method code is not used in its declaring type.

Solution: Remove the unused code or add code to call it.
More info available at: https://github.com/spouliot/gendarme/wiki/Gendarme.Rules.Performance.AvoidUncalledPrivateCodeRule(2.10)

4. AvoidUncalledPrivateCodeRule

Problem: This private or internal (assembly-level) member does not have callers in the assembly, is not invok
* Severity: High, Confidence: Normal
* Target:   System.Int32 Test::get_TestProp()
* Details:  The private method code is not used in its declaring type.

Solution: Remove the unused code or add code to call it.
More info available at: https://github.com/spouliot/gendarme/wiki/Gendarme.Rules.Performance.AvoidUncalledPri


5. AvoidUncalledPrivateCodeRule

Problem: This private or internal (assembly-level) member does not have callers in the assembly, is not invok
* Severity: High, Confidence: Normal
* Target:   System.Void Test::set_TestProp(System.Int32)
* Details:  The private method code is not used in its declaring type.

Solution: Remove the unused code or add code to call it.
More info available at: https://github.com/spouliot/gendarme/wiki/Gendarme.Rules.Performance.AvoidUncalledPri