spiral / twig-bridge Goto Github PK

@SerafimArts
I assume there should be an actual php 7.4 and 8.0 versions + CI builds for min/max stability also

Currently I can not create a template like base.js.twig or base.html.twig.

It ends up in:

[Twig\Error\SyntaxError] An exception has been thrown during the compilation of a template ("Unable to load view default:base.html, file does not exist.") in "default:base.html". in /tmp/schranz-templating/examples/usages/spiral/vendor/twig/twig/src/Environment.php:521

I did try to adopt the TwigLoader here:

By changing this:

-            \sprintf('%s:%s', $source->getNamespace(), $source->getName()),
+            \sprintf('%s:%s', $source->getNamespace(), $source->getName() . '.twig'),

This way the twig template is rendered. But still not the correct escaper is used.

For example when creating a test.js.twig file:

<script>
    var test = 'test';

    {% set someHtml = '<h1>' ~ title ~ '</h1>' %}

    var test = "{{ someHtml }}";

    alert(test);
</script>

It is not escaped as expected:

Spiral:

Uses still HTML escaper:

Symfony:

Use the JS escaper as expected:

Twig itself or the Twig Environment would be nice to have as a service itself. So other libraries and systems build on top of Twig can easily be used inside Spiral without have to get Twig in hacky way or have two seperate instances of twig

Currently in schranz-templating/templating#40 (comment)

I'm using a very hacky solution to get Twig from this package:

        $container->bindSingleton('twig', function (Container $container) {
            // Use a hack to get Twig from the ViewManager as it is not available as an service yet
            $viewManager = $container->get(ViewManager::class);

            $engines = $viewManager->getEngines();

            $twigEngine = null;
            foreach ($engines as $engine) {
                if ($engine instanceof TwigEngine) {
                    $twigEngine = $engine;
                    break;
                }
            }

            if (null === $twigEngine) {
                throw new \LogicException(
                    \sprintf('Expected "%s" to be registered in the view manager.', TwigEngine::class)
                );
            }

            return $twigEngine->getEnvironment(new ViewContext());
        });