Code Monkey home page Code Monkey logo

Comments (6)

SpikeHimself avatar SpikeHimself commented on May 26, 2024 1

I'm still releasing a new version that includes your request though, as I discovered the "nomap" option only after I already added the functionality :)

As per a90c734 XPortal will hide the ping button if either the "nomap" option is set, or the "PingMapDisabled" option is set on the server.

Aiming to release tonight or tomorrow.

from xportal.

SpikeHimself avatar SpikeHimself commented on May 26, 2024 1

v1.2.5 is now live and includes these features :)

from xportal.

mjn666 avatar mjn666 commented on May 26, 2024 1

You're a star! That's awesome news. Im going to be double sure and set the nomap feature on top of this mod anyway - that was a great tip!

from xportal.

SpikeHimself avatar SpikeHimself commented on May 26, 2024

This makes perfect sense, and I have no idea why I didn't think of this in the first place :)

I found that other mods, for example PlantEverything, use a 3rd party library called "ServerSync" to achieve this behaviour. I've looked into how that works and have decided that I don't want to use it, because: 1. it doubles XPortal's filesize, 2. it's overkill for such a small feature (look at all of this stuff, omg), and 3. it overwrites the client config permanently every time you join a server with different settings.

So instead I'll have to refactor the ping functionality to become a server side feature, so that clients can "request" it. To hide the button, clients have to request the server's setting before opening their UI (or something to that extent).

Sounds feasible to me. I'll see what I can do!

from xportal.

SpikeHimself avatar SpikeHimself commented on May 26, 2024

Did you know, by the way, there is a global setting you can set on the server which disables the use of maps? I'm not sure how you'd set it (I don't run a dedicated server), but it exists, and it's used in Valheim's code that determines what to do with the minimap.

What I am trying to get at, is: Does XPortal let you see the map despite this setting? Because the way it looks is that this does exactly what you're after.

Edit: I've tested this. If you type "nomap" in the console, it will disable the map entirely. This also disables XPortal's ping functionality. The ping button itself remains visible, but I could make it look for the "nomap" value to change that.

from xportal.

mjn666 avatar mjn666 commented on May 26, 2024

Edit: I've tested this. If you type "nomap" in the console, it will disable the map entirely. This also disables XPortal's ping functionality. The ping button itself remains visible, but I could make it look for the "nomap" value to change that.

That's not a bad workaround, didn't think of that! Currently using a MapMod to disable the map but it appears that it just blocks the input for it. Because the ping form XPortal would bring up the map and it would still show the areas that were discovered by the player (opening up the chance to grab screenshots) so killing map server side hopefully remedies this.

Thanks heaps for pointing this out, should hopefully nip this minor issue in the bud - cheers

from xportal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.