Code Monkey home page Code Monkey logo

Comments (3)

SpikeHimself avatar SpikeHimself commented on May 26, 2024

This is not a small addition - it will require rewriting much of how the mod currently does its job. I will spend some time thinking on it.

Some things to consider:

  • This needs to be configurable, because not everyone will want this
  • If you install XPortal for the first time on a world you already have portals on, should they be visible or not?
  • If a portal you have already discovered gets destroyed (by enemies or players), you'd have to build a new one, which then isn't "discovered" anymore. Is that what you want?
  • How many visitors per portal should XPortal remember? Infinite? This is a potential memory hog for servers.
  • Perhaps there is another approach that achieves your goal, maybe something like an access setting (could be similar to Wards?)

from xportal.

JoeSenOne avatar JoeSenOne commented on May 26, 2024

I don't know how your mod is written, but the vanilla portals are looked through every view seconds? if there are many portals on vanilla servers there already is a problem with connection delay.

The Idea of the access setting like with Wards sounds very interesting. But i can see the problems you mentioned, especially with installing the mod after some portals are already placed.
Maybe you can find some solution, its just an idea :)

from xportal.

SpikeHimself avatar SpikeHimself commented on May 26, 2024

the vanilla portals are looked through every view seconds?

Yes, in the unmodded vanilla game, a coroutine that runs roughly every five seconds checks to see if it should connect any portals. XPortal disables that coroutine.

if there are many portals on vanilla servers there already is a problem with connection delay

No, having many portals does not cause a noticeable delay in this behaviour. A moderate server can probably execute this function a few hundred times per second without anyone noticing anything.

Also, my comment was not about that. My comment was about memory: If you must keep a list of all users that have ever interacted with a portal, this could potentially become infinitely large on a dedicated server. It's a potential risk that has to be considered, is all I meant.

Anyway, I don't feel like this modification fits within the scope of XPortal as a mod. Maybe another mod could provide this functionality. If such a mod exists I'd happily work on any compatibility issues that may arise.

I am closing this issue as I will not work on this request. Thank you for supporting XPortal!

from xportal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.