speyedr / socialclub-notification-blocker Goto Github PK

Is your feature request related to a problem? Please describe.
Some users will not be able to understand how to use the program as the menus are currently only displayed in English.
I noticed that several guides or solutions which linked to my program were for communities which do not speak English, and this has made me realise that this program should support translation / allow different languages as GTA Online has communities all around the world which may need to use SCBlocker in the future.

Describe the solution you'd like
Wrapping text that needs to be translated in some sort of class where its' attributes contain said text in different languages. Passing an additional parameter specifying the intended language will then return a string of that text in the requested language.

Automatic translation could be possible, but community-driven translations (especially by those who understand the context of this program) would be best.

Describe alternatives you've considered
Different versions or builds with files translated, however this would be very, very clunky.
Wrapping text in classes would allow the menus to update at run-time, and only one build would be necessary.

Additional context
Guide for this program published by Brazilian (?) YouTuber
Guide for this program published by Russian (?) YouTuber (Note that this person had to use an auto-translator and had difficulty finding the download link.)

Is your feature request related to a problem? Please describe.
Rockstar has a habit of introducing changes, features, or additions to GTA Online that end up breaking several other features.
Let's learn from this and do exactly not that by integrating a testing suite that can ensure filters are working as expected throughout updates and that any changes don't break the program.

Describe the solution you'd like
I'm still not quite sure on what testing suite should be used, but I'll probably go for the default python testing framework, unittest.

Describe alternatives you've considered
Now that this project is going to be relied upon by so many people, manual testing and re-testing of features just isn't an option anymore. Automated testing will help accelerate development and will allow updates to be completed sooner.

Additional context
Several people have reported that the program "just doesn't work", and automated testing may also reveal previously hidden bugs or edge cases that have been affecting those people.

Description
When starting the program, FilterSettings.SERVER_IP attempts to resolve the IP address for the class attribute CLIENT_POST_HOST, which more specifically is the URL prs-gta5-prod.ros.rockstargames.com. This IP address is then used in two PyDivert filters, which can be found here. These initial filters help reduce the load on SCBlocker by allowing any packet which does not match the filter to be immediately let through, as these initial filters have been designed such that any packet which does not match these initial filters would always be allowed through anyways.

If this IP address cannot be resolved, the initial filters could not be constructed as they currently are. However, as there is currently no error handling for the method mentioned above, the program crashes immediately and without any error message, and the error isn't even added to a log file as the crash happens before SCBlocker even reaches main().

Although under normal circumstances this method should never fail, very strict firewalls or attempting to run SCBlocker without an internet connection can trigger this behaviour.

How to reproduce
Steps to reproduce the behavior:

1. Disable your internet connection / block access to prs-gta5-prod.ros.rockstargames.com
2. Run SCBlocker.exe as Administrator
3. Window opens, then closes immediately
4. In order to see the full error message, you need to run SCBlocker.exe from an elevated command prompt.

Screenshots / Debug.log messages

System Information

• Operating System: Windows 8.1
• Program Version: v0.1.1

Additional context
DROP_INC_80 will still work even if SERVER_IP cannot be resolved.
The program could keep attempting to resolve SERVER_IP until it is successful.
The IP that is resolved seems to be static and within R* / T2 IP-space, so an alternative would be to set the filters to use a regex (I think Guardian 3.0 did this?) instead of the 1 IP address.

Adding a read me for people who're not that good with computer things, and translation of this. (I can help for the French traduction).

I can even do a video for the read me if needed.

LMK if interested, I can give you my discord!

Please add the ability to toggle the filter using a configurable hotkey or any other method that we can automate (like calling a command-line argument or using an API).
Also would be nice to have some feedback on the success of the toggle, like a sound, for example.

Is your feature request related to a problem? Please describe.
The last time I touched presence events, we were using it to get people banned back when GTA V first came out. IIRC, there's a field inside the packet that should be relevant to the SCID of the offender. With this, you should be able to filter the two chads doing this. This might lead to a cat-and-mouse game between you and the attackers trying to scramble to create/reject SCIDs, but it should be a nice stop-gap until Rockstar stops dilating over Shark Cards and fixes this fucking issue.

Describe the solution you'd like
Filter the SCID of this balls guy.

Describe alternatives you've considered
Echs dee.

Additional context
Post POST requests.

Description
A clear and concise description of what the bug is.

How to reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Screenshots / Debug.log messages
Pasting messages from your debug.log file can help provide important context for the crash.

System Information

• Operating System: [Windows 8.1, Windows 10, Windows 11]
• Program Version: [v0.1]

Additional context
Add any other context about the problem here.

Is your feature request related to a problem? Please describe.
Grand Theft Auto V runs under Wine / Proton; and invite-spamming is a problem over there too.

Describe the solution you'd like
Since this program is written in Python, I think it can be updated to support Linux as well.

Describe alternatives you've considered
Running this Python script under Wine fails because it requires UAC, which Wine doesn't have. Even if it worked past that, it couldn't filter anything out because Wine programs don't have the required permissions nor APIs exposed to them to do network filtering.

Additional context
Not applicable.

Description
when we start it as admin (v0.1.1),and the filter is on .we are still be forced into others sessions

How to reproduce
we are forced into other session what ever sessions we're in

System Information
Windows 11、Windows 10

• Program Version: [v0.1.1]

reproduce about 16 hours ago,many players encounter this issues