sped0n / bridget Goto Github PK

Is your feature request related to a problem? Please describe.
Now navigate bar index value is empty and will cause layout shift when we load the data into it.

Describe the solution you'd like
Use same method in single.json to extract image array length.

Describe alternatives you've considered
Or just fill zeros into it

Additional context
Add any other context or screenshots about the feature request here.

Requirement

Allow for navigating between pictures with the arrow keys after expanding them.

Suggested implements

Addition details

No response

Verify steps

• Pull request is welcome. Check this if you want to start a pull request
• I have searched on Issue Tracker, No duplicate or related open issue has been found
• Ensure there is only one feature request in this issue. Please make mutiply issue for mutiply feature request

Is your feature request related to a problem? Please describe.
If connection speed is limited, user might get a plain white background with no indicator and response while image is loading. Actually I think there is something wrong with the code when I first met this issue.

Describe the solution you'd like

• mobile: a center div with text
• desktop: not sure yet

Describe alternatives you've considered
n/a

Additional context
n/a

Describe the bug
In mobile view, if you scroll up and down in gallery, the images in collection will move as well, this is not intended behavior.

To Reproduce
In mobile view, scroll up and down in gallery.

Expected behavior
Collection should not be affected by scrolling in gallery.

Screenshots
n/a

Environment (please complete the following information):
n/a

Additional context
n/a

Describe the bug
In expand view, some image will keep loading.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

• OS: [e.g. macOS]
• Browser [e.g. chrome, safari]
• Hugo Version [e.g. v0.114.0 extended]

Additional context
Seems to related to the new preload logic

Requirement

Apart from the already included web analytics services, I think it might also be worth adding GoatCounter

Suggested implements

Having GoatCounter analytics with bridget will help a lot to those who are starting out.

[analytics.goatcounter]
code = "goatcounter_code"

Addition details

No response

Verify steps

• Pull request is welcome. Check this if you want to start a pull request
• I have searched on Issue Tracker, No duplicate or related open issue has been found
• Ensure there is only one feature request in this issue. Please make mutiply issue for mutiply feature request

Step to reproduce

n/a

Expected behaviour

n/a

Actual Behaviour

n/a

Logs

n/a

Addition details

transfer from #347

Hugo version

n/a

Bridget version

n/a

OS version

n/a

Verify steps

• Pull request is welcome. Check this if you want to start a pull request
• I have searched on Issue Tracker, No duplicate or related open issue has been found
• Ensure there is only one bug report in this issue. Please make mutiply issue for mutiply bugs

Hello I am getting some errors when I am trying to install the theme.

`Start building sites …
hugo v0.120.4-f11bca5fec2ebb3a02727fb2a5cfb08da96fd9df+extended darwin/arm64 BuildDate=2023-11-08T11:18:07Z VendorInfo=brew

ERROR render of "page" failed: execute of template failed: template: _default/single.html:4:45: executing "main$htmltemplate_stateHTMLCmt" at <{{template "main$htmltemplate_stateHTMLCmt" .}}>: exceeded maximum template depth (100000)
ERROR render: failed to render pages: render of "page" failed: execute of template failed: template: _default/single.html:4:45: executing "main$htmltemplate_stateHTMLCmt" at <{{template "main$htmltemplate_stateHTMLCmt" .}}>: exceeded maximum template depth (100000)
Built in 135 ms
Error: error building site: TOCSS: failed to transform "scss/style.scss" (text/x-scss): "/Users/macstudio/hugo/quick/themes/bridget/assets/scss/style.scss:10:1": File to import not found or unreadable: node_modules/swiper/swiper.scss.`

I have tried to install Swiper with NPM but it still does not work. What could be going wrong?

I have also made a thread on the Hugo forum.

https://discourse.gohugo.io/t/error-building-site-tocss-failed-to-transform-scss-style-scss-text-x-scss/47210

Any help would be appreciated as this is an awesome theme!

Is your feature request related to a problem? Please describe.
it seems bundled option bother some users, like #169, set a default value might be a better option.

Describe the solution you'd like
use hugo default syntax

Describe alternatives you've considered
n/a

Additional context
quite busy with intern work and the end of semester, will push this when I got some time.

Step to reproduce

1. hugo new site sitename
2. cd sitename
3. git init
4. git submodule add https://github.com/Sped0n/bridget themes/bridget
5. Remove hugo.toml from project root
6. Copy config folder from exampleSite to project root
7. Set theme config as follows:

# theme as module
[module]
replacements = "github.com/Sped0n/bridget/v2 -> themes/bridget" # deploy with local dir  WARN: delete this line if you want to deploy with git
[[module.imports]]
path = "github.com/Sped0n/bridget/v2" # deploy with git (recommended)  WARN: you should also set `bundled` to true in params.toml !!!

8. mkdir ./content/Info
9. Write the default index.md headings to index.md in the Info folder.
10. hugo serve

Expected behaviour

Build a site, idk what else to say?

Actual Behaviour

Logs

Watching for changes in /home/deadbeef/Documents/tomtakesphotos.com/{archetypes,assets,content,data,i18n,layouts,static}
Watching for config changes in /home/deadbeef/Documents/tomtakesphotos.com/hugo.toml, /home/deadbeef/Documents/tomtakesphotos.com/config/_default
Start building sites … 
hugo v0.132.2-3fd26c70dff5934ec1802b9563530130ed1bca75+extended linux/amd64 BuildDate=2024-08-14T16:17:21Z VendorInfo=gohugoio

WARN  found no layout file for "html" for kind "page": You should create a template file which matches Hugo Layouts Lookup Rules for this combination.
WARN  found no layout file for "json" for kind "page": You should create a template file which matches Hugo Layouts Lookup Rules for this combination.

                   | EN  
-------------------+-----
  Pages            |  2  
  Paginator pages  |  0  
  Non-page files   |  0  
  Static files     |  0  
  Processed images |  0  
  Aliases          |  0  
  Cleaned          |  0  

Built in 5 ms

Addition details

No response

Hugo version

v0.132.2 (extended)

Bridget version

v2.0.3

OS version

Linux Mint and Debian

Verify steps

• Pull request is welcome. Check this if you want to start a pull request
• I have searched on Issue Tracker, No duplicate or related open issue has been found
• Ensure there is only one bug report in this issue. Please make mutiply issue for mutiply bugs

Requirement

Given I have used this template to create a website. When I include EXIF images within the /content location outlined within the template. Then the template is unable to reorient each image to display correctly with EXIF orientation tag

Suggested implements

I recommend implementing something similar to discussion here: #363 (reply in thread)

Addition details

No response

Verify steps

• Pull request is welcome. Check this if you want to start a pull request
• I have searched on Issue Tracker, No duplicate or related open issue has been found
• Ensure there is only one feature request in this issue. Please make mutiply issue for mutiply feature request

Is your feature request related to a problem? Please describe.
n/a

Describe the solution you'd like
getStarted.md

Describe alternatives you've considered
n/a

Additional context
n/a

Is your feature request related to a problem? Please describe.
No, that is a new feature.

Describe alternatives you've considered
The theme is awesome, like... emm..True Art! As the feature, is there any way to show exif information as alt after zoom in the photo. The behaviour just like the way of star information showing in Stellarium.

Thank you very much!

Hi @Sped0n I just want to say thanks for launching this project and making it open-sourced. This is a beautiful theme and I'm thinking of using this for my GH Page. Great work! Much respect 🙏

Is your feature request related to a problem? Please describe.
og + twitter card

Describe the solution you'd like
ref from DoIt and hugo-theme-fuji

Describe alternatives you've considered
n/a

Additional context
quite busy with intern work and the end of semester, will push this when I got some time.

Is your feature request related to a problem? Please describe.
flashing when hires image finish loading

Describe the solution you'd like
CSS opacity transition

Describe alternatives you've considered
n/a

Additional context
n/a

Step to reproduce

1. Version of Hugo: hugo v0.128.2-de36c1a95d28595d8243fd8b891665b069ed0850+extended linux/arm64 BuildDate=2024-07-04T08:13:25Z VendorInfo=gohugoio
2. hugo new site blablabla
3. Follow git documentation here
4. Copy all .toml files from exampleSite to site root
5. Edit hugo.toml to have replacements = "github.com/Sped0n/bridget/v2 -> ../.." to [...] -> bridget (because it seems like hugo adds theme/ by default now
6. Go back to site root and execute hugo

Expected behaviour

Site builds correctly

Actual Behaviour

Building fails because of a menu variable called in HTML that is either empty or not defined somewhere

Logs

root@anubis:/var/www/photography# hugo -D
Start building sites …
hugo v0.128.2-de36c1a95d28595d8243fd8b891665b069ed0850+extended linux/arm64 BuildDate=2024-07-04T08:13:25Z VendorInfo=gohugoio

Total in 121 ms
Error: error building site: render: failed to render pages: render of "404" failed: "/var/www/photography/themes/bridget/layouts/404.html:3:8": execute of template failed: template: 404.html:3:8: executing "main" at <partial "nav.html" .>: error calling partial: "/var/www/photography/themes/bridget/layouts/partials/nav.html:12:16": execute of template failed: template: partials/nav.html:12:16: executing "partials/nav.html" at <len $menus>: error calling len: reflect: call of reflect.Value.Type on zero Value

Addition details

No response

Hugo version

hugo v0.128.2-de36c1a95d28595d8243fd8b891665b069ed0850+extended

Bridget version

latest

OS version

Ubuntu Server 24.04 LTS

Verify steps

• Pull request is welcome. Check this if you want to start a pull request
• I have searched on Issue Tracker, No duplicate or related open issue has been found
• Ensure there is only one bug report in this issue. Please make mutiply issue for mutiply bugs

Step to reproduce

In Windows Chrome or Firefox, clicking a thumbnail portfolio image produces a .js error in the console. This is true of the demo and one running locally on my computer.

Expected behaviour

A higher res. version of the the photo is expected. The touch event works as expected on Android Chrome however.

Actual Behaviour

Logs

No response

Addition details

I don't think I have the skills to fix this, although AI tells me that "You might be trying to call slideTo before the slider library (like Swiper.js, Slick, or others) has finished setting up the slider object."

Hugo version

hugo v0.127.0

Bridget version

v2.0.2

OS version

Windows 11

Verify steps

• Pull request is welcome. Check this if you want to start a pull request
• I have searched on Issue Tracker, No duplicate or related open issue has been found
• Ensure there is only one bug report in this issue. Please make mutiply issue for mutiply bugs