spacetoastcoasttocoast / express-gallery Goto Github PK

Seems that body-parser and your custom middleware called validation is not used. Consider removing them.

https://github.com/SpaceToastCoastToCoast/express-gallery/blob/master/routes/gallery.js#L3-L4

one example: https://github.com/SpaceToastCoastToCoast/express-gallery/blob/master/views/edit.pug#L1

you can omit the .pug extension

Find and replace throughout project, Thanks!

When I navigate to the image detail page (http://localhost:7000/gallery/1), I get this error on the server:

🚯

https://github.com/SpaceToastCoastToCoast/express-gallery/blob/master/middleware/authentication.js#L8-L19

you can omit the .js when using require('...')

npm i
npm i -g gulp
sequelize db:seed:all
gulp

PROFIT!

I like breaking up my SCSS file into partials that correspond with a page - it makes your code more modular and scalable.

Consider adding a footer or at the very least some space at the bottom of the page. Currently the bottom of the page feels a little cramped.

i.e. email (isEmail) - required, isUnique etc

For more info, check out this link:

http://docs.sequelizejs.com/en/latest/docs/models-definition/#validations

Move the routes logic into seperate routes directory.

Unnecessary Template Literal:
https://github.com/SpaceToastCoastToCoast/express-gallery/blob/master/views/new.pug#L6

Use ID Literal feature:
https://github.com/SpaceToastCoastToCoast/express-gallery/blob/master/views/layout.pug#L9
https://github.com/SpaceToastCoastToCoast/express-gallery/blob/master/views/gallery.pug#L13

Use Class Literal feature:
https://github.com/SpaceToastCoastToCoast/express-gallery/blob/master/views/404.pug#L9

Use HTML Entity code for spaces  :
https://github.com/SpaceToastCoastToCoast/express-gallery/blob/master/views/photo.pug#L22
https://github.com/SpaceToastCoastToCoast/express-gallery/blob/master/views/photo.pug#L7

Remove <br> usage and replace with styling via CSS file:
https://github.com/SpaceToastCoastToCoast/express-gallery/blob/master/views/new.pug#L17-L18

You need to make all CRUD operations functional from the browser

Currently, after adding a new image and returning back to the index page you will notice that the most recently added image appears near the bottom of the list.

Consider changing it so that the new additions appear first (at top of section).

In the image below, the trump image is the new addition, notice how it appears last:

STR:

1. Log in as a user
2. Go through the steps to create a new user
3. Submit the reques

Notice that you are shown the JSON response. User should be redirected to either the photo listing page or to the details page for the newly created image.

current response detail:

{
"success": true
}

If you need users to do things for the seed file to work - either document it or automate it

Make it easy for users to clone your repo and get setup - give them a sample file they can file in to get setup quickly

i.e /gallery/aksjdkalsjdkalsjdlakjs does not return 404