Extend Django ErrorModel about error-tracker HOT 11 CLOSED

Hi Alan
Not sure, If I understand your question correctly. If you want to use custom model than you need to implement all abstract methods.

Please see the default one

https://github.com/sonus21/error-tracker/blob/master/error_tracker/django/models.py

from error-tracker.

from error-tracker.

Got it, the current error_tracker Django model is swappable that means you can extend this model with your custom one and swap with that something like this.

from error_tracker.django.models import ErrorModel
class MyErrorModel(ErrorModel):
 # add your code here

Now you should set APP_ERROR_DB_MODEL in settings.py like we do for User model.

from error-tracker.

Yes, I did that early but this is what I get:

monitoring.MyErrorModel.errormodel_ptr: (fields.E301) Field defines a relation with the model 'error_tracker.ErrorModel', which has been swapped out.
	HINT: Update the relation to point at 'settings.APP_ERROR_DB_MODEL'.

from error-tracker.

Can you please share the MyErrorModel class definition? It seems you're using ForeignKey to track similar error via self reference.

from error-tracker.

I am not. I tried a lot of things already.

from error_tracker.django.models import ErrorModel
class MyErrorModel(ErrorModel):
   pass

On setttings.py:
APP_ERROR_DB_MODEL = 'monitoring.MyErrorModel'

from error-tracker.

It seems you can't extend model directly, we need to make ErrorModel as Abstract, this change has been done, i'll release this shortly via d699840

from error-tracker.

Thank you, Sonu!

from error-tracker.

Thank you, Sonu. I am able to extend it now using your last revision. If you allow me I want to give you three suggestions:

1. You are setting the db_name in the Meta options, if someone wants to reuse the model into their app they will probably expect the table to have the name as 'myapp_mymodelname' instead of 'exceptions'. Of course, if you update the documentation telling to include into their Meta options db_table = None this will be OK.

2. Maybe some of the people needs to explicitly have a id as PK in their models, in this case they will add the id field and declare the hash field without the primary_key attribute, my case due distributed databases. In this case they will get an error because when you seek for a entry into the exceptions table you are using pk field, instead of hash:
   return cls.objects.get(pk=rhash)
   Instead of:
   return cls.objects.get(hash=rhash)
   Not sure how about this in Flask.

3. Options to see the Exception table as a admin page.

If you want I can do a pull request with the item 2 and 3 so you can see it.

from error-tracker.

Hi Alan

• Point 1 makes sense
• Point 2 can break compatibility, your idea seems fine.
• Point 3 can be done easily via admin.py file [But I think the developer can register their own model via admin.py ]

from error-tracker.

Version 2.0.0 has been released, it has the changes for point 1 and 2. I'm closing this issue, please open it if you see.

from error-tracker.