sonatard / noctx Goto Github PK

Currently, SSA is not working with generics.

So your linter produces a panic when it is used with generics.

There is an issue open about that in the Go repository: golang/go#48525

Inside golangci-lint, we disabled your linters: golangci/golangci-lint#2649

You have 2 solutions:

• waiting for a version of SSA that will support generics
• dropping the SSA analyzers and using something else to analyze the code.

Related to golang/go#50558

As described in the docs, http.NewRequest uses the context.Background context which is supposed to be used in tests according to the docs. Therefore, it is cleaner to use http.NewContext in tests where we make HTTP requests against test servers.

Therefore, I think the linter should allow the usage of http.NewRequest, http.Get, http.Header and all similar functions in tests because it's the recommended way and provides much simpler code than having to explicitly use http.NewRequestWithContext with context.Background each time.

Hi 🙂

Please, bump golang.org/x/tools to v0.7.0 (as minimum) and make new tag in your repo.

It's important to be consistent with new Go 1.20 golangci-lint.
Related to golangci/golangci-lint#3086

Thanks!

P.S. Optionally I recommend

• to move linter to 1.20 totally (go.mod, CI, etc.)
• add support of dependabot

// Sending an HTTP request and accepting context
func SendWithContext(ctx context.Context, body io.Reader) error {
    // Change NewRequest to NewRequestWithContext and pass context it
    req, err := http.NewRequestWithContext(ctx, http.MethodPost, "http://example.com", body)
    if err != nil {
        return nil
    }

You are returning nil on error
It`s small mistake but someone can copy this code

Thank you for the wonderful linter.

This linter seems to be mainly net/http, but is it out of scope to issue a warning to methods that use database/sql without context.Context?

type key struct{}
req, _ := http.NewRequest("POST", "", nil)
req = req.WithContext(context.WithValue(req.Context(), key{}, 0))

noctx raises this error:

should rewrite http.NewRequestWithContext or add (*Request).WithContext (noctx)
                        req, _ := http.NewRequest("POST", "", nil)
                                                 ^

I'm always interested how to improve my code, but this one is a bit irritating to me. Maybe I'm wrong in doing so, but it seems like detection is too strict here.

In my API client, I have a helper function to abstract creating the basic request. Usually I then add headers or other stuff afterwards, before executing the request.

func (a *Api) NewApiRequest(method string, path string, body io.Reader) (req *http.Request, err error) {
	req, err = http.NewRequestWithContext(a.Context, method, a.BaseURL+path, body)
	if err != nil {
		return
	}

	req.SetBasicAuth(a.Username, a.Password)

	return
}

Now when using the function, noctx complains:

	req, err := a.NewApiRequest("POST", "/upload", nil) // should rewrite http.NewRequestWithContext or add (*Request).WithContext (noctx)
	if err != nil {
		return fmt.Errorf("could not create request: %w", err)
	}

    // Adding more to the request

	data, err := a.RequestApi(req, http.StatusCreated)
	if err != nil {
		return fmt.Errorf("could not create upload: %w", err)
	}

What do you think about it? For now I just ignored noctx here.