somniastellarum / cpacademygoserver Goto Github PK

Currently, when the server starts up, it starts scanning from the same starting block each time, which causes it to react to events it already processed on any previous run of the program.

A solution would be to simply store the last block scanned in ethReadLoop to a file, and load this upon startup to pass to the "go ethReadLoop(4200000)" line in main.go.

To reproduce, start the server and create a Toastytrade by interacting with the ToastytradeFactory contract directly. This part should correctly fire a notification if you have an email registered for the address you used as the Seller when creating a Toastytrade. Then, perform another action with the Toastytrade, such as recoverFunds or commit: ethReadLoop says it's scanning each range, but it won't seem to notice an event that really does occur.

The BurnablePayment contract doesn't actually do any processing when the autorelease becomes available to the worker; the only thing that makes it "available" is that the require condition in triggerAutorelease "require(now >= autoreleaseTime)" will pass.

Because there is no processing, and no event triggered, the server currently has no way of knowing when this happens. This is unfortunate from a user experience perspective; a Buyer has an obvious interest in knowing that he can trigger the autorelease. A related feature would be to send out notifications when the autorelease is "coming soon"; this has utility for the Seller.

This isn't exactly trivial to set up though. The server would need to perform the above mentioned condition manually. Also, as things are currently written, there is an assumption that each notification originates from an event... Adding this feature violates that assumption, which means something will have to be rebuilt (for example, the "notifyParties" function takes an address and an event, but here there is no event).