soloschenko-grigoriy / gamedev-patterns-ts Goto Github PK

Since index=0 evaluates as false, the last element will never be removed in _components.

should be:

if (toRemove && index !== undefined) {

See: joaqim@e84cbd0
Where I also added test that would fail without this fix.

I suspect that changes have been made since the guide was initially put up, I've checked (and double checked), but this unit test no longer succeeds (indeed, it didn't succeed at all for me be that before or after fixing false positives/negatives fixes).

Making the changes below:

Fixes the problem as now the simulated mouse click is done on the document as a whole and not body. I suspect that changes in how MouseEvents are handled (calling preventDefault unless specifically told not to on elements) to be the main issue. It was of course a necessary change to support many click functionalities of todays browsers. Now I could of course have made an EventHandler which disables preventDefault, but this was the quick and dirty solution.

In Game Loop Part 2 of your tutorial neglects to mention the following in the game

        public Awake(): void{
        //Components
        this.AddComponents(new GameInputComponents())

        super.Awake()
        
        //Child entities
        for(const entity of this.Entities){
            entity.Awake()
        }

        window.requestAnimationFrame(() => {
            this._lastTimeStamp = Date.now()
            this.Update()
        })

       // Remove
       this.Update()
      // Remove
    } 

Not removing the this.update() from your Awake() method in game.ts causes the mockImplementation to continuously do a range out of bounds as it is, essentially a forever loop.

Cheers for the guide tho! I've only done Game Dev in Unity and.. This is much more hands on.

Was loving the tutorial so far, but it ends in the pathfinding part.

Are you planning in continuing it?