sokom141 / battleship Goto Github PK

All images should be resized to 32*32px

We should investigate if removing the enhanced switch in favor of the classic switch is enough for the game to be compiled and played using JDK 11 - the latest LTS version.

This is a game-breaking bug.
If the user doesn't set an image before playing (required only once) the connection will close immediatly

We can support different themes with the Java Look and Feel.
The user should be able to select the theme on the Settings menu and save his/her preferences.

Describe the bug
In settings dialog there is a button to choose an user image. This button has no label and is not descriptive enough for the end user.

To Reproduce
Steps to reproduce the behavior:

1. Start BattleShip application
2. Click on 'Settings'
3. Scroll down to 'User Image'
4. Button has no label

Expected behavior
Button should be labeled with a description, for example 'Choose...' or 'Open an image...'.

Optional: The second dialog with title 'Image Chooser' is redundant and should be removed.
Optional: Choosen image is scaled and showed between label 'User Image' and the button

Screenshots

Desktop (please complete the following information):

• OS: [Elementary OS/Ubuntu]
• Java Version: 14
• Software Version: [v.0.0.1]

This bug is easily reproducible by placing all but one ship and the activating the MouseListener without placing the last one.

The culprit is the cose inside ShipPlanner line 159 :
if (comboBoxItemCount == 1) { buttonOk.setEnabled(true); }

Right before winning the game, if the last ShipUnit is hitted the background color of the clicked button doesn't change to the color set to indicate an hit.

Implementing a "random" placement button on ShipPlanner would be a nice addition.

The button should be placed alongside others and work nicely with the already working buttons.

It would be interesting to add a single player mode so you can play by yourself.

The game title on the game should reflect the version of the game designed on the maven file