sobotklp / django-throttle-requests Goto Github PK

View Code? Open in Web Editor NEW

52.0 52.0 9.0 113 KB

a framework for implementing application-level request throttling for Django

License: MIT License

Python 100.00%

django python rate-limiting

django-throttle-requests's People

Contributors

Stargazers

Watchers

Forkers

user52 getanewsletter amjithuv saurabhv1 edelvalle ebsaral yolocodefrench alimp5 pulsedemon

django-throttle-requests's Issues

Adding throttle to INSTALLED APPS in settings.py

Instead of adding throttle to my python path, would adding throttle to INSTALLED APPS work too?

NUM_BUCKETS not clearly documented

Try as I might, I can't seem to wrap my head around what this config value is exactly and the docs don't explain it (or the others for that matter, but I've managed to figure those out I think). Any chance of getting a description?

BUCKET_INTERVAL is half of what's set in settings.py

@sobotklp I'm testing the following:


THROTTLE_ZONES = {
    'default': {
        'VARY':'throttle.zones.RemoteIP',
        'NUM_BUCKETS':2,  # Number of buckets worth of history to keep. Must be at least 2
        'BUCKET_INTERVAL':10,  # Period of time to enforce limits.
        'BUCKET_CAPACITY':2,  # Maximum number of requests allowed within BUCKET_INTERVAL
    },
}

The above allows me 2 requests in every 5 seconds instead of 10. Have you seen this behavior too?

pip install django-throttle-requests fails

doesn't seem to be in the pip list of packages.

Does the decorater (@throttle(zone='default')) support Django's Class-Based Views?

How does the decorator work on Django's class base views?

Need a better response when limit happened

Not just a 403 page, need some where to add a descrption text config to show on the 403 page.

throttle.exceptions.RateLimitExceeded: default

When we reached to limit. your app tries to show a 403 forbidden page.

django 3.2
python 3.8

I'm using default configs. but i got error below:

Forbidden (Permission denied): /books/hello/
Traceback (most recent call last):
  File "C:\Users\linux10\Desktop\my_all_envs\azimzadeh_env1\lib\site-packages\django\core\handlers\exception.py", line 47, in inner
    response = get_response(request)
  File "C:\Users\linux10\Desktop\my_all_envs\azimzadeh_env1\lib\site-packages\django\core\handlers\base.py", line 181, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "C:\Users\linux10\Desktop\my_all_envs\azimzadeh_env1\lib\site-packages\django\views\decorators\csrf.py", line 54, in wrapped_view
    return view_func(*args, **kwargs)
  File "C:\Users\linux10\Desktop\my_all_envs\azimzadeh_env1\lib\site-packages\django\views\generic\base.py", line 70, in view
    return self.dispatch(request, *args, **kwargs)
  File "C:\Users\linux10\Desktop\my_all_envs\azimzadeh_env1\lib\site-packages\django\utils\decorators.py", line 43, in _wrapper
    return bound_method(*args, **kwargs)
  File "C:\Users\linux10\Desktop\my_all_envs\azimzadeh_env1\lib\site-packages\throttle\decorators.py", line 15, in _wrapped_view
    response = _throttle_zone.process_view(request, func, args, kwargs)
  File "C:\Users\linux10\Desktop\my_all_envs\azimzadeh_env1\lib\site-packages\throttle\zones\__init__.py", line 72, in process_view
    raise RateLimitExceeded(self.name)
throttle.exceptions.RateLimitExceeded: default
[16/May/2021 15:54:03] "GET /books/hello/ HTTP/1.1" 403 200

CRITICAL: files of pypi are not the same as in github !!!

In the archive from pypi the file throttle/zone/__init__.py at line 65, reads

bucket_num_next = (bucket_num + 1) % 2

where as in github it is:

bucket_num_next = (bucket_num + 1) % self.num_buckets

Of course this leads to unexpected results !!!

Release on pypi

Hey,
Could you release the most recent version on pypi, please?
Regards :)

Django 3 compatibility: available_attrs not available

available_attrs was removed in Django 3.

Thus, this package doesn't work:

  File "/home/rain0r/.virtualenvs/urlsh/lib/python3.7/site-packages/throttle/decorators.py", line 2, in <module>
    from django.utils.decorators import available_attrs
ImportError: cannot import name 'available_attrs' from 'django.utils.decorators' (/home/rain0r/.virtualenvs/urlsh/lib/python3.7/site-packages/django/utils/decorators.py)

Memcached can't take key with the spaces.

When using the default RemoteIp handler you can catch the following exception:
ip = "100.200.300.400, 101.201.301.401"
With this ip you catch the following exception:
MemcachedKeyCharacterError: Control/space characters not allowed (key=':1:key:100.200.300.400, 101.201.301.401:0')

Regarding dynamically changing BUCKET_INTERVAL according to the request

Hi @sobotklp is there a possibility that we can change the value of BUCKET_INTERVAL for every request. Need to use rate limit based upon the value of an object stored in database?