Code Monkey home page Code Monkey logo

grappling-hook's People

Contributors

dannegm avatar snowgears avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

grappling-hook's Issues

Client crash; "corrupts" playerdata file

Haven't had time to really look into the source code (and also just finding the fishing rod to be severely lacking as a grappling hook due to its semi-short range), but it seems to corrupt the player/set an invalid velocity, causing the player and any other players (in range?) to be kicked from the server (and any time he attempts to join thereafter, until his playerdata file is deleted) with the following message in the client (server just reports "disconnected"):

error1

Seems the maximum size varies (this is when attempting to grapple again - I thought perhaps it was something to do with the water).

error2

As for client - using 1.12 (had forge and optifine loaded, but no other mods; I hardly use forge and when I do, it's for a camera recording mod). Server is using paper 1.12 and used to have no issues on 1.11.2 and etc. Some things of note are ProtocolSupport, though I've had that on before this plugin arrived, so /shrug

Suggestion: Add /gh reload

Can you please add a /gh reload to reload the configs live, so there is no need to reboot a production server just for some simple config changes. (plugman is not something anyone should use in prod)

Add levitation with the grapple

Hello my players are using your grappling hook and are very happy with it.

But I would like to ask you if my idea is possible to realize.
When we descend with the grappling hook we have a slow fall effect.
But I wondered if once at the limit of the rope of the fishing rod we could not remain levitating above the ground instead of falling to the ground?
Thank's in advance.

Server crash

[05:07:04] [Watchdog Thread/ERROR]: The server has stopped responding! This is (probably) not a Purpur bug.
[05:07:04] [Watchdog Thread/ERROR]: If you see a plugin in the Server thread dump below, then please report it to that author
[05:07:04] [Watchdog Thread/ERROR]: 	 *Especially* if it looks like HTTP or MySQL operations are occurring
[05:07:04] [Watchdog Thread/ERROR]: If you see a world save or edit, then it means you did far more than your server can handle at once
[05:07:04] [Watchdog Thread/ERROR]: 	 If this is the case, consider increasing timeout-time in spigot.yml but note that this will replace the crash with LARGE lag spikes
[05:07:04] [Watchdog Thread/ERROR]: If you are unsure or still think this is a Purpur bug, please report this to https://github.com/PurpurMC/Purpur/issues
[05:07:04] [Watchdog Thread/ERROR]: Be sure to include ALL relevant console errors and Minecraft crash reports
[05:07:04] [Watchdog Thread/ERROR]: Purpur version: git-Purpur-1985 (MC: 1.19.4)
[05:07:04] [Watchdog Thread/ERROR]: ------------------------------
[05:07:04] [Watchdog Thread/ERROR]: During the run of the server, a plugin set an excessive velocity on an entity
[05:07:04] [Watchdog Thread/ERROR]: This may be the cause of the issue, or it may be entirely unrelated
[05:07:04] [Watchdog Thread/ERROR]: Excessive velocity set detected: tried to set velocity of entity PiercingLunarYT id #23594727 to (1.834981134538408,-0.5358406250445569,5.598930759070626).
[05:07:04] [Watchdog Thread/ERROR]: 		org.bukkit.craftbukkit.v1_19_R3.entity.CraftEntity.setVelocity(CraftEntity.java:481)
[05:07:04] [Watchdog Thread/ERROR]: 		GrapplingHook-1.6.5.jar//com.snowgears.grapplinghook.GrapplingListener.pullPlayerSlightly(GrapplingListener.java:472)
[05:07:04] [Watchdog Thread/ERROR]: 		GrapplingHook-1.6.5.jar//com.snowgears.grapplinghook.GrapplingListener.onGrapple(GrapplingListener.java:160)
[05:07:04] [Watchdog Thread/ERROR]: 		com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor975.execute(Unknown Source)
[05:07:04] [Watchdog Thread/ERROR]: 		org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:77)
[05:07:04] [Watchdog Thread/ERROR]: 		co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:77)
[05:07:04] [Watchdog Thread/ERROR]: 		org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70)
[05:07:04] [Watchdog Thread/ERROR]: 		io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:54)
[05:07:04] [Watchdog Thread/ERROR]: 		io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:126)
[05:07:04] [Watchdog Thread/ERROR]: 		org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:617)
[05:07:04] [Watchdog Thread/ERROR]: 		GrapplingHook-1.6.5.jar//com.snowgears.grapplinghook.GrapplingListener.fishEvent(GrapplingListener.java:315)
[05:07:04] [Watchdog Thread/ERROR]: 		com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor976.execute(Unknown Source)
[05:07:04] [Watchdog Thread/ERROR]: 		org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:77)
[05:07:04] [Watchdog Thread/ERROR]: 		co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:77)
[05:07:04] [Watchdog Thread/ERROR]: 		org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70)
[05:07:04] [Watchdog Thread/ERROR]: 		io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:54)
[05:07:04] [Watchdog Thread/ERROR]: 		io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:126)
[05:07:04] [Watchdog Thread/ERROR]: 		org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:617)
[05:07:04] [Watchdog Thread/ERROR]: 		net.minecraft.world.entity.projectile.FishingHook.retrieve(FishingHook.java:549)
[05:07:04] [Watchdog Thread/ERROR]: 		net.minecraft.world.item.FishingRodItem.use(FishingRodItem.java:32)
[05:07:04] [Watchdog Thread/ERROR]: 		net.minecraft.world.item.ItemStack.use(ItemStack.java:531)
[05:07:04] [Watchdog Thread/ERROR]: 		net.minecraft.server.level.ServerPlayerGameMode.useItem(ServerPlayerGameMode.java:481)
[05:07:04] [Watchdog Thread/ERROR]: 		net.minecraft.server.network.ServerGamePacketListenerImpl.handleUseItem(ServerGamePacketListenerImpl.java:2122)
[05:07:04] [Watchdog Thread/ERROR]: 		net.minecraft.network.protocol.game.ServerboundUseItemPacket.handle(ServerboundUseItemPacket.java:32)
[05:07:04] [Watchdog Thread/ERROR]: 		net.minecraft.network.protocol.game.ServerboundUseItemPacket.a(ServerboundUseItemPacket.java:8)
[05:07:04] [Watchdog Thread/ERROR]: 		net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$0(PacketUtils.java:51)
[05:07:04] [Watchdog Thread/ERROR]: 		net.minecraft.server.TickTask.run(TickTask.java:18)
[05:07:04] [Watchdog Thread/ERROR]: 		net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:153)
[05:07:04] [Watchdog Thread/ERROR]: 		net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24)
[05:07:04] [Watchdog Thread/ERROR]: 		net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1369)
[05:07:04] [Watchdog Thread/ERROR]: 		net.minecraft.server.MinecraftServer.d(MinecraftServer.java:197)
[05:07:04] [Watchdog Thread/ERROR]: 		net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:126)
[05:07:04] [Watchdog Thread/ERROR]: 		net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1346)
[05:07:04] [Watchdog Thread/ERROR]: 		net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1339)
[05:07:04] [Watchdog Thread/ERROR]: 		net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:136)
[05:07:04] [Watchdog Thread/ERROR]: 		net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1317)
[05:07:04] [Watchdog Thread/ERROR]: 		net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1205)
[05:07:04] [Watchdog Thread/ERROR]: 		net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:325)
[05:07:04] [Watchdog Thread/ERROR]: 		java.base/java.lang.Thread.run(Thread.java:840)
[05:07:04] [Watchdog Thread/ERROR]: ------------------------------
[05:07:04] [Watchdog Thread/ERROR]: Server thread dump (Look for plugins here before reporting to Purpur!):
[05:07:04] [Watchdog Thread/ERROR]: Ticking entity: minecraft:player, entity class: net.minecraft.server.level.EntityPlayer
[05:07:04] [Watchdog Thread/ERROR]: Entity status: removed: false, valid: true, alive: true, is passenger: false
[05:07:04] [Watchdog Thread/ERROR]: Entity UUID: c42ca95f-6369-42ea-923f-1ffcfcdfa4b9
[05:07:04] [Watchdog Thread/ERROR]: Position: world: 'world' at location (18.63852837917859, 77.0, -64.6913280387645)
[05:07:04] [Watchdog Thread/ERROR]: Velocity: (0.0, 0.0, 0.0) (in blocks per tick)
[05:07:04] [Watchdog Thread/ERROR]: Entity AABB: AABB[18.338528367257663, 77.0, -64.99132805068542] -> [18.93852839109952, 78.5, -64.39132802684357]
[05:07:04] [Watchdog Thread/ERROR]: Total packets processed on the main thread for all players: 7860230
[05:07:04] [Watchdog Thread/ERROR]: ------------------------------```

Paper compatibility

I'm using paper instead of spigot, and got this error:
[15:24:12] [Server thread/INFO]: [GrapplingHook] Enabling GrapplingHook v1.5.9*
[15:24:13] [Server thread/WARN]: java.lang.Throwable: Warning: A plugin is creating a recipe using a Deprecated method. This will cause you to receive warnings stating 'Tried to load unrecognized recipe: bukkit:'. Please ask the author to give their recipe a static key using NamespacedKey.
[15:24:13] [Server thread/WARN]: at org.bukkit.inventory.ShapedRecipe.(ShapedRecipe.java:28)
[15:24:13] [Server thread/WARN]: at com.snowgears.grapplinghook.GrapplingHook.onEnable(GrapplingHook.java:69)
[15:24:13] [Server thread/WARN]: at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:263)
[15:24:13] [Server thread/WARN]: at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:380)
[15:24:13] [Server thread/WARN]: at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:483)
[15:24:13] [Server thread/WARN]: at org.bukkit.craftbukkit.v1_16_R2.CraftServer.enablePlugin(CraftServer.java:501)
[15:24:13] [Server thread/WARN]: at org.bukkit.craftbukkit.v1_16_R2.CraftServer.enablePlugins(CraftServer.java:415)
[15:24:13] [Server thread/WARN]: at net.minecraft.server.v1_16_R2.MinecraftServer.loadWorld(MinecraftServer.java:468)
[15:24:13] [Server thread/WARN]: at net.minecraft.server.v1_16_R2.DedicatedServer.init(DedicatedServer.java:237)
[15:24:13] [Server thread/WARN]: at net.minecraft.server.v1_16_R2.MinecraftServer.w(MinecraftServer.java:939)
[15:24:13] [Server thread/WARN]: at net.minecraft.server.v1_16_R2.MinecraftServer.lambda$a$0(MinecraftServer.java:177)
[15:24:13] [Server thread/WARN]: at java.lang.Thread.run(Unknown Source)

and I really love this plugin :(

Error when loading v1.6.3

[08:30:34 INFO]: [GrapplingHook] Enabling GrapplingHook v1.6.3
[08:30:34 INFO]: [GrapplingHook] [STDOUT] [GrapplingHook] Loaded 6 recipes.
[08:30:34 WARN]: Nag author(s): '[SnowGears]' of 'GrapplingHook' about their usage of System.out/err.print. Please use your plugin's logger instead (JavaPlugin#getLogger).
[08:30:34 ERROR]: Error occurred while enabling GrapplingHook v1.6.3 (Is it up to date?)
java.lang.NoClassDefFoundError: org/bstats/bukkit/Metrics
at com.snowgears.grapplinghook.GrapplingHook.onEnable(GrapplingHook.java:66) ~[original-GrapplingHook-1.6.3.jar:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:264) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:?]
at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:370) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:?]
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:542) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:?]
at org.bukkit.craftbukkit.v1_19_R1.CraftServer.enablePlugin(CraftServer.java:565) ~[paper-1.19.2.jar:git-Paper-196]
at org.bukkit.craftbukkit.v1_19_R1.CraftServer.enablePlugins(CraftServer.java:479) ~[paper-1.19.2.jar:git-Paper-196]
at net.minecraft.server.MinecraftServer.loadWorld0(MinecraftServer.java:636) ~[paper-1.19.2.jar:git-Paper-196]
at net.minecraft.server.MinecraftServer.loadLevel(MinecraftServer.java:422) ~[paper-1.19.2.jar:git-Paper-196]
at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:306) ~[paper-1.19.2.jar:git-Paper-196]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1100) ~[paper-1.19.2.jar:git-Paper-196]
at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:305) ~[paper-1.19.2.jar:git-Paper-196]
at java.lang.Thread.run(Thread.java:833) ~[?:?]
Caused by: java.lang.ClassNotFoundException: org.bstats.bukkit.Metrics
at org.bukkit.plugin.java.PluginClassLoader.loadClass0(PluginClassLoader.java:177) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:?]
at org.bukkit.plugin.java.PluginClassLoader.loadClass(PluginClassLoader.java:124) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:?]
at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]
... 12 more
[08:30:34 INFO]: [GrapplingHook] Disabling GrapplingHook v1.6.3

Recipes are getting when I change them

The recipes are getting reset when I change them. After that the plugin doesn't work and when I do /gh is says there was an internal error. I am on paper 1.18.1.

This is the error I got:

06.03 13:45:33 [Server] INFO TheCrafter8000 issued server command: /gh
06.03 13:45:33 [Server] ERROR null
06.03 13:45:33 [Server] INFO org.bukkit.command.CommandException: Cannot execute command 'gh' in plugin GrapplingHook v1.6.2 - plugin is disabled.
06.03 13:45:33 [Server] INFO at org.bukkit.command.PluginCommand.execute(PluginCommand.java:37) ~[paper-api-1.18.1-R0.1-SNAPSHOT.jar:?]
06.03 13:45:33 [Server] INFO at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:159) ~[paper-api-1.18.1-R0.1-SNAPSHOT.jar:?]
06.03 13:45:33 [Server] INFO at org.bukkit.craftbukkit.v1_18_R1.CraftServer.dispatchCommand(CraftServer.java:907) ~[paper-1.18.1.jar:git-Paper-"f5b9e07"]
06.03 13:45:33 [Server] INFO at net.minecraft.server.network.ServerGamePacketListenerImpl.handleCommand(ServerGamePacketListenerImpl.java:2289) ~[?:?]
06.03 13:45:33 [Server] INFO at net.minecraft.server.network.ServerGamePacketListenerImpl.handleChat(ServerGamePacketListenerImpl.java:2100) ~[?:?]
06.03 13:45:33 [Server] INFO at net.minecraft.server.network.ServerGamePacketListenerImpl.handleChat(ServerGamePacketListenerImpl.java:2081) ~[?:?]
06.03 13:45:33 [Server] INFO at net.minecraft.network.protocol.game.ServerboundChatPacket.handle(ServerboundChatPacket.java:46) ~[?:?]
06.03 13:45:33 [Server] INFO at net.minecraft.network.protocol.game.ServerboundChatPacket.a(ServerboundChatPacket.java:6) ~[?:?]
06.03 13:45:33 [Server] INFO at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$1(PacketUtils.java:56) ~[?:?]
06.03 13:45:33 [Server] INFO at net.minecraft.server.TickTask.run(TickTask.java:18) ~[paper-1.18.1.jar:git-Paper-"f5b9e07"]
06.03 13:45:33 [Server] INFO at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:149) ~[?:?]
06.03 13:45:33 [Server] INFO at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:23) ~[?:?]
06.03 13:45:33 [Server] INFO at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1413) ~[paper-1.18.1.jar:git-Paper-"f5b9e07"]
06.03 13:45:33 [Server] INFO at net.minecraft.server.MinecraftServer.c(MinecraftServer.java:189) ~[paper-1.18.1.jar:git-Paper-"f5b9e07"]
06.03 13:45:33 [Server] INFO at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:122) ~[?:?]
06.03 13:45:33 [Server] INFO at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1391) ~[paper-1.18.1.jar:git-Paper-"f5b9e07"]
06.03 13:45:33 [Server] INFO at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1384) ~[paper-1.18.1.jar:git-Paper-"f5b9e07"]
06.03 13:45:36 [Server] INFO at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:132) ~[?:?]
06.03 13:45:36 [Server] INFO at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1462) ~[paper-1.18.1.jar:git-Paper-"f5b9e07"]
06.03 13:45:36 [Server] INFO at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1264) ~[paper-1.18.1.jar:git-Paper-"f5b9e07"]
06.03 13:45:36 [Server] INFO at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:317) ~[paper-1.18.1.jar:git-Paper-"f5b9e07"]
06.03 13:45:36 [Server] INFO at java.lang.Thread.run(Thread.java:831) ~[?:?]

Enhancement: Worldguard support

A nice enhancement that might be worth considering is Worldguard support so players cannot grapple other players' ambient mobs.

Issue: /gh is doing nothing on my survival but works on my creative?

When using /gh there is no feedback anyway, but when using /gh GodsDead 25 on my cretive it works, but on my surival it does nothing! I have no idea if there is an error or permission error as there is no feedback at all, not in-game not in console, just blank. I have no idea why its not working on my survival.

Suggestion: Add Water Hook

Add the option for the Grapppling Hook for sticking to Water and to enable/disable it per Grappling Hook.

System.out/err.print

Got this in console after startup:
[09:00:01] [Server thread/WARN]: Nag author(s): '[SnowGears]' of 'GrapplingHook' about their usage of System.out/err.print. Please use your plugin's logger instead (JavaPlugin#getLogger).

Log: https://mclo.gs/FWiqRsk

Config reloader won't allow new recipes to be added in recipes.yml

Hey there,
since the 1.16 brings a new ore the Netherite Ingot, which is quite hard to farm i thought about a possible new grappling hook with a lot more usability than diamond (default) or even unlimited durability.

I would like to ask you if you want to implement this into the Plugin?

Kind regards
DerLinkman

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.