Code Monkey home page Code Monkey logo

cozytea's Introduction

๐Ÿ‘‹ Hi, I'm Steve Vandenburg

I'm a Dad, Defender, DJ, and Developer. As a Full-Stack Developer I've built projects using React, NodeJS, TypeScript, PostgreSQL, MongoDB and Python. I have extensive project management experience across enterprises large and small. From public companies to startups I've worked with cross-functional teams to deliver security and technology projects timely and on budget.

๐ŸŒŸ Why I'm a Developer

My driving factor to be a developer is CLEAR. So what is CLEAR?

  • Craftsmanship
  • Leverage
  • Enjoyment
  • Attack Big Problems
  • Remote Work

Read more about it here

โ˜• Connect with Me

cozytea's People

Contributors

smv5047 avatar

Watchers

 avatar

cozytea's Issues

HTML and Structure

Your HTML enables the proper use of flexbox, and your structure reflects the grouping and flow of content in the browser. Good job!

Layout

While the layout of your page closely resembles the design specification, there are discrepancies in every section.

You did well in creating a sticky header, but when you scroll down your page, there is a gap between the top of the header and the viewport:
image
Because you've assigned a z-index of 1 to the header and to the mission statement, the header gets lost behind it when scrolling:
image
Although difficult to see, there is an 8px margin applied to the <body> of your page as a default styling from the browser. Because the header is styled with an underline, you may notice this gap on the left side. If you inspect your page through DevTools, you'll find the styling:
image
In Unit 5, you'll learn to add a reset stylesheet to clear out all of the browser default styling. For this project, if you target the <body> element and set the margin to 0 you'll be able to clear out the default margin around the page, which will also fix the gap above the header. If you only needed to correct that gap, without adjusting the rest of the margin on the body, you can use top: 0 because the header is position: fixed.

Once you scroll down the page, you'll notice that the logo image isn't centered vertically in the header. Good job getting the 10px of separation between the logo and the left side of the viewport (once the margin is cleared out). I encourage you to consider implicit styling and balance in design when building your page. This 10px will be seen in a few other places on this page. Try setting the amount of space between the last link in the navigation and the right side of the viewport to 10px, instead of 20px, to balance what is explicitly set in the redline document. I think you'll find that this more closely resembles the design mock.

The width of the Mission section is explicitly set to 1200px in the redline document:
image
Although not explicitly set, it appears that the Locations section should also be 1200px in width. You can center both of these sections on the page by setting the margin to auto.

In the Featured Tea section, the names of the teas should be 10px from the bottom of the image, per the design specification:
image
Default styling of the <h4> here has added a 29.26px margin applied, which you can see through DevTools:
image
Likewise, the <h2> of the Locations section should be 15px from the top of the address card below, but default styling applied by the browser adds a margin of 27.39px:
image
image

This amount of space between the bottom of the Locations section and the start of the contact information isn't explicitly set, but if we again consider balance in our design and try to replace the default 27.39px margin with 10px like we saw before, I think we will find it more closely matches the design specification.

Rubric and Summary

Rubric Score

Criteria 1: HTML Structure

  • Score Level: 4/4
  • Comment(s): HTML implementation enables proper use of flexbox.

HTML structure reflects the grouping and flow of content in the web browser.

Criteria 2: Visual Layout

  • Score Level: 1/4
  • Comment(s): Layout does not match the design spec in any section.

(This includes a sticky header w/ no gap between it and top of viewport )

Criteria 3: Use of Flexbox

  • Score Level: 2/4
  • Comment(s): Flexbox properties are incorrectly applied to 1+ flex containers or flex items.

Flexbox is used properly in 1-4 sections and is the primary way of positioning.

Criteria 4: Implementation of Design Specification and Content

  • Score Level: 4/4
  • Comment(s): The page includes all style and content provided in the design specification.

(For example, anchor colors match the design spec.)

Overall Score: 11/16

Your project Meets Expectations - nice job! Good use of comments in your HTML to help keep your code organized. You could include additional comments in your CSS to help keep it as easy to read as the HTML. Try utilizing more semantic elements in your HTML to further improve readability and accessibility. You are not required to make any changes to this project or resubmit, but I do encourage you try to work out some of the issues highlighted to further your understanding of the concepts. My hope is that this higher attention to detail will help you improve the quality of your future projects in this course and beyond.
Here's a reference for semantic elements:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element
Here's an article about semantics and accessibility:
https://24ways.org/2017/accessibility-through-semantic-html/
Lastly, here's my favorite resource for Flexbox:
https://css-tricks.com/snippets/css/a-guide-to-flexbox/
Keep up the good work, and happy coding!

Flexbox

Flexbox properties are applied incorrectly to 1+ flex containers or items. Flexbox is used properly in 1-4 sections and is the primary way of positioning. Much like I used DevTools to compare your layout with the design specification, I used it to look at the way Flexbox was applied throughout the page. By toggling styling off and on, we can immediately see changes to the page in the browser. In this case, there appears to be superfluous styling applied that is not affecting the layout of the elements on the page.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.