Code Monkey home page Code Monkey logo

patient-browser's People

Contributors

bhinebaugh avatar dependabot[bot] avatar dtphelan1 avatar sringuette avatar vlad-ignatov avatar volsch avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

patient-browser's Issues

npm install failing due to webpack dependency issues

How to reproduce: Clone repo an run 'npm install' .

Build starts fine but eventually runs into error (below). I tried to fix it by manually installing webpack-cli but that unfortunaltly lead to a whole new series of dependency problems seemingly having to do with breaking changes between different versions of webpack.

Error log:

Hash: 275a5cf5779a3513888b
Version: webpack 2.7.0
Time: 24709ms
                              Asset       Size  Chunks                    Chunk Names
                           index.js     156 kB       0  [emitted]         index
                         commons.js     577 kB       1  [emitted]  [big]  vendor
  index.js.275a5cf5779a3513888b.map     851 kB       0  [emitted]         index
commons.js.275a5cf5779a3513888b.map    4.57 MB       1  [emitted]         vendor
                      ..\index.html  938 bytes          [emitted]
Webpack Bundle Analyzer saved report to [...]\patient-browser\build\js\report.html
The CLI moved into a separate package: webpack-cli
Please install 'webpack-cli' in addition to webpack itself to use the CLI
-> When using npm: npm i -D webpack-cli
-> When using yarn: yarn add -D webpack-cli
internal/modules/cjs/loader.js:796
    throw err;
    ^

Error: Cannot find module 'webpack-cli/bin/config-yargs'
Require stack:
- [...]\patient-browser\node_modules\webpack-dev-server\bin\webpack-dev-server.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:793:17)
    at Function.Module._load (internal/modules/cjs/loader.js:686:27)
    at Module.require (internal/modules/cjs/loader.js:848:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> ([...]\patient-browser\node_modules\webpack-dev-server\bin\webpack-dev-server.js:84:1)
    at Module._compile (internal/modules/cjs/loader.js:955:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:991:10)
    at Module.load (internal/modules/cjs/loader.js:811:32)
    at Function.Module._load (internal/modules/cjs/loader.js:723:14)
    at Function.Module.runMain (internal/modules/cjs/loader.js:1043:10) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '[...]\\patient-browser\\node_modules\\webpack-dev-server\\bin\\webpack-dev-server.js'
  ]
}
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] build:dev: `npm run clean && webpack --hide-modules && webpack-dev-server`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] build:dev script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     [...]\AppData\Roaming\npm-cache\_logs\2021-01-25T16_11_04_194Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] build: `if-env NODE_ENV=production && npm run build:prod || npm run build:dev`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     [...]\AppData\Roaming\npm-cache\_logs\2021-01-25T16_11_04_254Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] postinstall: `npm run build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     [...]\AppData\Roaming\npm-cache\_logs\2021-01-25T16_11_04_351Z-debug.log

Routes like `/patient/:index` aren't stable when dataset changes

Hello,

I'm playing around with the demo and looking at the implementation. One thing I've notices is that you're using index-based URLs to display patient-details. This is problematic when the underlying dataset changes.

  1. I search for "von" and click on the third patient in the result
  2. I get redirected to /patient/2
  3. Another Patient with "von" in its name is added
  4. At some later point, I reload the page. I may or may not see a different patient's details because the new patient may or may appear in the search results before the patient I was originally looking at.

A solution would be changing your routing to link to /patient/:id where :id is Patient.id.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.