Comments (5)
Alright, so as this is an edge case (package.json changed, leading to a change for the dev server) we'll exclude it. This implies that changes to the package.json that affect the build (e.g., change of the "app" path) would require a fixed restart. I guess this is a good trade-off, as such scenarios rarely occur and often are expected to come with a manual server restart anyway.
The server would still restart on changes to the krasrc; as it might re-configure the server in crucial areas.
from piral.
The server would restart multiple times on changes to the krasrc. version: 1.5.4-beta.6998
This is also an edge case. This happens when app-shell's webpack.config.js configures a longer build.
But it no longer affects normal development. Thanks for the quick fix.
from piral.
The content of the files package.json/.krasrc monitored by fs.watch has not changed, and the server has been restarted.
I don't understand this - the repro steps listen explicitly that the package.json should be modified - so yes, with such a modification the server should restart.
I'll have a look with the repro steps, but a server restart is expected if certain files changed (otherwise you'd need to manually shut down the server and restart it again).
from piral.
The server would restart multiple times on changes to the krasrc.
version: 1.5.4-beta.6998
from piral.
Hm these two are not connected; also I have not seen this myself. I guess we can close it unless you can come up with a reproducible.
from piral.
Related Issues (20)
- On Invalid Config Pilet Publish Removes Source
- The index.d.ts of a Pilet Is Placed In dist
- Improve Toggle / Disable+Enable in Debug Tools
- Optional Shadow DOM Isolation HOT 1
- PiletApi's `once` throws when `this` context is `undefined` HOT 6
- This is Evil
- Piral with Rush HOT 16
- How do I configure this with Nuxt 3? Unable to setup HOT 4
- Remove Pilet-Only Settings When Debugging Piral Instance
- In the app-shell example debugging mode, saving package.json will prompt that the port is used HOT 6
- Navigation storm in angular pilets HOT 1
- Multiple Angular Extensions params HOT 4
- piral-ng: Cannot read properties of null (reading 'bindingStartIndex') HOT 3
- piral-breadcrumbs dependency on react-router v5 HOT 3
- Piral-Cli uses deprecated package HOT 2
- Possibility to Define Vue 3 Plugins HOT 15
- Support Standalone Bootstrapping API in piral-ng HOT 1
- `.krasrc` resolution from `process.cwd()` folder HOT 5
- Install Event Listener Earlier
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from piral.