Code Monkey home page Code Monkey logo

Comments (5)

FlorianRappl avatar FlorianRappl commented on June 2, 2024 1

Alright, so as this is an edge case (package.json changed, leading to a change for the dev server) we'll exclude it. This implies that changes to the package.json that affect the build (e.g., change of the "app" path) would require a fixed restart. I guess this is a good trade-off, as such scenarios rarely occur and often are expected to come with a manual server restart anyway.

The server would still restart on changes to the krasrc; as it might re-configure the server in crucial areas.

from piral.

carvinlo avatar carvinlo commented on June 2, 2024 1

The server would restart multiple times on changes to the krasrc. version: 1.5.4-beta.6998 image

This is also an edge case. This happens when app-shell's webpack.config.js configures a longer build.
But it no longer affects normal development. Thanks for the quick fix.

from piral.

FlorianRappl avatar FlorianRappl commented on June 2, 2024

The content of the files package.json/.krasrc monitored by fs.watch has not changed, and the server has been restarted.

I don't understand this - the repro steps listen explicitly that the package.json should be modified - so yes, with such a modification the server should restart.

I'll have a look with the repro steps, but a server restart is expected if certain files changed (otherwise you'd need to manually shut down the server and restart it again).

from piral.

carvinlo avatar carvinlo commented on June 2, 2024

The server would restart multiple times on changes to the krasrc.
version: 1.5.4-beta.6998
image

from piral.

FlorianRappl avatar FlorianRappl commented on June 2, 2024

Hm these two are not connected; also I have not seen this myself. I guess we can close it unless you can come up with a reproducible.

from piral.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.