PiletApi's `once` throws when `this` context is `undefined` about piral HOT 6 CLOSED

The main problem / issue that I see is that right now the chaining on an "api" works also with the full API

Ah, I see. I do think though that this is not really "known"/used because TS, at the very least, says that the result is an EventEmitter, not the full API. But fair point.

from piral.

Well bind works or alternatively, you could also make it another lambda ((...args) => events.once(...args)). I think going for the bind is great - let's do that!

Alternatively, let's check the implementation and maybe once can be done in a way that does not require this (and let's check that the others don't suffer from this problem; I think they don't).

from piral.

Alternatively, let's check the implementation and maybe once can be done in a way that does not require this (and let's check that the others don't suffer from this problem; I think they don't).

The others don't seem to have the same problem. I think the only issue that might arise for them in this scenario is that method chaining might be broken. They return this, for example in on:

on(type, callback) {
  // ...
  return this;
}

So, if you were to do on('foo', handler).once('bar', handler) or something similar, you might run into issues.

I think going for the bind is great - let's do that!

Great, sounds like a plan! I'll tackle it.

from piral.

Yeah with the chaining in mind I'd actually improve the basis for this.

We should have the events properly captured.

from piral.

Instead of

return {
  on() {
    // ...
    return this;
  },
  // ...
}

we'd go for

const events = {
  on() {
    // ...
    return events;
  },
  // ...
};
return events;

The main problem / issue that I see is that right now the chaining on an "api" works also with the full API - while with this approach it only works on a subset (events).

from piral.

Ah, I see. I do think though that this is not really "known"/used because TS,

Yes - otherwise it would have been a breaking change.

from piral.