Exception not re-raised in catchall except block about python-lambdarest HOT 5 CLOSED

Lambdarest was made with our stack in focus, we use Cloudwatch and therefore i chose to catch and log instead of elevating exceptions since that would lay off responsibility of replies to Amazon Api Gateway. In general i wanted as much control in my lambda as possible.

But that could be solved by using the pattern flaskand connexion is using (if i remember correctly) of specifying the errorhandler during initialization of lambda_handler.

We could:

lambda_handler = create_lambda_handler(error_handler=None)

Here lambda_handler would raise all errors.

What do you think?

from python-lambdarest.

Great idea! If I understand correctly, the create_lambda_handler() function would have a default error_handler to replicates the behavior of the old exception handling. If set to None, we would just raise the exception.

I implemented this here.

from python-lambdarest.

Awesome, exactly! and i find the solution just as i would have written it. Great work!
I have some feedback (relayed from review of PR):
Can you:
bump the version number in init.py and setup.py to 2.2.6 and write an entry in HISTORY about the change ?

kind regards
Johannes Valbjorn

from python-lambdarest.

thanks, i should have created some guidelines mentioning the manual version stuff.

Merged

from python-lambdarest.

Hi, there I had the same problem and just stumbled across this issue. I agree with the default behavior, because it makes it very easy to get started. However, I think this behavior is worth mentioning in the README, since I had to spend quite some time to figure our why my except block was not being executed.
I will contribute a PR in the next few days.

from python-lambdarest.