Options for configuring CORS and preflight requests about python-lambdarest HOT 5 CLOSED

Turns out SAM already supports this on the API Gateway: https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/sam-property-api-corsconfiguration.html

from python-lambdarest.

It looks like SAM only generates the OPTIONS method handlers. It doesn't also inject Access-Control-Allow-Origin into the handler responses. :(

from python-lambdarest.

https://docs.aws.amazon.com/apigateway/latest/developerguide/how-to-cors.html#apigateway-responding-to-cors-preflight

Enabling CORS support for Lambda or HTTP proxy integrations

For a Lambda proxy integration or HTTP proxy integration, you can still set up the required OPTIONS response headers in API Gateway. However, your backend is responsible for returning the Access-Control-Allow-Origin and Access-Control-Allow-Headers headers, because a proxy integration doesn't return an integration response.

I think it would be good to have the option to do this in create_lambda_handler. Even if I include CORS headers in my responses, they won't be included when an exception is caught inside inner_lambda_handler.

from python-lambdarest.

from python-lambdarest.

hi @sphaugh
your contribution has been released in v12.0.0 🎉 🚀 🚢

... i made one change before doing so:

CORS has been made a function instead of a class as i am a firm believer in not introducing classes where state is unnecessary, benefit is that CORS now returns an enriched lambda_handler
67ca67a#diff-ad335d0f3a324b5d60568c8347280b3d03b93e3e1b17397c766e74a9bb7400afL89

from python-lambdarest.