slaynash / lumbot Goto Github PK

Is your feature request related to a problem? Please describe.

Currently LUM considers incompatible mods to be Missing Dependencies.

Describe the solution you'd like

I think lum could state the two mods that are not compatible with each other. Though I do get that LUM's embed message is getting pretty big now. Might need to start splitting them up (if possible). This splitting could actually make the output more readable, if its not hard to implement that is

Describe alternatives you've considered

LUM could take the first mod as the mod the user should keep, as this is the mod that defines the incompatible mod attribute

Additional context

Excerpt from the log:

[15:37:44.169] Some Melons are marked as incompatible with each other.
To avoid any errors, these Melons will not be loaded.
- 'MapManager' is incompatible with the following Melons:
    - 'MapTweaks'

IncompatibleMods.log

Is your feature request related to a problem? Please describe.

If a filename is not exactly the same as the assembly name, the assembly may not work or just not work well. The behaviour of the assembly seems to be fairly random

Describe the solution you'd like

Simple detection of the file name compared with the assembly name. If they do not match, this is a fatal error. I have done some work for regex, if thats a method you want to use:
(PCRE2): /[a-zA-Z]*\s\([0-999]*\).{1}dll/gm
This would match any file which looks something like assemblyname (1).dll, which occurs whenever a user downloads a mod they already have in their downloads folder (usually the last version or versions)

Describe alternatives you've considered

Could just compare the filename with the assembly name, if this is easier than regex

Additional context

No response

Is your feature request related to a problem? Please describe.

Currently LUM sees UnhollowerBaseLib being missing as simply a missing dependency. For games that used to use it, but no longer use it, this assumption is misleading

Describe the solution you'd like

For games that dont use UnhollowerBaseLib, have LUM report that mods that require it are no longer usable and should be updated if possible

Describe alternatives you've considered

Cant think of anything else.

Additional context

This dependency was replaced in 0.6.0 of MelonLoader with Il2CppInterop

Describe the bug

LUM will post this block of text whenever it detects that a mod requires an older ML version. This is very unhelpful for games who need a different version than the installed mod (like when a mod gets abandoned but users keep trying to use it).

A possible way to make this better is to use expected version of ML and the game version. For instance, The Long Dark's current version (2.27) requires 0.6.1. So if they are on those two versions, lum would not recommend a downgrade.

As for the pairing of the two versions, I would use exact versions instead of ranges. Not every ML version will work with a given game and sometimes new versions of ML (like 0.6.2) are entirely broken.

Block of Text:
Known Errors:
A mod needs a version of MelonLoader before 0.6.x maybe try downgrading to 0.5.7 or updating that mod.

To Reproduce

I dont know how lum detects this

Expected behavior

N/A

Additional context

No response