skyscrapers / terraform-elasticache Goto Github PK

Is your feature request related to a problem? Please describe.

Changing the version (https://github.com/skyscrapers/terraform-elasticache/blob/master/redis/variables.tf#L47) isn't applied immediately. The update will be applied in the next maintenance window:

(https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/elasticache_replication_group)

Describe the solution you'd like

Being able to pass apply_immediately

I was attempting to use this module in my terraform setup - and I received an error saying that the replication group id is limited to 20 characters.

Looking at the source, the id is configured as a combination of the project, the environment, and the name. If the environment is fully typed out - e.g. development or production, this 20-character limit is quickly filled up.

What if there was an additional variable added that could specify the id manually - and if the id wasn't manually specified then it would use what it currently uses (the combination of name, env, and project). The description would continue to have the full output of name-environment-project.

I'm willing to create a PR for it - just wanted to make sure it's an OK solution 😁